Cirrus: Enable updating F28 image

Previously this was disabled as some package was breaking networking on
GCE after updating + rebooting.  This is fixed now, so we should update
packages when building the fedora test VM image.

https://pagure.io/cloud-sig/issue/292

Signed-off-by: Chris Evich <cevich@redhat.com>

.cirrus.yml

@@ -47,6 +47,7 @@ full_vm_testing_task:
             #image_name: "rhel-server-ec2-7-5-165-1-libpod-fce09afe"
             #image_name: "centos-7-v20180911-libpod-fce09afe"
             #image_name: "fedora-cloud-base-28-1-1-7-libpod-fce09afe"
+
     timeout_in: 120m
 
     # Every *_script runs in sequence, for each task. The name prefix is for

contrib/cirrus/lib.sh

@@ -263,7 +263,7 @@ install_varlink(){
 _finalize(){
     echo "Removing leftover giblets from cloud-init"
     cd /
-    sudo rm -rf /var/lib/cloud
+    sudo rm -rf /var/lib/cloud/instance?
     sudo rm -rf /root/.ssh/*
     sudo rm -rf /home/*
 }

contrib/cirrus/packer/fedora_setup.sh

@@ -21,8 +21,7 @@ install_ooe
 export GOPATH="$(mktemp -d)"
 trap "sudo rm -rf $GOPATH" EXIT
 
-# breaks networking on f28/29 in GCE
-# ooe.sh sudo dnf update -y
+ooe.sh sudo dnf update -y
 
 ooe.sh sudo dnf install -y \
     atomic-registries \