opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-25 09:05:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ensure return errors match API docs

Browse Source 
In the API docs, we generally state the type of error that should be returned
if a container or image cannot be found.  In several cases, the code did not
match the API doc, when the API doc was correct.

Signed-off-by: baude <bbaude@redhat.com>

Closes: #1353
Approved by: rhatdan
This commit is contained in:
baude
2018-08-27 12:28:25 -05:00
committed by Atomic Bot
parent 9edea231f1
commit bfedcb4f3c
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/podman/varlink/io.podman.varlink
View File

@ -434,8 +434,7 @@ method ListContainerProcesses(name: string, opts: []string) -> (container: []str
method GetContainerLogs(name: string) -> (container: []string)
# ListContainerChanges takes a name or ID of a container and returns changes between the container and
# its base image. It returns a struct of changed, deleted, and added path names. If the
# container cannot be found, a [ContainerNotFound](#ContainerNotFound) error will be returned.
# its base image. It returns a struct of changed, deleted, and added path names.
method ListContainerChanges(name: string) -> (container: ContainerChanges)
# ExportContainer creates an image from a container. It takes the name or ID of a container and a

2
pkg/varlinkapi/images.go
View File

@ -58,7 +58,7 @@ func (i *LibpodAPI) ListImages(call iopodman.VarlinkCall) error {
func (i *LibpodAPI) GetImage(call iopodman.VarlinkCall, name string) error {
newImage, err := i.Runtime.ImageRuntime().NewFromLocal(name)
if err != nil {
return call.ReplyErrorOccurred(err.Error())
return call.ReplyImageNotFound(err.Error())
}
labels, err := newImage.Labels(getContext())
if err != nil {