opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-23 10:38:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

system tests: new test for run --log-driver

Browse Source 
Tests all (current) values for --log-driver=X, and one test
for invalid value. For those drivers that write a local
file (json-file, k8s-file), test that the file exists and
contains results of the expected form (timestamp, stdout,
'F' for 'F'ull line, and the expected string output.

For json-file, confirm that podman issues a "Choosing k8s-file"
warning (only on local. On podman-remote, the warning goes only
to the server's stderr).

Written in response to #7754 in which driver=json-file was
falling through to 'none' instead of 'k8s-file'.

Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
Ed Santiago
2020-09-23 14:04:20 -06:00
parent a6b300ef7e
commit b60bb3b622
1 changed files with 53 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
test/system/030-run.bats
View File

@ -61,8 +61,8 @@ echo $rand | 0 | $rand
is "$tests_run" "$(grep . <<<$tests | wc -l)" "Ran the full set of tests"
}
@test "podman run - globle runtime option" {
skip_if_remote "runtime flag is not passing over remote"
@test "podman run - global runtime option" {
skip_if_remote "runtime flag is not passed over remote"
run_podman 126 --runtime-flag invalidflag run --rm $IMAGE
is "$output" ".*invalidflag" "failed when passing undefined flags to the runtime"
}
@ -337,4 +337,55 @@ echo $rand | 0 | $rand
run_podman wait $cid
}
# For #7754: json-file was equating to 'none'
@test "podman run --log-driver" {
# '-' means that LogPath will be blank and there's no easy way to test
tests="
none | -
journald | -
k8s-file | y
json-file | f
"
while read driver do_check; do
msg=$(random_string 15)
run_podman run --name myctr --log-driver $driver $IMAGE echo $msg
# Simple output check
# Special case: 'json-file' emits a warning, the rest do not
# ...but with podman-remote the warning is on the server only
if [[ $do_check == 'f' ]] && ! is_remote; then # 'f' for 'fallback'
is "${lines[0]}" ".* level=error msg=\"json-file logging specified but not supported. Choosing k8s-file logging instead\"" \
"Fallback warning emitted"
is "${lines[1]}" "$msg" "basic output sanity check (driver=$driver)"
else
is "$output" "$msg" "basic output sanity check (driver=$driver)"
fi
# Simply confirm that podman preserved our argument as-is
run_podman inspect --format '{{.HostConfig.LogConfig.Type}}' myctr
is "$output" "$driver" "podman inspect: driver"
# If LogPath is non-null, check that it exists and has a valid log
run_podman inspect --format '{{.LogPath}}' myctr
if [[ $do_check != '-' ]]; then
is "$output" "/.*" "LogPath (driver=$driver)"
if ! test -e "$output"; then
die "LogPath (driver=$driver) does not exist: $output"
fi
# eg 2020-09-23T13:34:58.644824420-06:00 stdout F 7aiYtvrqFGJWpak
is "$(< $output)" "[0-9T:.+-]\+ stdout F $msg" \
"LogPath contents (driver=$driver)"
else
is "$output" "" "LogPath (driver=$driver)"
fi
run_podman rm myctr
done < <(parse_table "$tests")
# Invalid log-driver argument
run_podman 125 run --log-driver=InvalidDriver $IMAGE true
is "$output" "Error: error running container create option: invalid log driver: invalid argument" \
"--log-driver InvalidDriver"
}
# vim: filetype=sh