Merge pull request #27687 from mheon/deterministic_pod_inspect

Deterministically order pod inspect fields
This commit is contained in:
openshift-merge-bot[bot]
2025-12-05 14:07:55 +00:00
committed by GitHub
2 changed files with 14 additions and 0 deletions

View File

@@ -6,6 +6,9 @@ import (
"context"
"errors"
"fmt"
"slices"
"sort"
"strings"
"github.com/containers/podman/v6/libpod/define"
"github.com/containers/podman/v6/libpod/events"
@@ -620,6 +623,8 @@ func (p *Pod) Inspect() (*define.InspectPodData, error) {
ctrStatuses[c.ID()] = c.state.State
}
}
slices.SortFunc(ctrs, func(a, b define.InspectPodContainerInfo) int { return strings.Compare(a.ID, b.ID) })
podState, err := createPodStatusResults(ctrStatuses)
if err != nil {
return nil, err
@@ -641,6 +646,7 @@ func (p *Pod) Inspect() (*define.InspectPodData, error) {
sharesNS = append(sharesNS, nsStr)
}
}
sort.Strings(sharesNS)
// Infra config contains detailed information on the pod's infra
// container.

View File

@@ -807,4 +807,12 @@ function thingy_with_unique_id() {
done
}
@test "podman pod inspect ordering" {
local pod_name="p-$(safename)"
run_podman pod create $pod_name
run_podman pod inspect --format '{{ .SharedNamespaces }}' $pod_name
assert "$output" == "[ipc net uts]"
}
# vim: filetype=sh