Merge pull request #2437 from giuseppe/runtime-nice-error

oci: improve error message when the OCI runtime is not found
This commit is contained in:
OpenShift Merge Robot
2019-02-26 14:09:15 +01:00
committed by GitHub

View File

@ -526,6 +526,16 @@ func makeRuntime(runtime *Runtime) (err error) {
if runtime.config.OCIRuntime != "" && runtime.config.OCIRuntime[0] == '/' {
foundRuntime = true
runtime.ociRuntimePath = OCIRuntimePath{Name: filepath.Base(runtime.config.OCIRuntime), Paths: []string{runtime.config.OCIRuntime}}
stat, err := os.Stat(runtime.config.OCIRuntime)
if err != nil {
if os.IsNotExist(err) {
return errors.Wrapf(err, "the specified OCI runtime %s does not exist", runtime.config.OCIRuntime)
}
return errors.Wrapf(err, "cannot stat the OCI runtime path %s", runtime.config.OCIRuntime)
}
if !stat.Mode().IsRegular() {
return fmt.Errorf("the specified OCI runtime %s is not a valid file", runtime.config.OCIRuntime)
}
} else {
// If not, look it up in the configuration.
paths := runtime.config.OCIRuntimes[runtime.config.OCIRuntime]