mirror of
https://github.com/containers/podman.git
synced 2025-05-30 07:04:03 +08:00
new uidmap BATS test: fix
Various problems, one of which was causing the test to fail completely (otherwise I wouldn't have caught the others): - option is --uidmap, not --uidmapping - run_podman cannot be piped (| grep /sys/kernel). That's an unfortunate limitation of BATS. Any invocation of 'run' saves results to $output, which then has to be tested in a separate step. - do so, using 'run' and 'grep' and 'is' to produce readable messages on failure - remove "$expected_rc", that looks like a copy/paste bug from a few lines above. Skip entire test if rootless. (The one without --net=host passes, but it also passes with older podman as both root and rootless. I don't think it's actually testing anything, but agree with leaving it in to catch weird regressions). We really need to get these tests running in CI. Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
@ -32,11 +32,15 @@ echo $rand | 0 | $rand
|
||||
}
|
||||
|
||||
@test "podman run - uidmapping has no /sys/kernel mounts" {
|
||||
run_podman $expected_rc run --uidmapping 0:100:10000 $IMAGE mount | grep /sys/kernel
|
||||
is "$output" "" "podman run $cmd - output"
|
||||
skip_if_rootless "cannot umount as rootless"
|
||||
|
||||
run_podman $expected_rc run --net host --uidmapping 0:100:10000 $IMAGE mount | grep /sys/kernel
|
||||
is "$output" "" "podman run $cmd - output"
|
||||
run_podman run --rm --uidmap 0:100:10000 $IMAGE mount
|
||||
run grep /sys/kernel <(echo "$output")
|
||||
is "$output" "" "unwanted /sys/kernel in 'mount' output"
|
||||
|
||||
run_podman run --rm --net host --uidmap 0:100:10000 $IMAGE mount
|
||||
run grep /sys/kernel <(echo "$output")
|
||||
is "$output" "" "unwanted /sys/kernel in 'mount' output (with --net=host)"
|
||||
}
|
||||
|
||||
# vim: filetype=sh
|
||||
|
Reference in New Issue
Block a user