opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-21 09:28:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

System tests: corner case for run --pull

Browse Source 
Obscure corner case in which 'podman run --pull=never alpine'
will actually pass *with no alpine image* if there's an
image named "myalpine". (i.e. a substring match, not full
string match). Fixed in #7770 but the tests that were added
there do not actually test that.

This adds a double-duty test for that as well as making
sure that 'run --pull=never SHORTNAME' (implicit :latest)
does not match our existing :YYYYMMDD image; then one
more quick test to make sure that if we tag as :latest,
the same --pull=never succeeds.

Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
Ed Santiago
2020-09-29 10:56:40 -06:00
parent 2ee415be90
commit 81d9ba59db
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/system/030-run.bats
View File

@ -153,8 +153,23 @@ echo $rand | 0 | $rand
run_podman run --pull=always $NONLOCAL_IMAGE true
is "$output" "Trying to pull .*" "--pull=always [with image PRESENT]: re-fetches"
# Very weird corner case fixed by #7770: 'podman run foo' will run 'myfoo'
# if it exists, because the string 'foo' appears in 'myfoo'. This test
# covers that, as well as making sure that our testimage (which is always
# tagged :YYYYMMDD, never :latest) doesn't match either.
run_podman tag $IMAGE my${PODMAN_TEST_IMAGE_NAME}:latest
run_podman 125 run --pull=never $PODMAN_TEST_IMAGE_NAME true
is "$output" "Error: unable to find a name and tag match for $PODMAN_TEST_IMAGE_NAME in repotags: no such image" \
"podman run --pull=never with shortname (and implicit :latest)"
# ...but if we add a :latest tag (without 'my'), it should now work
run_podman tag $IMAGE ${PODMAN_TEST_IMAGE_NAME}:latest
run_podman run --pull=never ${PODMAN_TEST_IMAGE_NAME} cat /home/podman/testimage-id
is "$output" "$PODMAN_TEST_IMAGE_TAG" \
"podman run --pull=never, with shortname, succeeds if img is present"
run_podman rm -a
run_podman rmi $NONLOCAL_IMAGE
run_podman rmi $NONLOCAL_IMAGE {my,}${PODMAN_TEST_IMAGE_NAME}:latest
}
# 'run --rmi' deletes the image in the end unless it's used by another container