Fix podman kube generate --help to show correct help message

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This commit is contained in:
Daniel J Walsh
2022-08-16 09:58:02 -04:00
parent 3aa92010df
commit 5f09d9b60d
2 changed files with 25 additions and 19 deletions

View File

@ -22,7 +22,7 @@ var (
Whether the input is for a container or pod, Podman will always generate the specification as a pod.`
generateKubeCmd = &cobra.Command{
kubeGenerateCmd = &cobra.Command{
Use: "generate [options] {CONTAINER...|POD...|VOLUME...}",
Short: "Generate Kubernetes YAML from containers, pods or volumes.",
Long: generateDescription,
@ -35,33 +35,28 @@ var (
podman kube generate volumeName
podman kube generate ctrID podID volumeName --service`,
}
kubeGenerateDescription = generateDescription
kubeGenerateCmd = &cobra.Command{
generateKubeCmd = &cobra.Command{
Use: "kube [options] {CONTAINER...|POD...|VOLUME...}",
Short: "Generate Kubernetes YAML from containers, pods or volumes.",
Long: kubeGenerateDescription,
RunE: kubeGenerate,
Args: cobra.MinimumNArgs(1),
ValidArgsFunction: common.AutocompleteForGenerate,
Example: `podman kube generate ctrID
podman kube generate podID
podman kube generate --service podID
podman kube generate volumeName
podman kube generate ctrID podID volumeName --service`,
Short: kubeGenerateCmd.Short,
Long: kubeGenerateCmd.Long,
RunE: kubeGenerateCmd.RunE,
Args: kubeGenerateCmd.Args,
ValidArgsFunction: kubeGenerateCmd.ValidArgsFunction,
Example: kubeGenerateCmd.Example,
}
)
func init() {
registry.Commands = append(registry.Commands, registry.CliCommand{
Command: generateKubeCmd,
Parent: kubeCmd,
Parent: generate.GenerateCmd,
})
generateFlags(generateKubeCmd)
registry.Commands = append(registry.Commands, registry.CliCommand{
Command: kubeGenerateCmd,
Parent: generate.GenerateCmd,
Parent: kubeCmd,
})
generateFlags(kubeGenerateCmd)
}
@ -103,7 +98,3 @@ func generateKube(cmd *cobra.Command, args []string) error {
fmt.Println(string(content))
return nil
}
func kubeGenerate(cmd *cobra.Command, args []string) error {
return generateKube(cmd, args)
}

15
test/system/710-kube.bats Normal file
View File

@ -0,0 +1,15 @@
#!/usr/bin/env bats -*- bats -*-
#
# Test podman kube generate
#
load helpers
@test "podman kube generate - basic" {
run_podman kube generate --help
is "$output" ".*podman.* kube generate \[options\] {CONTAINER...|POD...|VOLUME...}"
run_podman generate kube --help
is "$output" ".*podman.* generate kube \[options\] {CONTAINER...|POD...|VOLUME...}"
}
# vim: filetype=sh