opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-10-18 11:42:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Quadlet: exit 0 when there are no files to process

Browse Source 
Quadlet should not exit with failure if no files to process have been
found.  Otherwise, even simple operations such as reloading systemd
will fail as it retriggers generators.

Fixes: #17374
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
This commit is contained in:
Valentin Rothberg
2023-02-07 10:48:31 +01:00
committed by Ashley Cui
parent 7378b758ab
commit 52ae4a2c40
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/quadlet/main.go
View File

@ -327,8 +327,10 @@ func main() {
}
if len(units) == 0 {
// containers/podman/issues/17374: exit cleanly but log that we
// had nothing to do
Debugf("No files to parse from %s", sourcePaths)
os.Exit(1)
os.Exit(0)
}
if !dryRun {

2
test/e2e/quadlet_test.go
View File

@ -365,7 +365,7 @@ var _ = Describe("quadlet system generator", func() {
session := podmanTest.Quadlet([]string{"-dryrun"}, "/something")
session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(1))
Expect(session).Should(Exit(0))
current := session.ErrorToStringArray()
expected := "No files to parse from [/something]"