opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-24 03:08:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

e2e: refactor and document serialization

Browse Source 
Followup to #18578: move Serial to Describe(), in case new
tests get added to this module. And, explain the reasoning.

Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
Ed Santiago
2023-05-16 04:48:55 -06:00
parent e2d1ad1fb2
commit 4bed2c285c
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/e2e/image_sign_test.go
View File

@ -10,7 +10,10 @@ import (
. "github.com/onsi/gomega/gexec"
)
var _ = Describe("Podman image sign", func() {
// Each of these tests runs with a different GNUPGHOME; gpg-agent blows up
// if these run in parallel. We use Serial, not Ordered, because tests in
// trust_test.go also rely on gpg and can't coexist with us.
var _ = Describe("Podman image sign", Serial, func() {
var origGNUPGHOME string
BeforeEach(func() {
@ -36,7 +39,7 @@ var _ = Describe("Podman image sign", func() {
os.Setenv("GNUPGHOME", origGNUPGHOME)
})
It("podman sign image", Serial, func() {
It("podman sign image", func() {
cmd := exec.Command("gpg", "--import", "sign/secret-key.asc")
cmd.Stdout = GinkgoWriter
cmd.Stderr = GinkgoWriter
@ -52,7 +55,7 @@ var _ = Describe("Podman image sign", func() {
Expect(err).ToNot(HaveOccurred())
})
It("podman sign --all multi-arch image", Serial, func() {
It("podman sign --all multi-arch image", func() {
cmd := exec.Command("gpg", "--import", "sign/secret-key.asc")
cmd.Stdout = GinkgoWriter
cmd.Stderr = GinkgoWriter