opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-08-06 03:19:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

libpod: read exit code when cleaning up the runtime

Browse Source 
While for some call paths we may be doing this redundantly we need to
make sure the exit code is always read at this point.

[NO NEW TESTS NEEDED] as I do not manage to reproduce the issue which
is very likely caused by a code path not writing the exit code when
running concurrently.

Fixes: #14859
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
This commit is contained in:
Valentin Rothberg
2022-07-08 15:36:02 +02:00
parent 62cdc387de
commit 3bb4cf8ee2
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libpod/container_internal.go
View File

@ -1104,6 +1104,12 @@ func (c *Container) cleanupRuntime(ctx context.Context) error {
return nil
}
// We may be doing this redundantly for some call paths but we need to
// make sure the exit code is being read at this point.
if err := c.checkExitFile(); err != nil {
return err
}
// If necessary, delete attach and ctl files
if err := c.removeConmonFiles(); err != nil {
return err