opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-10-16 18:53:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove imagefilter for varlink remote client

Browse Source 
the api for getting images changed to use filters but back level podman versions cannot handle it.  so temporarily disabling the filtering for remote clients until the restful approach can be used.

Signed-off-by: Brent Baude <bbaude@redhat.com>
This commit is contained in:
Brent Baude
2020-03-12 12:43:32 -05:00
parent 9c7481dbd1
commit 3aa58ccd0a
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/podman/images.go
View File

@ -155,7 +155,7 @@ func imagesCmd(c *cliconfig.ImagesValues) error {
return errors.New("can not specify an image and a filter")
}
filters := c.Filter
if len(filters) < 1 {
if len(filters) < 1 && len(image) > 0 {
filters = append(filters, fmt.Sprintf("reference=%s", image))
}

5
pkg/adapter/runtime_remote.go
View File

@ -201,8 +201,11 @@ func (r *LocalRuntime) GetRWImages() ([]*ContainerImage, error) {
}
func (r *LocalRuntime) GetFilteredImages(filters []string, rwOnly bool) ([]*ContainerImage, error) {
if len(filters) > 0 {
return nil, errors.Wrap(define.ErrNotImplemented, "filtering images is not supported on the remote client")
}
var newImages []*ContainerImage
images, err := iopodman.ListImagesWithFilters().Call(r.Conn, filters)
images, err := iopodman.ListImages().Call(r.Conn)
if err != nil {
return nil, err
}