opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-29 13:12:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Parent is now always passed in via Context, intead of Span or SpanContext (#1146)

Browse Source 
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
This commit is contained in:
alrex
2020-10-08 08:39:04 -07:00
committed by GitHub
parent 9641c8a62c
commit b630d65294
7 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/opentelemetry-docker-tests/tests/mysql/test_mysql_functional.py
View File

@ -68,7 +68,7 @@ class TestFunctionalMysql(TestBase):
self.assertEqual(root_span.name, "rootSpan")
self.assertEqual(db_span.name, "mysql.opentelemetry-tests")
self.assertIsNotNone(db_span.parent)
self.assertIs(db_span.parent, root_span.get_context())
self.assertIs(db_span.parent, root_span.get_span_context())
self.assertIs(db_span.kind, trace_api.SpanKind.CLIENT)
self.assertEqual(db_span.attributes["db.instance"], MYSQL_DB_NAME)
self.assertEqual(db_span.attributes["net.peer.name"], MYSQL_HOST)

4
tests/opentelemetry-docker-tests/tests/postgres/test_aiopg_functional.py
View File

@ -76,7 +76,7 @@ class TestFunctionalAiopgConnect(TestBase):
self.assertEqual(root_span.name, "rootSpan")
self.assertEqual(child_span.name, "postgresql.opentelemetry-tests")
self.assertIsNotNone(child_span.parent)
self.assertIs(child_span.parent, root_span.get_context())
self.assertIs(child_span.parent, root_span.get_span_context())
self.assertIs(child_span.kind, trace_api.SpanKind.CLIENT)
self.assertEqual(
child_span.attributes["db.instance"], POSTGRES_DB_NAME
@ -157,7 +157,7 @@ class TestFunctionalAiopgCreatePool(TestBase):
self.assertEqual(root_span.name, "rootSpan")
self.assertEqual(child_span.name, "postgresql.opentelemetry-tests")
self.assertIsNotNone(child_span.parent)
self.assertIs(child_span.parent, root_span.get_context())
self.assertIs(child_span.parent, root_span.get_span_context())
self.assertIs(child_span.kind, trace_api.SpanKind.CLIENT)
self.assertEqual(
child_span.attributes["db.instance"], POSTGRES_DB_NAME

2
tests/opentelemetry-docker-tests/tests/postgres/test_psycopg_functional.py
View File

@ -68,7 +68,7 @@ class TestFunctionalPsycopg(TestBase):
self.assertEqual(root_span.name, "rootSpan")
self.assertEqual(child_span.name, "postgresql.opentelemetry-tests")
self.assertIsNotNone(child_span.parent)
self.assertIs(child_span.parent, root_span.get_context())
self.assertIs(child_span.parent, root_span.get_span_context())
self.assertIs(child_span.kind, trace_api.SpanKind.CLIENT)
self.assertEqual(
child_span.attributes["db.instance"], POSTGRES_DB_NAME

2
tests/opentelemetry-docker-tests/tests/pymongo/test_pymongo_functional.py
View File

@ -51,7 +51,7 @@ class TestFunctionalPymongo(TestBase):
self.assertIsNot(root_span, None)
self.assertIsNot(pymongo_span, None)
self.assertIsNotNone(pymongo_span.parent)
self.assertIs(pymongo_span.parent, root_span.get_context())
self.assertIs(pymongo_span.parent, root_span.get_span_context())
self.assertIs(pymongo_span.kind, trace_api.SpanKind.CLIENT)
self.assertEqual(
pymongo_span.attributes["db.instance"], MONGODB_DB_NAME

2
tests/opentelemetry-docker-tests/tests/pymysql/test_pymysql_functional.py
View File

@ -65,7 +65,7 @@ class TestFunctionalPyMysql(TestBase):
self.assertEqual(root_span.name, "rootSpan")
self.assertEqual(db_span.name, "mysql.opentelemetry-tests")
self.assertIsNotNone(db_span.parent)
self.assertIs(db_span.parent, root_span.get_context())
self.assertIs(db_span.parent, root_span.get_span_context())
self.assertIs(db_span.kind, trace_api.SpanKind.CLIENT)
self.assertEqual(db_span.attributes["db.instance"], MYSQL_DB_NAME)
self.assertEqual(db_span.attributes["net.peer.name"], MYSQL_HOST)

2
tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py
View File

@ -109,7 +109,7 @@ class TestRedisInstrument(TestBase):
# confirm the parenting
self.assertIsNone(parent_span.parent)
self.assertIs(child_span.parent, parent_span.get_context())
self.assertIs(child_span.parent, parent_span.get_span_context())
self.assertEqual(parent_span.name, "redis_get")
self.assertEqual(parent_span.instrumentation_info.name, "redis_svc")

2
tests/opentelemetry-docker-tests/tests/sqlalchemy_tests/mixins.py
View File

@ -175,7 +175,7 @@ class SQLAlchemyTestMixin(TestBase):
# confirm the parenting
self.assertIsNone(parent_span.parent)
self.assertIs(child_span.parent, parent_span.get_context())
self.assertIs(child_span.parent, parent_span.get_span_context())
self.assertEqual(parent_span.name, "sqlalch_op")
self.assertEqual(parent_span.instrumentation_info.name, "sqlalch_svc")