opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-29 13:12:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix CI Failure (#1680)

Browse Source 
* Fix CI Failure

* Actually fix

* Should be fixed now?

* Update tox.ini

* Disable test

* pypy3.7
This commit is contained in:
Srikanth Chekuri
2023-02-17 22:02:10 +05:30
committed by GitHub
parent ffbbb4d8e3
commit 79d00ee7d3
3 changed files with 29 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/test.yml vendored
View File

@ -6,7 +6,7 @@ on:
- 'release/*'
pull_request:
env:
CORE_REPO_SHA: 042d7a7921e25936decd95addf4fb1d30afb88e2
CORE_REPO_SHA: e03650ac45cb74510f779f6e27fe4b920095f8be
jobs:
build:

42
instrumentation/opentelemetry-instrumentation-tornado/tests/test_instrumentation.py
View File

@ -494,28 +494,32 @@ class TestTornadoInstrumentation(TornadoTest, WsgiTestBase):
self.memory_exporter.clear()
set_global_response_propagator(orig)
def test_credential_removal(self):
response = self.fetch(
"http://username:password@httpbin.org/status/200"
)
self.assertEqual(response.code, 200)
# todo(srikanthccv): fix this test
# this test is making request to real httpbin.org/status/200 which
# is not a good idea as it can fail due to availability of the
# service.
# def test_credential_removal(self):
# response = self.fetch(
# "http://username:password@httpbin.org/status/200"
# )
# self.assertEqual(response.code, 200)
spans = self.sorted_spans(self.memory_exporter.get_finished_spans())
self.assertEqual(len(spans), 1)
client = spans[0]
# spans = self.sorted_spans(self.memory_exporter.get_finished_spans())
# self.assertEqual(len(spans), 1)
# client = spans[0]
self.assertEqual(client.name, "GET")
self.assertEqual(client.kind, SpanKind.CLIENT)
self.assertSpanHasAttributes(
client,
{
SpanAttributes.HTTP_URL: "http://httpbin.org/status/200",
SpanAttributes.HTTP_METHOD: "GET",
SpanAttributes.HTTP_STATUS_CODE: 200,
},
)
# self.assertEqual(client.name, "GET")
# self.assertEqual(client.kind, SpanKind.CLIENT)
# self.assertSpanHasAttributes(
# client,
# {
# SpanAttributes.HTTP_URL: "http://httpbin.org/status/200",
# SpanAttributes.HTTP_METHOD: "GET",
# SpanAttributes.HTTP_STATUS_CODE: 200,
# },
# )
self.memory_exporter.clear()
# self.memory_exporter.clear()
class TestTornadoInstrumentationWithXHeaders(TornadoTest):

7
tox.ini
View File

@ -168,8 +168,11 @@ envlist =
; instrumentation-remoulade intentionally excluded from pypy3
; opentelemetry-instrumentation-celery
py3{7,8,9,10,11}-test-instrumentation-celery
pypy3-test-instrumentation-celery
; celery tests don't run on 3.7 because our opentelemetry-api requires importlib-metadata >= 5.0.0
; but celery requires importlib-metadata < 5.0.0
; see https://github.com/celery/celery/issues/7783 for more details
py3{8,9,10,11}-test-instrumentation-celery
; pypy3-test-instrumentation-celery
; opentelemetry-instrumentation-sklearn
py3{7,8}-test-instrumentation-sklearn