opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-28 04:34:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix unit in system metrics (#2922)

Browse Source
This commit is contained in:
Mengyi Zhou (bjrara)
2024-10-25 12:00:37 -07:00
committed by GitHub
parent e49806ea35
commit 779ec9eb93
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -30,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#2874](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2874))
- `opentelemetry-instrumentation-confluent-kafka` Fix to allow `topic` to be extracted from `kwargs` in `produce()`
([#2901])(https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2901)
- `opentelemetry-instrumentation-system-metrics` Update metric units to conform to UCUM conventions.
([#2922](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2922))
### Breaking changes

18
instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
View File

@ -190,7 +190,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name="system.cpu.time",
callbacks=[self._get_system_cpu_time],
description="System CPU time",
unit="seconds",
unit="s",
)
if "system.cpu.utilization" in self._config:
@ -206,7 +206,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name="system.memory.usage",
callbacks=[self._get_system_memory_usage],
description="System memory usage",
unit="bytes",
unit="By",
)
if "system.memory.utilization" in self._config:
@ -257,7 +257,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name="system.disk.io",
callbacks=[self._get_system_disk_io],
description="System disk IO",
unit="bytes",
unit="By",
)
if "system.disk.operations" in self._config:
@ -273,7 +273,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name="system.disk.time",
callbacks=[self._get_system_disk_time],
description="System disk time",
unit="seconds",
unit="s",
)
# TODO Add _get_system_filesystem_usage
@ -282,7 +282,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
# callback=self._get_system_filesystem_usage,
# name="system.filesystem.usage",
# description="System filesystem usage",
# unit="bytes",
# unit="By",
# value_type=int,
# )
@ -327,7 +327,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name="system.network.io",
callbacks=[self._get_system_network_io],
description="System network io",
unit="bytes",
unit="By",
)
if "system.network.connections" in self._config:
@ -350,7 +350,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name=f"process.runtime.{self._python_implementation}.memory",
callbacks=[self._get_runtime_memory],
description=f"Runtime {self._python_implementation} memory",
unit="bytes",
unit="By",
)
if "process.runtime.cpu.time" in self._config:
@ -358,7 +358,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name=f"process.runtime.{self._python_implementation}.cpu_time",
callbacks=[self._get_runtime_cpu_time],
description=f"Runtime {self._python_implementation} CPU time",
unit="seconds",
unit="s",
)
if "process.runtime.gc_count" in self._config:
@ -371,7 +371,7 @@ class SystemMetricsInstrumentor(BaseInstrumentor):
name=f"process.runtime.{self._python_implementation}.gc_count",
callbacks=[self._get_runtime_gc_count],
description=f"Runtime {self._python_implementation} GC count",
unit="bytes",
unit="By",
)
if "process.runtime.thread_count" in self._config: