opensource/opentelemetry-python-contrib
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git synced 2025-07-29 21:23:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Adding unit tests for conditional server span creation in starlette (#897)

Browse Source 
* Adding unit tests for conditional server span creation in starlette

* Adding changelog entry and renaming function

* Update CHANGELOG.md

Removing changelog entry

Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>

Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
This commit is contained in:
Ashutosh Goel
2022-02-03 21:57:06 +05:30
committed by GitHub
parent c0eba00244
commit 0180b837ee
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
instrumentation/opentelemetry-instrumentation-starlette/tests/test_starlette_instrumentation.py
View File

@ -24,6 +24,7 @@ import opentelemetry.instrumentation.starlette as otel_starlette
from opentelemetry.sdk.resources import Resource
from opentelemetry.semconv.trace import SpanAttributes
from opentelemetry.test.test_base import TestBase
from opentelemetry.trace import SpanKind, get_tracer
from opentelemetry.util.http import get_excluded_urls
@ -225,3 +226,21 @@ class TestAutoInstrumentationLogic(unittest.TestCase):
should_be_original = applications.Starlette
self.assertIs(original, should_be_original)
class TestConditonalServerSpanCreation(TestStarletteManualInstrumentation):
def test_mark_span_internal_in_presence_of_another_span(self):
tracer = get_tracer(__name__)
with tracer.start_as_current_span(
"test", kind=SpanKind.SERVER
) as parent_span:
self._client.get("/foobar")
spans = self.sorted_spans(
self.memory_exporter.get_finished_spans()
)
starlette_span = spans[2]
self.assertEqual(SpanKind.INTERNAL, starlette_span.kind)
self.assertEqual(SpanKind.SERVER, parent_span.kind)
self.assertEqual(
parent_span.context.span_id, starlette_span.parent.span_id
)