opensource/manim
1
0
Fork 0
mirror of https://github.com/3b1b/manim.git synced 2025-08-02 19:46:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed camera bugs

Browse Source
This commit is contained in:
Grant Sanderson
2018-08-22 21:22:50 -07:00
parent 86bc9cdf72
commit 98801413e9
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
camera/camera.py
View File

@ -547,7 +547,7 @@ class Camera(object):
points[violator_indices] = rescaled
return points
def transform_points_pre_display(self, points, mobject):
def transform_points_pre_display(self, mobject, points):
# Subclasses (like ThreeDCamera) may want to
# adjust points before they're shown
return points

11
camera/three_d_camera.py
View File

@ -17,6 +17,7 @@ from utils.color import get_shaded_rgb
from utils.space_ops import rotation_about_z
from utils.space_ops import rotation_matrix
from utils.space_ops import center_of_mass
from utils.simple_functions import fdiv
class ThreeDCamera(Camera):
@ -166,9 +167,15 @@ class ThreeDCamera(Camera):
points -= frame_center
points = np.dot(points, rot_matrix.T)
zs = points[:, 2]
zs[zs >= distance] = distance - 0.001
for i in 0, 1:
points[:, i] *= distance / (distance - zs)
# Proper projedtion would involve multiplying
# x and y by d / (d-z). But for points with high
# z value, this causes weird artifacts, and applying
# the exponential helps smooth it out.
factor = np.exp(zs / distance)
lt0 = zs < 0
factor[lt0] = (distance / (distance - zs[lt0]))
points[:, i] *= factor
points += frame_center
return points