opensource/lotus
1
0
Fork 0
mirror of https://github.com/filecoin-project/lotus.git synced 2025-08-06 16:41:19 +08:00
Code Issues Projects Releases Wiki Activity

feat: fall back to EC if F3 finalized tipeset is older than 900 epochs (#13066)

Browse Source 
* Fall back to EC if F3 finalized tipeset is older than 900 epochs

In Lotus v2 APIs, in an event where F3 finalized tipset is too far
behind EC, > 900 epochs return EC finalized tipset.

Part of: https://github.com/filecoin-project/lotus/issues/13062

* Update changelog
This commit is contained in:
Masih H. Derkani
2025-04-25 13:05:06 +01:00
committed by GitHub
parent 9bf897712b
commit 6b832d6367
3 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -13,6 +13,8 @@
- fix(deps): fix Ledger hardware wallet support ([filecoin-project/lotus#13048](https://github.com/filecoin-project/lotus/pull/13048))
- fix(eth): always return nil for eth transactions not found ([filecoin-project/lotus#12999](https://github.com/filecoin-project/lotus/pull/12999))
- feat: add gas to application metric reporting `vm/applyblocks_early_gas`, `vm/applyblocks_messages_gas`, `vm/applyblocks_cron_gas` ([filecoin-project/lotus#13030](https://github.com/filecoin-project/lotus/pull/13030))
- feat: fall back to EC if F3 finalized tipeset is older than 900 epochs ([filecoin-project/lotus#13066](https://github.com/filecoin-project/lotus/pull/13066))
### Experimental v2 APIs with F3 awareness

12
itests/api_v2_test.go
View File

@ -133,6 +133,18 @@ func TestAPIV2_ThroughRPC(t *testing.T) {
wantTipSet: tipSetAtHeight(f3FinalizedEpoch),
wantResponseStatus: http.StatusOK,
},
{
name: "old f3 finalized falls back to ec",
when: func(t *testing.T) {
mockF3.Running = true
mockF3.Finalizing = true
mockF3.LatestCertErr = nil
mockF3.LatestCert = plausibleCertAt(t, targetHeight-policy.ChainFinality-5)
},
request: `{"jsonrpc":"2.0","method":"Filecoin.ChainGetTipSet","params":[{"tag":"finalized"}],"id":1}`,
wantTipSet: tipSetAtHeight(targetHeight - policy.ChainFinality),
wantResponseStatus: http.StatusOK,
},
{
name: "safe tag is ec safe distance when more recent than f3 finalized",
when: func(t *testing.T) {

17
node/impl/full/chain_v2.go
View File

@ -8,6 +8,7 @@ import (
"golang.org/x/xerrors"
"github.com/filecoin-project/go-f3"
"github.com/filecoin-project/go-state-types/abi"
"github.com/filecoin-project/lotus/api"
"github.com/filecoin-project/lotus/build/buildconstants"
@ -107,7 +108,21 @@ func (cm *ChainModuleV2) getLatestFinalizedTipset(ctx context.Context) (*types.T
}
// Extract the finalized tipeset from the certificate.
tsk, err := types.TipSetKeyFromBytes(cert.ECChain.Head().Key)
latestF3FinalizedTipSet := cert.ECChain.Head()
// Fall back to EC finality if the latest F3 finalized tipset is older than EC finality.
latestF3FinalizedEpoch := abi.ChainEpoch(latestF3FinalizedTipSet.Epoch)
head := cm.Chain.GetHeaviestTipSet()
if head == nil {
return nil, xerrors.New("no known heaviest tipset")
}
if head.Height()-latestF3FinalizedEpoch > policy.ChainFinality {
log.Debugw("Latest F3 finalized tipset is older than EC finality, falling back to EC finality", "headEpoch", head.Height(), "latestF3FinalizedEpoch", latestF3FinalizedEpoch)
return cm.getECFinalized(ctx)
}
// All good, load the latest F3 finalized tipset.
tsk, err := types.TipSetKeyFromBytes(latestF3FinalizedTipSet.Key)
if err != nil {
return nil, xerrors.Errorf("decoding latest f3 cert tipset key: %w", err)
}