opensource/loki
1
0
Fork 0
mirror of https://github.com/grafana/loki.git synced 2026-03-13 09:33:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(engine): don't observe task execution time if there's no assign time (#20956)

Browse Source
This commit is contained in:
Robert Fratto
2026-02-24 14:59:00 -05:00
committed by GitHub
parent 13c964d4b8
commit 9546636275
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/engine/internal/scheduler/scheduler.go
View File

@@ -285,9 +285,14 @@ func (s *Scheduler) handleTaskStatus(ctx context.Context, worker *workerConn, ms
owner.Unassign(task)
}
if task.status.State == workflow.TaskStateCompleted {
if task.status.State == workflow.TaskStateCompleted && !task.assignTime.IsZero() {
// The execution time of the task is the duration from when it was
// first assigned to when we received the completion status.
//
// We skip the observation when assignTime is zero, which can happen
// when a task completes before we can process the assignment. If we
// didn't skip these, we'd record an observation of the maximum
// time.Duration value (290 years).
s.metrics.taskExecSeconds.Observe(time.Since(task.assignTime).Seconds())
}