781dfa1252
cleanup name publish argument tests
...
1. Don't bother testing the peer IDs. These commands won't ever use them.
2. Move the `--help` test out from in-between the missing argument tests.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-19 16:31:07 -07:00
3bb59efade
add sharness test for #4837
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-19 16:00:51 -07:00
7824c2cf4e
check arguments after handling help
...
otherwise, we block on required arguments from stdin before processing the help
flag.
fixes #4837
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-19 15:58:34 -07:00
4bdbe1a993
Merge pull request #4827 from ipfs/fix/4823
...
pre-populate required arguments from request body
2018-03-18 22:19:15 -07:00
4e9a6c7eab
add regression test for #4823
...
for both online and offline mode (tests both the cli and the api)
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-18 13:04:50 -07:00
45fd7d213f
pre-populate required arguments from request body
...
This way, we can always assume that indexing a required argument works.
Also:
* test that the command tree doesn't have any obvious bugs (duplicate options,
arguments in the wrong order, etc).
* simplify the usage ParseBodyArgs.
* remove unnecessary check in the get command.
fixes #4823
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-18 13:04:25 -07:00
958483f6bc
Merge pull request #4822 from ipfs/fix/emit-once
...
fix: use EmitOnce where only single response is to be sent
2018-03-17 11:35:17 -07:00
7f1868aef2
Merge pull request #4826 from ipfs/fix/rm-string-arguments
...
upgrade commands that used StringArguments
2018-03-17 11:34:58 -07:00
873a9aa2b8
Merge pull request #4825 from ipfs/fix/cmds-stuff
...
delete dead code
2018-03-17 11:34:30 -07:00
c24a08be2e
delete dead code
...
This code was making it *really* hard to understand the commands code.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-16 20:34:36 -07:00
116269a12b
upgrade commands that used StringArguments
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-03-16 20:06:54 -07:00
ead64854e6
cmd/pubsub: fix pubsub peers format brakage
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-17 02:48:27 +01:00
42d1aa5bf7
cmd/pubsub: fix pubsub ls
emiting plain strings instead of JSON
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-16 14:01:37 +01:00
59178057a2
fix: use EmitOnce where only single response is to be sent
...
Part of #4818
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-16 10:17:34 +01:00
682b263f3a
Merge pull request #4813 from ipfs/release-0.4.14-rc2
...
ipfs release 0.4.14-rc2
v0.4.14-rc2
2018-03-13 15:38:24 -07:00
f071e91e6b
ipfs release 0.4.14-rc2
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-03-13 15:11:29 -07:00
ba3cd5b38d
Merge pull request #4790 from ipfs/fix/tar-eof
...
tar: fix Go 1.10 breakage
2018-03-12 10:28:18 -07:00
5622cc5bb3
Merge pull request #4772 from ipfs/misc/codeowners
...
misc: create CODEOWNERS file
2018-03-08 17:47:16 -08:00
1b96ad7327
ci: upgrade Jenkins to Go 1.10
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-08 04:17:47 +01:00
16dad7515b
tar: fix Go 1.10 breakage
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-08 04:17:47 +01:00
b002acc689
Merge pull request #4759 from ipfs/release-0.4.14
...
prepare for 0.4.14 release
v0.4.14-rc1
2018-03-06 16:30:04 -08:00
12c22e38a2
add initial changelog for 0.4.14
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-03-06 15:54:27 -08:00
8785696fbd
misc: create CODEOWNERS file
...
This will cause me being tagged for review of every PR, unless we have
subsystem owners, then they will be tagged for review.
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-06 00:49:53 +01:00
c00482ab19
Merge pull request #4727 from ipfs/fix/4726
...
fix race in TestWantlistClearsOnCancel
2018-03-05 12:28:10 -08:00
13887ff2c7
Merge pull request #4751 from ipfs/feat/safe-cid
...
Disallow usage of unsafe hashes for reading and adding content
2018-03-05 12:25:26 -08:00
a54402655b
Merge pull request #4770 from ipfs/fix/pubsub-stdin
...
fix pubsub pub reading stdin args
2018-03-05 12:23:40 -08:00
dd40a5a2d5
fix pubsub pub reading stdin args
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-03-05 11:45:11 -08:00
45272790a2
don't reprovide inssecure hashes
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-05 19:38:25 +01:00
60018d3ee8
cid_secuirty: add test for gc
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-05 19:38:25 +01:00
bea666f3cd
Merge pull request #4725 from MichaelMure/filesstatlocal
...
make files stat --with-local return immediately when no data is present
2018-03-05 09:39:34 -08:00
51bf1b6cd4
Significanly improve GC UX with verifcid
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:43:42 +01:00
a9417a144c
fix ipfs pin verify --verbose
not working
...
Resolves https://github.com/ipfs/go-ipfs/issues/4761
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:38:17 +01:00
f1125f0066
add hash security note
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:38:17 +01:00
9634991112
Add sharness tests for CID security
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:38:17 +01:00
bcedd38c9a
//hash -> // hash
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:38:17 +01:00
578cb240d4
Move the temporary packages to thirdparty
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:38:17 +01:00
c30422d790
Enforce Cid security rules for getting and adding blocks
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:38:17 +01:00
903ecd1a7b
Include validatecid from new cid package
...
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2018-03-04 01:38:17 +01:00
de92ff6961
Merge pull request #4752 from ipfs/misc/PNettypo
...
Fix "PNetFingerpint" field typo of core.IpfsNode
2018-03-03 15:10:46 -08:00
fbc495db4c
Fix "PNetFingerpint" field typo of core.IpfsNode
...
License: MIT
Signed-off-by: Jason Chang <ridewindx@163.com>
2018-03-01 22:17:10 +01:00
199a52d777
Merge pull request #4738 from ipfs/fix/rm-println
...
remove a spurious debug message
2018-02-26 11:46:25 -08:00
2e77f73d53
remove a spurious debug message
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-02-26 10:27:06 -08:00
e3d9e05ec2
fix race in TestWantlistClearsOnCancel
...
fixes #4726
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-21 12:35:56 -08:00
e2bad6ec5e
make files stat --with-local return immediately when no data is present
...
License: MIT
Signed-off-by: Michael Muré <batolettre@gmail.com>
2018-02-21 18:41:40 +01:00
95f308da20
Merge pull request #4724 from ipfs/gx/update-cmds
...
update go-ipfs-cmds
2018-02-20 20:47:22 -08:00
ca3b8224f6
remove some dead code
...
(it was causing go vet to complain)
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 17:39:16 -08:00
45756b6d64
fix a bunch of go vet errors
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 17:37:35 -08:00
868855f625
fix legacy commands test for cmds lib changes
...
cmd.Call no longer returns an error
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 17:24:16 -08:00
2c68c15407
update go-ipfs-cmds
...
* May fix #4670
* Fixes #4683
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 16:43:00 -08:00
2ee4543c3e
Merge pull request #4713 from ipfs/feat/split-path-resolver
...
Feat: Separate "path" from "path/resolver"
2018-02-20 09:55:36 -08:00