61b1d2f258
remove todo
...
I've looked into this and I agree, Online was always false (and should be in
this case, anyways).
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 19:59:21 -08:00
4e796fd9a8
remove todo file
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 12:34:15 -08:00
4909c5a56d
correctly handle add flag constraints
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 12:30:55 -08:00
fcef972cda
restore call to getOutPath function
...
It strips the last `/` which was part of a partial fix for #3729 . Unfortunately,
it's not a *real* fix but we might as well leave this as it is until we
completely fix it.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 12:13:37 -08:00
2f964d40e8
forbid bad compression levels
...
(instead of allowing -1 and treating it as "use default")
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 11:55:04 -08:00
888c5fc437
remove useless cast
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 11:54:56 -08:00
9cc6285be1
remove debugging print statement
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 11:54:50 -08:00
e00f903c82
return background context instead of nil
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 11:54:39 -08:00
a17f8c0e17
fix changes from recent commands
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:14:26 -08:00
176d15656d
update go-ipfs-cmds, fix context closing issue
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
0bdc2574ce
update go-ipfs-cmds
...
Fix a nil pointer exception when no timeout is set and an HTTP request fails.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
0e680716bd
put immediate error second
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
652ac620b1
golint: documentation fixes
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
9080a588d8
golint: fix variable name
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
6bf29205bc
remove progress bar size hack
...
Compute the size in the PostCmd instead of the PreCmd.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
5583c442bf
fix commands list test
...
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
d256c5ba38
avoid using the TODO context in tests
...
Instead, properly create and cancel the context.
(also, use subtests)
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
cddef3ec5e
use PostRunMap when constructing PostRun in commands
...
Writing out the full type explicitly is ugly and verbose.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
2e2996223f
fix legacy tests
...
* remove test for removed feature
* fix `TestNewCommand` test.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
bf804cca66
update to final cmds1.0
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
267c19ab9d
some fixes for latest from go-ipfs-cmds
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
d93c0b6a4b
Revert "use *oldcmds.Context consistently instead of non-ptr"
...
This reverts commit 852adb1c4a42a254286ac26b3bae7ea3a7bb69df.
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
c2ffb8e73b
make executable name in command output stable
...
by setting os.Args[0] to "ipfs"
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
8061117e0c
core/commands: add TestROCommands
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
aec44bc430
use *oldcmds.Context consistently instead of non-ptr
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
091eeee243
update go-ipfs-cmds
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
1cc7e2a28e
update go-ipfs-cmds
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
8f24d8e211
cleanup
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
7b1963906b
update go-ipfs-cmds yet again
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
b23c3295e6
update go-ipfs-cmds
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
94266bf2e4
update go-ipfs-cmds
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
27b43612b6
fix refs handling on gateway
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
4b9c36b072
sharness: increase timeout waiting for api file
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
52bc298230
fix ServerNameOption
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
8294f0a345
remove test for deleted fuction
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
fbc36b8962
update dependencies and update TODO
...
broken sharness test t0110 has been fixed in master
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
af438035db
update TODO (client version check)
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
012e3381f1
fix content type detection to allow adding via curl
...
fixed in cmdkit1.0
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
7d57def06e
remove dead code, update TODO
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
94be1f219e
update TODO
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
740cf4a3b4
cmd/ipfs: check whether repo is accessible before attempting to load plugins
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
23a27b9c67
fix test that didn't respect cmds.Single
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
e8ad094448
add TODO
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
feef5c3415
cmds: use Executors
...
- some fixes for cmds1.0
- reinsert plugin loading code, pretty print wrapper
TODO:
if plugin loading fails it only calls log.Warning.
returning an error would be better but that would have
to happen after PreRun, which is not possible atm.
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
84101c8a2a
go test passes, sharness fails
...
pass API path to cmds, fix options in add.
License: MIT
Signed-off-by: keks <keks@cryptoscope.com>
2018-01-21 11:11:47 -08:00
9965861b86
fmt
...
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
c1d6230bc0
check api version in corehttp
...
- add comments, trim api path prefix
- corehttp: add option to set HTTP header "Server"
- daemon: use new corehttp options
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
bd9576fa57
start adopting cmds3.0 - lots of errors!
...
- move go-ipfs-cmds/legacy to go-ipfs/commands/legacy
- update cmds,cmdkit; go test ./... ok
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
2140aa9578
Merge pull request #4587 from lgarron/is-adds
...
Fix typo in error.go: "is adds" -> "adds".
2018-01-17 19:28:24 -08:00
dd4e25c11b
Fix typo in an error.go comment: "is adds" -> "adds".
...
License: MIT
Signed-off-by: Lucas Garron <code@garron.net>
2018-01-17 15:25:54 -08:00