opensource/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2025-06-28 17:03:58 +08:00
Code Issues Projects Releases Wiki Activity

Moved Tests up in Contribute.md

Browse Source 
This should be more prominent. We also need a much better description of how to run tests - rigt now, we are dependant on Travis for the majority of testing, I believe. If there was a clear guide here on how to run the appropriate tests for each kind of PR, that would be fantastic.

We also really ought to have a section asking people to add all of the tests that they can think of.

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
This commit is contained in:
Richard Littauer
2016-05-10 16:44:48 -04:00
parent 665cd85699
commit f33a3a0904
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
contribute.md
View File

@ -19,6 +19,10 @@ Please look and conform to our [Go Contribution Guidelines](https://github.com/i
## Repository specific guidelines: ## Repository specific guidelines:
### Each Commit Must Pass Tests
All commits in a PR must pass tests. If they don't, fix the commits and/or [squash them](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) so that they do pass the tests. This should be done so that we can use git-bisect easily.
### Commit messages ### Commit messages
Commit messages must start with a short subject line, followed by an optional, Commit messages must start with a short subject line, followed by an optional,
@ -90,8 +94,3 @@ reasons why this is _the right thing to do_:
License: MIT License: MIT
Signed-off-by: Juan Benet <juan@ipfs.io> Signed-off-by: Juan Benet <juan@ipfs.io>
``` ```
### Each Commit Must Pass Tests
All commits in a PR must pass tests. If they don't, fix the commits and/or [squash them](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) so that they do pass the tests. This should be done so that we can use git-bisect easily.