From f33a3a0904f371890da8c677bb4cc7fbc2ef1a04 Mon Sep 17 00:00:00 2001 From: Richard Littauer Date: Tue, 10 May 2016 16:44:48 -0400 Subject: [PATCH] Moved Tests up in Contribute.md This should be more prominent. We also need a much better description of how to run tests - rigt now, we are dependant on Travis for the majority of testing, I believe. If there was a clear guide here on how to run the appropriate tests for each kind of PR, that would be fantastic. We also really ought to have a section asking people to add all of the tests that they can think of. License: MIT Signed-off-by: Richard Littauer --- contribute.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/contribute.md b/contribute.md index 7c3e066cd..87190c118 100644 --- a/contribute.md +++ b/contribute.md @@ -19,6 +19,10 @@ Please look and conform to our [Go Contribution Guidelines](https://github.com/i ## Repository specific guidelines: +### Each Commit Must Pass Tests + +All commits in a PR must pass tests. If they don't, fix the commits and/or [squash them](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) so that they do pass the tests. This should be done so that we can use git-bisect easily. + ### Commit messages Commit messages must start with a short subject line, followed by an optional, @@ -90,8 +94,3 @@ reasons why this is _the right thing to do_: License: MIT Signed-off-by: Juan Benet ``` - -### Each Commit Must Pass Tests - -All commits in a PR must pass tests. If they don't, fix the commits and/or [squash them](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) so that they do pass the tests. This should be done so that we can use git-bisect easily. -