opensource/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2025-07-01 02:30:39 +08:00
Code Issues Projects Releases Wiki Activity

refac(bitswap) nil slices are 'range'able

Browse Source
This commit is contained in:
Brian Tiger Chow
2014-09-19 15:44:11 -07:00
parent 331fcd1756
commit 5aa6ccbad5
1 changed files with 18 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
exchange/bitswap/bitswap.go
View File

@ -117,32 +117,28 @@ func (bs *bitswap) ReceiveMessage(
bs.strategy.MessageReceived(p, incoming)
if incoming.Blocks() != nil {
for _, block := range incoming.Blocks() {
err := bs.blockstore.Put(block) // FIXME(brian): err ignored
if err != nil {
return nil, nil, err
}
bs.notifications.Publish(block)
err = bs.HasBlock(ctx, block) // FIXME err ignored
if err != nil {
return nil, nil, err
}
for _, block := range incoming.Blocks() {
err := bs.blockstore.Put(block) // FIXME(brian): err ignored
if err != nil {
return nil, nil, err
}
bs.notifications.Publish(block)
err = bs.HasBlock(ctx, block) // FIXME err ignored
if err != nil {
return nil, nil, err
}
}
if incoming.Wantlist() != nil {
for _, key := range incoming.Wantlist() {
if bs.strategy.ShouldSendBlockToPeer(key, p) {
block, errBlockNotFound := bs.blockstore.Get(key)
if errBlockNotFound != nil {
return nil, nil, errBlockNotFound
}
message := bsmsg.New()
message.AppendBlock(*block)
defer bs.strategy.MessageSent(p, message)
return p, message, nil
for _, key := range incoming.Wantlist() {
if bs.strategy.ShouldSendBlockToPeer(key, p) {
block, errBlockNotFound := bs.blockstore.Get(key)
if errBlockNotFound != nil {
return nil, nil, errBlockNotFound
}
message := bsmsg.New()
message.AppendBlock(*block)
defer bs.strategy.MessageSent(p, message)
return p, message, nil
}
}
return nil, nil, nil