opensource/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2025-06-30 01:52:26 +08:00
Code Issues Projects Releases Wiki Activity

Golint: merkledag: let NewDagService return *dagService

Browse Source 
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
This commit is contained in:
Hector Sanjuan
2018-02-07 00:35:35 +01:00
parent 2d138b056e
commit 2743dd246f
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
merkledag/merkledag.go
View File

@ -30,7 +30,7 @@ const progressContextKey contextKey = "progress"
// NewDAGService constructs a new DAGService (using the default implementation).
// Note that the default implementation is also an ipld.LinkGetter.
func NewDAGService(bs bserv.BlockService) ipld.DAGService {
func NewDAGService(bs bserv.BlockService) *dagService {
return &dagService{Blocks: bs}
}

8
merkledag/merkledag_test.go
View File

@ -242,8 +242,7 @@ func TestFetchGraph(t *testing.T) {
// create an offline dagstore and ensure all blocks were fetched
bs := bserv.New(bsis[1].Blockstore(), offline.Exchange(bsis[1].Blockstore()))
// we know the default dagService implements LinkGetter
offlineDS := NewDAGService(bs).(ipld.LinkGetter)
offlineDS := NewDAGService(bs)
err = EnumerateChildren(context.Background(), offlineDS.GetLinks, root.Cid(), func(_ *cid.Cid) bool { return true })
if err != nil {
@ -262,9 +261,8 @@ func TestEnumerateChildren(t *testing.T) {
}
set := cid.NewSet()
lg := ds.(ipld.LinkGetter)
err = EnumerateChildren(context.Background(), lg.GetLinks, root.Cid(), set.Visit)
err = EnumerateChildren(context.Background(), ds.GetLinks, root.Cid(), set.Visit)
if err != nil {
t.Fatal(err)
}
@ -495,7 +493,7 @@ func TestCidRetention(t *testing.T) {
}
func TestCidRawDoesnNeedData(t *testing.T) {
srv := NewDAGService(dstest.Bserv()).(ipld.LinkGetter)
srv := NewDAGService(dstest.Bserv())
nd := NewRawNode([]byte("somedata"))
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)