1
0
mirror of https://github.com/ipfs/kubo.git synced 2025-06-24 22:38:27 +08:00

fix(2/log) use 'all' as the specifier to set all log levels

fixes #322

cc @mappum

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
This commit is contained in:
Brian Tiger Chow
2014-11-12 23:27:18 -08:00
committed by Juan Batiz-Benet
parent fb187e49e3
commit 131c15e924

View File

@ -7,6 +7,12 @@ import (
u "github.com/jbenet/go-ipfs/util"
)
// Golang os.Args overrides * and replaces the character argument with
// an array which includes every file in the user's CWD. As a
// workaround, we use 'all' instead. The util library still uses * so
// we convert it at this step.
var logAllKeyword = "all"
var logCmd = &cmds.Command{
Helptext: cmds.HelpText{
Tagline: "Change the logging level",
@ -17,16 +23,29 @@ output of a running daemon.
},
Arguments: []cmds.Argument{
cmds.StringArg("subsystem", true, false, "the subsystem logging identifier. Use * for all subsystems."),
// TODO use a different keyword for 'all' because all can theoretically
// clash with a subsystem name
cmds.StringArg("subsystem", true, false, fmt.Sprintf("the subsystem logging identifier. Use '%s' for all subsystems.", logAllKeyword)),
cmds.StringArg("level", true, false, "one of: debug, info, notice, warning, error, critical"),
},
Run: func(req cmds.Request) (interface{}, error) {
args := req.Arguments()
if err := u.SetLogLevel(args[0].(string), args[1].(string)); err != nil {
subsystem, ok1 := args[0].(string)
level, ok2 := args[1].(string)
if !ok1 || !ok2 {
return nil, u.ErrCast()
}
if subsystem == logAllKeyword {
subsystem = "*"
}
if err := u.SetLogLevel(subsystem, level); err != nil {
return nil, err
}
s := fmt.Sprintf("Changed log level of '%s' to '%s'", args[0], args[1])
s := fmt.Sprintf("Changed log level of '%s' to '%s'", subsystem, level)
log.Info(s)
return &MessageOutput{s}, nil
},