Rename sortDir to order

This commit is contained in:
Typicode
2014-10-18 18:49:52 +02:00
parent cc248a5f47
commit b86bb22c07
2 changed files with 7 additions and 7 deletions

View File

@ -39,12 +39,12 @@ module.exports = function(object, filename) {
var _start = req.query._start var _start = req.query._start
var _end = req.query._end var _end = req.query._end
var _sort = req.query._sort var _sort = req.query._sort
var _sortDir = req.query._sortDir var _order = req.query._order
delete req.query._start delete req.query._start
delete req.query._end delete req.query._end
delete req.query._sort delete req.query._sort
delete req.query._sortDir delete req.query._order
if (req.query.q) { if (req.query.q) {
@ -84,13 +84,13 @@ module.exports = function(object, filename) {
} }
if(_sort) { if(_sort) {
_sortDir = _sortDir || 'ASC' _order = _order || 'ASC'
array = _.sortBy(array, function(element) { array = _.sortBy(array, function(element) {
return element[_sort]; return element[_sort];
}) })
if (_sortDir === 'DESC') { if (_order === 'DESC') {
array.reverse(); array.reverse();
} }
} }

View File

@ -104,9 +104,9 @@ describe('Server', function() {
.expect(200, done) .expect(200, done)
}) })
it('should reverse sorting with sortDir=DESC', function(done) { it('should reverse sorting with order=DESC', function(done) {
request(server) request(server)
.get('/tags?_sort=body&_sortDir=DESC') .get('/tags?_sort=body&_order=DESC')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect([db.tags[2], db.tags[0], db.tags[1]]) .expect([db.tags[2], db.tags[0], db.tags[1]])
.expect(200, done) .expect(200, done)
@ -114,7 +114,7 @@ describe('Server', function() {
it('should sort on numerical field', function(done) { it('should sort on numerical field', function(done) {
request(server) request(server)
.get('/posts?_sort=id&_sortDir=DESC') .get('/posts?_sort=id&_order=DESC')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(db.posts.reverse()) .expect(db.posts.reverse())
.expect(200, done) .expect(200, done)