From b86bb22c07bd4802813cf75bdb58d15ba7f012f3 Mon Sep 17 00:00:00 2001 From: Typicode Date: Sat, 18 Oct 2014 18:49:52 +0200 Subject: [PATCH] Rename sortDir to order --- src/create-routes.js | 8 ++++---- test/index.js | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/create-routes.js b/src/create-routes.js index 82b0f40..c07e915 100644 --- a/src/create-routes.js +++ b/src/create-routes.js @@ -39,12 +39,12 @@ module.exports = function(object, filename) { var _start = req.query._start var _end = req.query._end var _sort = req.query._sort - var _sortDir = req.query._sortDir + var _order = req.query._order delete req.query._start delete req.query._end delete req.query._sort - delete req.query._sortDir + delete req.query._order if (req.query.q) { @@ -84,13 +84,13 @@ module.exports = function(object, filename) { } if(_sort) { - _sortDir = _sortDir || 'ASC' + _order = _order || 'ASC' array = _.sortBy(array, function(element) { return element[_sort]; }) - if (_sortDir === 'DESC') { + if (_order === 'DESC') { array.reverse(); } } diff --git a/test/index.js b/test/index.js index a993a89..7b18c45 100644 --- a/test/index.js +++ b/test/index.js @@ -104,9 +104,9 @@ describe('Server', function() { .expect(200, done) }) - it('should reverse sorting with sortDir=DESC', function(done) { + it('should reverse sorting with order=DESC', function(done) { request(server) - .get('/tags?_sort=body&_sortDir=DESC') + .get('/tags?_sort=body&_order=DESC') .expect('Content-Type', /json/) .expect([db.tags[2], db.tags[0], db.tags[1]]) .expect(200, done) @@ -114,7 +114,7 @@ describe('Server', function() { it('should sort on numerical field', function(done) { request(server) - .get('/posts?_sort=id&_sortDir=DESC') + .get('/posts?_sort=id&_order=DESC') .expect('Content-Type', /json/) .expect(db.posts.reverse()) .expect(200, done)