opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test & testutils: prevent goroutine leaks in test functions (#3133)

Browse Source
This commit is contained in:
lzhfromustc
2019-11-01 17:51:58 -04:00
committed by Doug Fawley
parent 0f32486dd3
commit da2bec01b9
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/testutils/pipe_listener_test.go
View File

@ -27,7 +27,7 @@ import (
func TestPipeListener(t *testing.T) { func TestPipeListener(t *testing.T) {
pl := testutils.NewPipeListener() pl := testutils.NewPipeListener()
recvdBytes := make(chan []byte) recvdBytes := make(chan []byte, 1)
const want = "hello world" const want = "hello world"
go func() { go func() {

4
test/bufconn/bufconn_test.go
View File

@ -96,7 +96,7 @@ func TestConn(t *testing.T) {
func TestConnCloseWithData(t *testing.T) { func TestConnCloseWithData(t *testing.T) {
lis := Listen(7) lis := Listen(7)
errChan := make(chan error) errChan := make(chan error, 1)
var lisConn net.Conn var lisConn net.Conn
go func() { go func() {
var err error var err error
@ -199,7 +199,7 @@ func TestCloseWhileAccepting(t *testing.T) {
} }
func TestDeadline(t *testing.T) { func TestDeadline(t *testing.T) {
sig := make(chan error) sig := make(chan error, 2)
blockingWrite := func(conn net.Conn) { blockingWrite := func(conn net.Conn) {
_, err := conn.Write([]byte("0123456789")) _, err := conn.Write([]byte("0123456789"))
sig <- err sig <- err

2
test/end2end_test.go
View File

@ -4694,7 +4694,7 @@ func testClientResourceExhaustedCancelFullDuplex(t *testing.T, e env) {
resp := &testpb.StreamingOutputCallResponse{ resp := &testpb.StreamingOutputCallResponse{
Payload: payload, Payload: payload,
} }
ce := make(chan error) ce := make(chan error, 1)
go func() { go func() {
var err error var err error
for { for {