From da2bec01b99dc0ba64a2f7cee08d1d71e79132c4 Mon Sep 17 00:00:00 2001 From: lzhfromustc <43191155+lzhfromustc@users.noreply.github.com> Date: Fri, 1 Nov 2019 17:51:58 -0400 Subject: [PATCH] test & testutils: prevent goroutine leaks in test functions (#3133) --- internal/testutils/pipe_listener_test.go | 2 +- test/bufconn/bufconn_test.go | 4 ++-- test/end2end_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/testutils/pipe_listener_test.go b/internal/testutils/pipe_listener_test.go index 9bd399cb..07cb486e 100644 --- a/internal/testutils/pipe_listener_test.go +++ b/internal/testutils/pipe_listener_test.go @@ -27,7 +27,7 @@ import ( func TestPipeListener(t *testing.T) { pl := testutils.NewPipeListener() - recvdBytes := make(chan []byte) + recvdBytes := make(chan []byte, 1) const want = "hello world" go func() { diff --git a/test/bufconn/bufconn_test.go b/test/bufconn/bufconn_test.go index 6a20b036..ea1e8c99 100644 --- a/test/bufconn/bufconn_test.go +++ b/test/bufconn/bufconn_test.go @@ -96,7 +96,7 @@ func TestConn(t *testing.T) { func TestConnCloseWithData(t *testing.T) { lis := Listen(7) - errChan := make(chan error) + errChan := make(chan error, 1) var lisConn net.Conn go func() { var err error @@ -199,7 +199,7 @@ func TestCloseWhileAccepting(t *testing.T) { } func TestDeadline(t *testing.T) { - sig := make(chan error) + sig := make(chan error, 2) blockingWrite := func(conn net.Conn) { _, err := conn.Write([]byte("0123456789")) sig <- err diff --git a/test/end2end_test.go b/test/end2end_test.go index cbd42120..9f42bd2c 100644 --- a/test/end2end_test.go +++ b/test/end2end_test.go @@ -4694,7 +4694,7 @@ func testClientResourceExhaustedCancelFullDuplex(t *testing.T, e env) { resp := &testpb.StreamingOutputCallResponse{ Payload: payload, } - ce := make(chan error) + ce := make(chan error, 1) go func() { var err error for {