opensource/grpc-go
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Behaviour Change: transport errors should be coded Unavailable instead of internal. (#1307)

Browse Source
This commit is contained in:
MakMukhi
2017-06-14 14:21:20 -07:00
committed by GitHub
parent 1ab4adf22d
commit a3592bda22
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
go16.go
View File

@ -56,7 +56,7 @@ func toRPCErr(err error) error {
case transport.StreamError:
return status.Error(e.Code, e.Desc)
case transport.ConnectionError:
return status.Error(codes.Internal, e.Desc)
return status.Error(codes.Unavailable, e.Desc)
default:
switch err {
case context.DeadlineExceeded:

2
go17.go
View File

@ -56,7 +56,7 @@ func toRPCErr(err error) error {
case transport.StreamError:
return status.Error(e.Code, e.Desc)
case transport.ConnectionError:
return status.Error(codes.Internal, e.Desc)
return status.Error(codes.Unavailable, e.Desc)
default:
switch err {
case context.DeadlineExceeded, netctx.DeadlineExceeded:

2
rpc_util_test.go
View File

@ -148,7 +148,7 @@ func TestToRPCErr(t *testing.T) {
errOut error
}{
{transport.StreamError{Code: codes.Unknown, Desc: ""}, status.Error(codes.Unknown, "")},
{transport.ErrConnClosing, status.Error(codes.Internal, transport.ErrConnClosing.Desc)},
{transport.ErrConnClosing, status.Error(codes.Unavailable, transport.ErrConnClosing.Desc)},
} {
err := toRPCErr(test.errIn)
if _, ok := status.FromError(err); !ok {