opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-29 20:42:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

Alerting: Fix active time intervals when time interval is renamed (#108534)

Browse Source
This commit is contained in:
Yuri Tseretyan
2025-07-23 13:08:11 -04:00
committed by GitHub
parent d3a445409b
commit cc869e7668
3 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/services/ngalert/provisioning/mute_timings.go
View File

@ -440,6 +440,12 @@ func replaceMuteTiming(route *definitions.Route, oldName, newName string) int {
updated++
}
}
for idx := range route.ActiveTimeIntervals {
if route.ActiveTimeIntervals[idx] == oldName {
route.ActiveTimeIntervals[idx] = newName
updated++
}
}
for _, route := range route.Routes {
updated += replaceMuteTiming(route, oldName, newName)
}

3
pkg/tests/apis/alerting/notifications/timeinterval/test-data/notification-settings.json
View File

@ -15,6 +15,9 @@
],
"mute_time_intervals": [
"test-interval", "persisted-interval"
],
"active_time_intervals": [
"test-interval", "persisted-interval"
]
}
]

4
pkg/tests/apis/alerting/notifications/timeinterval/timeinterval_test.go
View File

@ -725,7 +725,9 @@ func TestIntegrationTimeIntervalReferentialIntegrity(t *testing.T) {
updatedRoute := legacyCli.GetRoute(t)
for idx, route := range updatedRoute.Routes {
expectedTimeIntervals := replace(currentRoute.Routes[idx].MuteTimeIntervals, interval.Spec.Name, actual.Spec.Name)
assert.Equalf(t, expectedTimeIntervals, route.MuteTimeIntervals, "time interval in routes should have been renamed but it did not")
assert.Equalf(t, expectedTimeIntervals, route.MuteTimeIntervals, "mute time interval in routes should have been renamed but it did not")
expectedTimeIntervals = replace(currentRoute.Routes[idx].ActiveTimeIntervals, interval.Spec.Name, actual.Spec.Name)
assert.Equalf(t, expectedTimeIntervals, route.ActiveTimeIntervals, "active time interval in routes should have been renamed but it did not")
}
interval = *actual