opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-09-21 07:04:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Unified Alerting: Make log message follow codebase convention. (#46881)

Browse Source 
1. Keep log lines lower case.
2. The key-value pair arguments are not format argument for the string.
3. Always use the "err" key.
This commit is contained in:
Joe Blubaugh
2022-03-23 15:07:07 +01:00
committed by GitHub
parent 77976ea810
commit 481a68cbf5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/services/ngalert/notifier/alertmanager.go
View File

@ -190,7 +190,7 @@ func newAlertmanager(ctx context.Context, orgID int64, cfg *setting.Cfg, store s
am.silences.Maintenance(silenceMaintenanceInterval, silencesFilePath, am.stopc, func() (int64, error) { am.silences.Maintenance(silenceMaintenanceInterval, silencesFilePath, am.stopc, func() (int64, error) {
// Delete silences older than the retention period. // Delete silences older than the retention period.
if _, err := am.silences.GC(); err != nil { if _, err := am.silences.GC(); err != nil {
am.logger.Error("Silence Garbage Collection Failed at %v: %v", time.Now(), err) am.logger.Error("silence garbage collection", "err", err)
// Don't return here - we need to snapshot our state first. // Don't return here - we need to snapshot our state first.
} }