From 481a68cbf5dee4ffae42b55a376e7f793539daa0 Mon Sep 17 00:00:00 2001 From: Joe Blubaugh Date: Wed, 23 Mar 2022 15:07:07 +0100 Subject: [PATCH] Unified Alerting: Make log message follow codebase convention. (#46881) 1. Keep log lines lower case. 2. The key-value pair arguments are not format argument for the string. 3. Always use the "err" key. --- pkg/services/ngalert/notifier/alertmanager.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/services/ngalert/notifier/alertmanager.go b/pkg/services/ngalert/notifier/alertmanager.go index f6aefceae38..a42d72527a9 100644 --- a/pkg/services/ngalert/notifier/alertmanager.go +++ b/pkg/services/ngalert/notifier/alertmanager.go @@ -190,7 +190,7 @@ func newAlertmanager(ctx context.Context, orgID int64, cfg *setting.Cfg, store s am.silences.Maintenance(silenceMaintenanceInterval, silencesFilePath, am.stopc, func() (int64, error) { // Delete silences older than the retention period. if _, err := am.silences.GC(); err != nil { - am.logger.Error("Silence Garbage Collection Failed at %v: %v", time.Now(), err) + am.logger.Error("silence garbage collection", "err", err) // Don't return here - we need to snapshot our state first. }