opensource/HeidiSQL
1
0
Fork 0
mirror of https://github.com/HeidiSQL/HeidiSQL.git synced 2026-03-13 09:24:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix: when 'view as html' was clicked and non-image binary data was encountered, an unchartered code path would be taken and a preview without a usable file extension would be generated. Now, unrecognizable binary content is stuffed in a text file.

Browse Source 
Fixes issue #938.

Also, the GUI action should probably be called "image view" rather than "HTML view"?
This commit is contained in:
rosenfield.albert
2009-02-12 15:40:25 +00:00
parent a59dc8f1c8
commit 6c4be0349c
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
source/main.pas
View File

@@ -2247,6 +2247,7 @@ var
f : Textfile;
Content : WideString;
IsBinary : Boolean;
SaveBinary : Boolean;
begin
g := ActiveGrid;
if g = nil then begin messagebeep(MB_ICONASTERISK); exit; end;
@@ -2257,20 +2258,26 @@ begin
IsBinary := ActiveData.Columns[g.FocusedColumn].IsBinary;
Content := g.Text[g.FocusedNode, g.FocusedColumn];
SaveBinary := false;
filename := GetTempDir+'\'+APPNAME+'-preview.';
if IsBinary then begin
if pos('JFIF', copy(Content, 0, 20)) <> 0 then
filename := filename + 'jpeg'
else if StrCmpBegin('GIF', Content) then
filename := filename + 'gif'
else if StrCmpBegin('BM', Content) then
filename := filename + 'bmp';
if IsBinary and (pos('JFIF', copy(Content, 0, 20)) <> 0) then begin
SaveBinary := true;
filename := filename + 'jpeg';
end else if IsBinary and StrCmpBegin('GIF', Content) then begin
SaveBinary := true;
filename := filename + 'gif';
end else if IsBinary and StrCmpBegin('BM', Content) then begin
SaveBinary := true;
filename := filename + 'bmp';
end else if Isbinary then filename := filename + 'txt'
else filename := filename + 'html';
if SaveBinary then begin
AssignFile(f, filename);
Rewrite(f);
Write(f, Content);
CloseFile(f);
end else begin
filename := filename + 'html';
SaveUnicodeFile(filename, Content);
end;
ShowStatus( STATUS_MSG_READY );