opensource/HeidiSQL
1
0
Fork 0
mirror of https://github.com/HeidiSQL/HeidiSQL.git synced 2026-03-13 09:24:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Issue #1028: Optimize unused code in TDBConnection.GetDbObjects away, which looked for cached object lists which specific OnlyNodeType property, which we don't cache anyway

Browse Source
This commit is contained in:
Ansgar Becker
2020-05-14 20:51:00 +02:00
parent b45070e8c8
commit 6026d364ec
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
source/dbconnection.pas
View File

@@ -172,14 +172,12 @@ type
FLargestObjectSize: Int64;
FLastUpdate: TDateTime;
FCollation: String;
FOnlyNodeType: TListNodeType;
public
property Database: String read FDatabase;
property DataSize: Int64 read FDataSize;
property LargestObjectSize: Int64 read FLargestObjectSize;
property LastUpdate: TDateTime read FLastUpdate;
property Collation: String read FCollation;
property OnlyNodeType: TListNodeType read FOnlyNodeType;
end;
TDatabaseCache = class(TObjectList<TDBObjectList>); // A list of db object lists, used for caching
TDBObjectComparer = class(TComparer<TDBObject>)
@@ -5752,7 +5750,7 @@ begin
// Find list in cache
Cache := nil;
for i:=0 to FDatabaseCache.Count-1 do begin
if (FDatabaseCache[i].Database = db) and (FDatabaseCache[i].OnlyNodeType=lntNone) then begin
if FDatabaseCache[i].Database = db then begin
Cache := FDatabaseCache[i];
break;
end;
@@ -5762,7 +5760,6 @@ begin
if not Assigned(Cache) then begin
Cache := TDBObjectList.Create(TDBObjectComparer.Create);
Cache.OwnsObjects := True;
Cache.FOnlyNodeType := lntNone;
Cache.FLastUpdate := 0;
Cache.FDataSize := 0;
Cache.FDatabase := db;
@@ -5778,17 +5775,11 @@ begin
FOnObjectnamesChanged(Self, FDatabase);
end;
Result := nil;
for i:=0 to FDatabaseCache.Count-1 do begin
if (FDatabaseCache[i].Database = db) and (FDatabaseCache[i].OnlyNodeType=OnlyNodeType) then begin
Result := FDatabaseCache[i];
break;
end;
end;
if not Assigned(Result) then begin
if OnlyNodeType = lntNone then begin
Result := Cache;
end else begin
Result := TDBObjectList.Create(TDBObjectComparer.Create);
Result.OwnsObjects := False;
Result.FOnlyNodeType := OnlyNodeType;
Result.FLastUpdate := Cache.FLastUpdate;
Result.FDataSize := Cache.FDataSize;
Result.FDatabase := Cache.FDatabase;