f263611260
Issue number: resolves #27688 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Autogrow broke as a result of8bcd9e8b35. `white-space: pre-wrap` used to be on the host, but it was discovered that this caused textareas that had any white space to break visually. As a result, I moved `white-space: pre-wrap` to apply on the host only for the legacy textarea. The modern textarea had `white-space: pre-wrap` set on the native textarea. We also had `white-space: pre-wrap` set on the `::after` pseudo element for autogrow:f29c66aee2/core/src/components/textarea/textarea.scss (L311)However, we also use the `text-inherit` mixin:f29c66aee2/core/src/components/textarea/textarea.scss (L322)This mixin sets `white-space: inherit` and also overrides the `pre-wrap` we had set. As a result, the whitespace was being inherited from the default white space instead of `pre-wrap`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Textarea no longer overrides the explicit `white-space: pre-wrap` on the `::after` element. - Re-enabled a skipped autogrow test that would have caught this bug - Fixed a whitespace issue in another autogrow test Note: The legacy screenshot diffs in6ba2093166are unrelated to this PR. Now that we are unskipping them the screenshots have been updated. I verified this in https://github.com/ionic-team/ionic-framework/pull/27692. This PR shows a branch created off `7.0.x` (which does not have the reported regression) and the tests enabled w/ the screenshots updated. The linked verification PR can be closed when this PR merges. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: 7.1.1-dev.11687532007.11a1a9a4 --------- Co-authored-by: ionitron <hi@ionicframework.com>
Ionic
Ionic is an open source app development toolkit for building modern, fast, top-quality cross-platform native and Progressive Web Apps from a single codebase with JavaScript and the Web.
Ionic is based on Web Components, which enables significant performance, usability, and feature improvements alongside support for popular web frameworks like Angular, React, and Vue.
Quickstart
·
Documentation
·
Contribute
·
Blog
Community:
Discord
·
Forums
·
Twitter
Packages
| Project | Package | Version | Downloads | Links |
|---|---|---|---|---|
| Core | @ionic/core |
 |
 |
README.md |
| Angular | @ionic/angular |
 |
 |
README.md |
| Vue | @ionic/vue |
 |
 |
README.md |
| React | @ionic/react |
 |
 |
README.md |
Looking for the ionic-angular package? Ionic 3 has been moved to the ionic-v3 repo. See Earlier Versions.
Getting Started
Start a new project by following our quick Getting Started guide. We would love to hear from you! If you have any feedback or run into issues using our framework, please file an issue on this repository.
Migration Guides
Already have an Ionic app? These guides will help you migrate to the latest versions.
Examples
The Ionic Conference App is a full featured Ionic app. It is the perfect starting point for learning and building your own app.
Contributing
Thanks for your interest in contributing! Read up on our guidelines for contributing and then look through our issues with a help wanted label.
Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.
Future Goals
As Ionic Framework components migrate to the web component standard, a goal of ours is to have Ionic Framework easily work within all of the popular frameworks.
Earlier Versions
The source code for earlier versions of the Ionic Framework may exist in other repositories. Please open issues and pull requests in their respective repositories.
- Ionic 2/3: Moved to
ionic-team/ionic-v3 - Ionic 1: Moved to
ionic-team/ionic-v1