mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00

Go to file

Maria Hutt cad1c61528 fix(select): update icon color and use correct focused class (#30342 )

Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

There are a few items to note:
- Styles are using a non-existing focus class. It currently uses
`.has-focus` which isn't being used anywhere within `select.tsx`. It
seems that `.has-focus` comes a copy and paste that wasn't updated.
- Icon uses the highlight color when expanded, in item, and no fill.
This leads to the styling looking weird compared to when it's not in an
item especially since labels do not change colors. Only applies to `md`
mode.

| List no lines | List with lines |
| --- | ----------- |
| ![Screenshot 2025-04-07 at 1 01
14 PM](https://github.com/user-attachments/assets/e310e5e8-d0bc-4976-b623-c8db358307c8)
| ![Screenshot 2025-04-07 at 1 01
31 PM](https://github.com/user-attachments/assets/d4c0776d-cd5d-48a1-95a3-42b74e3dd767)
|

- The focus without a validation status does not update the border
correctly when inside an item and has a solid fill. Only applies to `md`
mode.

| Outside item | Inside item |
|--------|--------|
| ![Screenshot 2025-04-07 at 1 07
13 PM](https://github.com/user-attachments/assets/ee8c4fff-630d-4f7c-b3c5-f9daf22ff7d4)
| ![Screenshot 2025-04-07 at 1 08
45 PM](https://github.com/user-attachments/assets/046d69fc-823e-4fa4-a19f-f8e641874b4d)
|

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Styles are now using the correct focus class: `.has-focus`, removing
`ion-focused`.
- If the select is inside an item and has no fill then the icon will not
use the highlight color. Only applies to `md` mode.


| List no lines | List with lines |
| --- | ----------- |
| ![Screenshot 2025-04-07 at 1 13
17 PM](https://github.com/user-attachments/assets/0e6fd28e-4925-4799-a24b-8e21348eb168)
| ![Screenshot 2025-04-07 at 1 14
11 PM](https://github.com/user-attachments/assets/adec2576-27d9-4150-8e60-8af5fa9cc012)
|

- The focus without a validation status uses the highlight color when
inside an item and has a solid fill. Only applies to `md` mode.

| Outside item | Inside item |
|--------|--------|
| ![Screenshot 2025-04-07 at 1 07
13 PM](https://github.com/user-attachments/assets/ee8c4fff-630d-4f7c-b3c5-f9daf22ff7d4)
| ![Screenshot 2025-04-07 at 1 16
47 PM](https://github.com/user-attachments/assets/bc8b03b9-6ad1-40b0-a7fd-3f6e654ec066)
|

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev build: `8.5.4-dev.11744743162.1ec9251d`

Select cannot have a focused class and an expanded class at the same
time. It's one or the other.

---------

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>

2025-04-16 17:16:54 +00:00

.github

chore(deps): update dependency node to v22 (#30326 )

2025-04-11 20:06:10 +00:00

.scripts

chore(release): remove old release scripts and deps (#24599 )

2022-01-19 13:41:22 -05:00

.stackblitz

chore: disable codeflow for pull requests (#28101 )

2023-09-06 01:57:20 +00:00

BREAKING_ARCHIVE

chore(): update BREAKING.md to prepare for Ionic 8 development (#28360 )

2023-10-17 09:07:36 -05:00

CHANGELOG_ARCHIVE

chore(changelog): move old changelogs to archive (#26759 )

2023-02-08 12:38:22 -05:00

core

fix(select): update icon color and use correct focused class (#30342 )

2025-04-16 17:16:54 +00:00

docs

test(angular): add ng19 test app (#30041 )

2024-12-04 17:02:06 +00:00

packages

chore(): update package lock files

2025-04-09 13:28:43 -04:00

.editorconfig

style(): add editorconfig

2015-11-13 21:11:21 -06:00

.gitattributes

chore(repo): move .gitattributes to the root of the project (#29591 )

2024-06-05 20:30:47 +00:00

.gitignore

test(ci): run tests in docker container (#28893 )

2024-03-18 14:08:30 +00:00

.vercelignore

chore(ci): ignore images when uploading to vercel (#29310 )

2024-04-10 21:04:57 +00:00

BREAKING.md

refactor(searchbar): autocapitalize defaults to off (#29107 )

2024-03-22 09:13:15 -04:00

CHANGELOG.md

v8.5.4

2025-04-09 17:22:30 +00:00

CODE_OF_CONDUCT.md

chore(): update code of conduct (#22619 )

2021-02-11 09:35:02 -05:00

lerna.json

v8.5.4

2025-04-09 17:22:30 +00:00

LICENSE

chore(): github now detects license file (#25549 )

2022-06-28 10:31:33 -04:00

package-lock.json

v8.4.4

2025-03-13 21:04:03 +00:00

package.json

chore(test-apps): set minimum node version to 16 (#26960 )

2023-03-15 11:04:55 -04:00

README.md

docs(readme): update broken links, repository name, clean up readme (#29508 )

2024-05-15 21:26:27 +00:00

renovate.json5

fix(react): revert react output target version (#29869 )

2024-09-16 14:44:03 +00:00

tsconfig.json

feat(react): fixing support for react 19, adding test app for react 19 (#30217 )

2025-03-03 08:50:05 -08:00

README.md

Ionic

Ionic is an open source app development toolkit for building modern, fast, top-quality cross-platform native and Progressive Web Apps from a single codebase with JavaScript and the Web.

Ionic is based on Web Components, which enables significant performance, usability, and feature improvements alongside support for popular web frameworks like Angular, React, and Vue.

Quickstart · Documentation · Contribute · Blog
Community: Discord · Forums · Twitter

Packages

Project	Package	Links
Core	`@ionic/core`	`README.md`
Angular	`@ionic/angular`	`README.md`
Vue	`@ionic/vue`	`README.md`
React	`@ionic/react`	`README.md`

Looking for the ionic-angular package? Ionic 3 has been moved to the ionic-v3 repo. See Earlier Versions.

Getting Started

Start a new project by following our documentation. We would love to hear from you! If you have any feedback or run into issues using our framework, please file an issue on this repository.

Migration Guides

Already have an Ionic app? These guides will help you migrate to the latest versions.

Examples

The Ionic Conference App is a full featured Ionic app. It is the perfect starting point for learning and building your own app.

Contributing

Thanks for your interest in contributing! Read up on our guidelines for contributing and then look through our issues with a help wanted label.

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

Earlier Versions

The source code for earlier versions of the Ionic Framework may exist in other repositories. Please open issues and pull requests in their respective repositories.

Ionic 2/3: Moved to ionic-team/ionic-v3
Ionic 1: Moved to ionic-team/ionic-v1

Description

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.

angular capacitor framework frontend ionic ios javascript material-design mobile pwa react stencil stenciljs typescript vue web webcomponents

Readme MIT 2.5 GiB

Languages

TypeScript 61.2%

HTML 25%

SCSS 10.4%

JavaScript 1.9%

Vue 1%

Other 0.5%

README.md

Ionic

Quickstart · Documentation · Contribute · Blog Community: Discord · Forums · Twitter

Packages

Getting Started

Migration Guides

Examples

Contributing

Earlier Versions

Quickstart · Documentation · Contribute · Blog
Community: Discord · Forums · Twitter