
Start your review here 👉 [docs/README.md](https://github.com/ionic-team/ionic-framework/blob/FW-6107/docs/README.md) ## What is the current behavior? Documentation files with information on how to contribute, component implementations, testing, etc. are scattered throughout various folders in this repository. ## What is the new behavior? Consolidates the documentation files into a root `docs/` directory for easier discovery and organization. `/docs` tree: ``` ├── _config.yml ├── component-guide.md ├── CONTRIBUTING.md ├── README.md ├── sass-guidelines.md ├── angular │ ├── README.md │ └── testing.md ├── core │ ├── README.md │ └── testing │ ├── README.md │ ├── api.md │ ├── best-practices.md │ ├── preview-changes.md │ └── usage-instructions.md ├── react │ ├── README.md │ └── testing.md ├── react-router │ ├── README.md │ └── testing.md ├── vue │ ├── README.md │ └── testing.md └── vue-router ├── README.md └── testing.md ``` **Migrates the following:** | Previous Location | New Location | | ----------------------------------------------------------- | ----------------------------------------- | | `.github/COMPONENT-GUIDE.md` | `docs/component-guide.md` | | `.github/CONTRIBUTING.md` | `docs/CONTRIBUTING.md` | | `core/scripts/README.md` | `docs/core/testing/preview-changes.md` | | `core/src/utils/test/playwright/docs/api.md` | `docs/core/testing/api.md` | | `core/src/utils/test/playwright/docs/best-practices.md` | `docs/core/testing/best-practices.md` | | `core/src/utils/test/playwright/docs/README.md` | `docs/core/testing/README.md` | | `core/src/utils/test/playwright/docs/usage-instructions.md` | `docs/core/testing/usage-instructions.md` | | `packages/angular/test/README.md` | `docs/angular/testing.md` | | `packages/react-router/test/README.md` | `docs/react-router/testing.md` | | `packages/react/test/README.md` | `docs/react/testing.md` | | `packages/react/test/base/README.md` | `docs/react/testing.md` | | `packages/vue/test/README.md` | `docs/vue/testing.md` | **Adds the following:** | File | Description | | ----------------------------- | ----------------------------------------------------------------------- | | `docs/sass-guidelines.md` | Sass Variable guidelines taken from `ionic-framework-design-documents` | | `docs/README.md` | Entry file that should link to all other files | | `docs/_config.yml` | Config file for use with GitHub pages | | `docs/core/README.md` | Description of core, links to contributing and testing | | `docs/angular/README.md` | Description of angular, links to contributing and testing | | `docs/react/README.md` | Description of react, links to contributing and testing | | `docs/react-router/README.md` | Description of react-router, links to contributing and testing | | `docs/vue/README.md` | Description of vue, links to contributing and testing | | `docs/vue-router/README.md` | Description of vue-router, links to contributing and testing | | `docs/vue-router/testing.md` | Testing file for vue-router, populated from vue-router's main README | **Does not** add any files for `angular-server`. This is because the README is essentially empty and there is no testing in that directory. I can add blank files if we want to have something to add to later. **Does not** migrate the content of the packages' root `README.md` files. These files are used for their npm package descriptions so we should not edit them. ## Hosting Documentation We can (and should) host these files using GitHub Pages. I have duplicated them in a personal repository to see how this would look: [docs-consolidation](https://brandyscarney.github.io/docs-consolidation/). Doing so will require some formatting fixes (see [Sass Guidelines](https://brandyscarney.github.io/docs-consolidation/sass-guidelines.html#-reusable-values)) so I did not publish them now but we can easily enable GitHub pages by toggling a setting in this repository. ## Other information - Verify that no documentation files were missed in the migration - You can use these commands to search for `*.md` files in a directory: - `find core/src -type f -name "*.md" -print` - `find packages/angular -type f -name "*.md" -not -path "**/node_modules/*" -print` - I did add some redirect links in some of the existing markdown files so they might still exist for that reason - We should probably break up the contributing + component guide documentation into smaller files, such as including best practices, but I wanted to get everything in the same place first - The contributing has sections on each of the packages that we could move to that package's docs folder: https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#core --------- Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
6.1 KiB
Angular Testing
Ionic Framework supports multiple versions of Angular. As a result, we need to verify that Ionic works correctly with each of these Angular versions.
Syncing Local Changes
The Angular test app supports syncing your locally built changes for validation.
- Build the
core
andpackages/angular
directories usingnpm run build
. - Build the Angular test app.
- Navigate to the built test app directory (e.g.
packages/angular/test/build/ng14
). - Install dependencies using
npm install
. - Sync your local changes using
npm run sync
.
From here you can either build the application or start a local dev server. When re-syncing changes, you will need to wipe or disable the application cache.
Application Cache
Angular CLI creates a cache of several files on disk by default in the .angular
directory. This decreases the time taken to build the test application. However, the cache makes it difficult to quickly sync and check local changes of Ionic. As a result, the .angular
cache is disabled by default in the test app projects.
See https://angular.io/cli/cache for more information.
Disable Cache
ng cache disable
Note
You may need to manually remove the
.angular
directory once after running this command.
Enable Cache
ng cache enable
Note
You will need to delete the
.angular
cache and restart the dev server every time you want to sync local changes of Ionic.
Test App Build Structure
Note
Please confirm your current directory as
packages/angular/test
before proceeding with any of the following commands.
Unlike other test applications, these test apps are broken up into multiple directories. These directories are then combined to create a single application. This allows us to share common application code, tests, etc so that each app is being tested the same way. Below details the different pieces that help create a single test application.
apps - This directory contains partial applications for each version of Angular we want to test. Typically these directories contain new package.json
files, angular.json
files, and more. If you have code that is specific to a particular version of Angular, put it in this directory.
base - This directory contains the base application that each test app will use. This is where tests, application logic, and more live. If you have code that needs to be run on every test app, put it in this directory.
build - When the apps
and base
directories are merged, the final result is put in this directory. The build
directory should never be committed to git.
build.sh - This is the script that merges the apps
and base
directories and places the built application in the build
directory.
Usage:
# Build a test app using apps/ng14 as a reference
./build.sh ng14
How to modify test apps
To add new tests, components, or pages, modify the base
project. This ensures that tests are run for every tested version.
If you want to add a version-specific change, add the change inside of the appropriate projects in apps
. Be sure to replicate the directory structure. For example, if you are adding a new E2E test file called test.spec.ts
in apps/ng14
, make sure you place the file in apps/ng14/e2e/src/test.spec.ts
.
Version-specific tests
If you need to add E2E tests that are only run on a specific version of the JS Framework, replicate the VersionTest
component on each partial application. This ensures that tests for framework version X do not get run for framework version Y.
Testing Lazy Loaded Ionic Components
Tests for lazy loaded Ionic UI components should only be added under the /lazy
route. This ensures the IonicModule
is added.
Testing Standalone Ionic Components
Tests for standalone Ionic UI components should only be added under the /standalone
route. This allows for an isolated environment where the lazy loaded IonicModule
is not initialized. The standalone components use Stencil's custom element bundle instead of the lazy loaded bundle. If IonicModule
is initialized then the Stencil components will fall back to using the lazy loaded implementation instead of the custom elements bundle implementation.
Adding New Test Apps
As we add support for new versions of Angular, we will also need to update this directory to test against new applications. The following steps can serve as a guide for adding new apps:
- Navigate to the built app for the most recent version of Angular that Ionic tests.
- Update the application by following the steps on https://update.angular.io/.
- Make note of any files that changed during the upgrade (
package.json
,package-lock.json
,angular.json
, etc). - Copy the changed files to a new directory in
apps
. - Add a new entry to the matrix for
test-core-angular
in./github/workflows/build.yml
. This will allow the new test app to run against all PRs. - Commit these changes and push.
Example:
In this example, we are going to add the Angular 14 test app.
- Build the Angular 13 test app using
./build.sh ng13
. - Navigate to
build/ng13
. - Perform the upgrade steps on https://update.angular.io/. The "From" field should say "13.0" and the "To" field should say "14.0".
Note: You may encounter some other peer dependency issues not covered by the Angular Upgrade Guide. These peer dependency issues can be resolved manually by updating the installed version of each dependency.
- Observe that the output of the Angular upgrade indicates that the following files were modified:
angular.json
package-lock.json
package.json
tsconfig.json
src/app/form/form.component.ts
src/app/modal-example/modal-example.component.ts
- Create a directory in
apps
namedng14
. - Copy the modified files to the
apps/ng14
directory. - Open
./github/workflows/build.yml
and find thetest-angular-e2e
job. - Find the
apps
field undermatrix
. - Add "ng14" to the
apps
field. - Open
./github/workflows/stencil-nightly.yml
and find thetest-angular-e2e
job. - Repeat steps 8 and 9.
- Commit these changes and push.