Update README.md (#27107)

* Update README.md

* Update README.md

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -21,6 +21,7 @@ body:
         - label: v4.x
         - label: v5.x
         - label: v6.x
+        - label: v7.x
         - label: Nightly
   - type: textarea
     attributes:

.github/workflows/build.yml

@@ -3,7 +3,8 @@ name: 'Ionic Framework Build'
 on:
   pull_request:
     branches: [ '**' ]
-
+  merge_group:
+  
 # When pushing a new commit we should
 # cancel the previous test run to not
 # consume more runners than we need to.
@@ -11,6 +12,7 @@ concurrency:
   group: ${{ github.ref }}
   cancel-in-progress: true
 
+
 jobs:
   build-core:
     runs-on: ubuntu-latest
@@ -44,10 +46,6 @@ jobs:
 
   test-core-screenshot:
     strategy:
-      # This ensures that all screenshot shard
-      # failures are reported so the dev can
-      # review everything at once.
-      fail-fast: false
       matrix:
         # Divide the tests into n buckets
         # and run those buckets in parallel.

.gitignore

@@ -7,6 +7,7 @@
 log.txt
 *.sublime-project
 *.sublime-workspace
+*.tgz
 
 .idea/
 .vscode/

BETA.md

@@ -1,3 +1,5 @@
+Test B
+
 # Ionic Framework v6 Beta
 
 Thanks for your interest in trying out the Framework v6 beta! We are looking for developers to help test our new changes and provide feedback so that we can make Framework v6 the best release yet! Follow this guide to get setup with the beta.

BREAKING.md

@@ -1,3 +1,5 @@
+test branch update
+
 # Breaking Changes
 
 This is a comprehensive list of the breaking changes introduced in the major version releases of Ionic Framework.

CHANGELOG.md

@@ -3,6 +3,34 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.5.3](https://github.com/ionic-team/ionic-framework/compare/v6.5.2...v6.5.3) (2023-02-08)
+
+
+### Bug Fixes
+
+* **button:** size and strong are respected in ion-buttons ([#26726](https://github.com/ionic-team/ionic-framework/issues/26726)) ([3759125](https://github.com/ionic-team/ionic-framework/commit/37591255b4ab3dde5ece6950024a3b66e7224364))
+* **chip:** descenders are not clipped in label ([#26729](https://github.com/ionic-team/ionic-framework/issues/26729)) ([a9e000b](https://github.com/ionic-team/ionic-framework/commit/a9e000b4338f75c27e9284dbe9a6501ba3b213bc)), closes [#18313](https://github.com/ionic-team/ionic-framework/issues/18313)
+* **refresher:** prevent clearing virtual scroll overflow styling ([#26613](https://github.com/ionic-team/ionic-framework/issues/26613)) ([9d6ec29](https://github.com/ionic-team/ionic-framework/commit/9d6ec2925cb2314d5379b864aef467b34afbb318)), closes [#26553](https://github.com/ionic-team/ionic-framework/issues/26553)
+
+
+
+
+
+## [6.5.2](https://github.com/ionic-team/ionic-framework/compare/v6.5.1...v6.5.2) (2023-02-01)
+
+
+### Bug Fixes
+
+* **item:** inherit aria attributes before render ([#26546](https://github.com/ionic-team/ionic-framework/issues/26546)) ([95a3c69](https://github.com/ionic-team/ionic-framework/commit/95a3c69bbbe415cb5f14ac8e1faed287e91b4b40)), closes [#26538](https://github.com/ionic-team/ionic-framework/issues/26538)
+* **popover:** popover opens on chrome 109 ([#26672](https://github.com/ionic-team/ionic-framework/issues/26672)) ([69d89ea](https://github.com/ionic-team/ionic-framework/commit/69d89eae940ccd8b0cca379a961166c4592f34c7)), closes [#26643](https://github.com/ionic-team/ionic-framework/issues/26643)
+* **popover:** resolve import warning in stencil apps ([#26705](https://github.com/ionic-team/ionic-framework/issues/26705)) ([95f65a5](https://github.com/ionic-team/ionic-framework/commit/95f65a5a390eb600de8998c8be9dfd7c023d1eeb)), closes [#26704](https://github.com/ionic-team/ionic-framework/issues/26704)
+* **select:** setting options async updates rendered text ([#26667](https://github.com/ionic-team/ionic-framework/issues/26667)) ([a687457](https://github.com/ionic-team/ionic-framework/commit/a6874579361db548d961fdee83299d664dd6541b)), closes [#19324](https://github.com/ionic-team/ionic-framework/issues/19324)
+* **vue:** cache attached view reference ([#26694](https://github.com/ionic-team/ionic-framework/issues/26694)) ([7c00897](https://github.com/ionic-team/ionic-framework/commit/7c0089718afbbe3e19fecee4abbea00a6e618d95)), closes [#26695](https://github.com/ionic-team/ionic-framework/issues/26695)
+
+
+
+
+
 ## [6.5.1](https://github.com/ionic-team/ionic-framework/compare/v6.5.0...v6.5.1) (2023-01-25)
 
 

README.md

@@ -1,3 +1,5 @@
+TEST A
+
 <p align="center">
   <a href="#">
     <img alt="Ionic" src="https://github.com/ionic-team/ionic-framework/blob/main/.github/assets/logo.png?raw=true" width="60" />

angular/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.5.3](https://github.com/ionic-team/ionic/compare/v6.5.2...v6.5.3) (2023-02-08)
+
+**Note:** Version bump only for package @ionic/angular
+
+
+
+
+
+## [6.5.2](https://github.com/ionic-team/ionic/compare/v6.5.1...v6.5.2) (2023-02-01)
+
+
+### Bug Fixes
+
+* **popover:** popover opens on chrome 109 ([#26672](https://github.com/ionic-team/ionic/issues/26672)) ([69d89ea](https://github.com/ionic-team/ionic/commit/69d89eae940ccd8b0cca379a961166c4592f34c7)), closes [#26643](https://github.com/ionic-team/ionic/issues/26643)
+
+
+
+
+
 ## [6.5.1](https://github.com/ionic-team/ionic/compare/v6.5.0...v6.5.1) (2023-01-25)
 
 **Note:** Version bump only for package @ionic/angular

angular/package-lock.json

@@ -1,15 +1,15 @@
 {
   "name": "@ionic/angular",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@ionic/angular",
-      "version": "6.5.1",
+      "version": "6.5.3",
       "license": "MIT",
       "dependencies": {
-        "@ionic/core": "^6.5.1",
+        "@ionic/core": "^6.5.3",
         "ionicons": "^6.1.1",
         "jsonc-parser": "^3.0.0",
         "tslib": "^2.0.0"
@@ -1006,8 +1006,9 @@
       "license": "BSD-3-Clause"
     },
     "node_modules/@ionic/core": {
-      "version": "6.5.0",
-      "license": "MIT",
+      "version": "6.5.3",
+      "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.5.3.tgz",
+      "integrity": "sha512-z4slJZEw0PLet2htICKmCh76sN6kY28GSaYLDV1b4O/ya6qgu4QDwPkKbg22E8fiXBALlilce2zJQ55Tx5C6Aw==",
       "dependencies": {
         "@stencil/core": "^2.18.0",
         "ionicons": "^6.1.1",
@@ -7333,7 +7334,9 @@
       "dev": true
     },
     "@ionic/core": {
-      "version": "6.5.0",
+      "version": "6.5.3",
+      "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.5.3.tgz",
+      "integrity": "sha512-z4slJZEw0PLet2htICKmCh76sN6kY28GSaYLDV1b4O/ya6qgu4QDwPkKbg22E8fiXBALlilce2zJQ55Tx5C6Aw==",
       "requires": {
         "@stencil/core": "^2.18.0",
         "ionicons": "^6.1.1",

angular/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ionic/angular",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "description": "Angular specific wrappers for @ionic/core",
   "keywords": [
     "ionic",
@@ -42,7 +42,7 @@
     "validate": "npm i && npm run lint && npm run test && npm run build"
   },
   "dependencies": {
-    "@ionic/core": "^6.5.1",
+    "@ionic/core": "^6.5.3",
     "ionicons": "^6.1.1",
     "jsonc-parser": "^3.0.0",
     "tslib": "^2.0.0"

angular/scripts/sync.sh

@@ -2,8 +2,11 @@
 
 set -e
 
-# Copy core dist
-rm -rf node_modules/@ionic/core/dist node_modules/@ionic/core/components
-cp -a ../core/dist node_modules/@ionic/core/dist
-cp -a ../core/components node_modules/@ionic/core/components
-cp -a ../core/package.json node_modules/@ionic/core/package.json
+# Pack @ionic/core
+npm pack ../core
+
+# Pack @ionic/angular
+npm pack ./
+
+# Install Dependencies
+npm install *.tgz --no-save

angular/src/providers/angular-delegate.ts

@@ -30,9 +30,17 @@ export class AngularDelegate {
   create(
     resolverOrInjector: ComponentFactoryResolver,
     injector: Injector,
-    location?: ViewContainerRef
+    location?: ViewContainerRef,
+    elementReferenceKey?: string
   ): AngularFrameworkDelegate {
-    return new AngularFrameworkDelegate(resolverOrInjector, injector, location, this.appRef, this.zone);
+    return new AngularFrameworkDelegate(
+      resolverOrInjector,
+      injector,
+      location,
+      this.appRef,
+      this.zone,
+      elementReferenceKey
+    );
   }
 }
 
@@ -45,12 +53,29 @@ export class AngularFrameworkDelegate implements FrameworkDelegate {
     private injector: Injector,
     private location: ViewContainerRef | undefined,
     private appRef: ApplicationRef,
-    private zone: NgZone
+    private zone: NgZone,
+    private elementReferenceKey?: string
   ) {}
 
   attachViewToDom(container: any, component: any, params?: any, cssClasses?: string[]): Promise<any> {
     return this.zone.run(() => {
       return new Promise((resolve) => {
+        const componentProps = {
+          ...params,
+        };
+
+        /**
+         * Ionic Angular passes a reference to a modal
+         * or popover that can be accessed using a
+         * variable in the overlay component. If
+         * elementReferenceKey is defined, then we should
+         * pass a reference to the component using
+         * elementReferenceKey as the key.
+         */
+        if (this.elementReferenceKey !== undefined) {
+          componentProps[this.elementReferenceKey] = container;
+        }
+
         const el = attachView(
           this.zone,
           this.resolverOrInjector,
@@ -61,7 +86,7 @@ export class AngularFrameworkDelegate implements FrameworkDelegate {
           this.elEventsMap,
           container,
           component,
-          params,
+          componentProps,
           cssClasses
         );
         resolve(el);

angular/src/providers/modal-controller.ts

@@ -21,7 +21,12 @@ export class ModalController extends OverlayBaseController<ModalOptions, HTMLIon
   create(opts: ModalOptions): Promise<HTMLIonModalElement> {
     return super.create({
       ...opts,
-      delegate: this.angularDelegate.create(this.resolver ?? this.environmentInjector, this.injector),
+      delegate: this.angularDelegate.create(
+        this.resolver ?? this.environmentInjector,
+        this.injector,
+        undefined,
+        'modal'
+      ),
     });
   }
 }

angular/src/providers/popover-controller.ts

@@ -21,7 +21,12 @@ export class PopoverController extends OverlayBaseController<PopoverOptions, HTM
   create(opts: PopoverOptions): Promise<HTMLIonPopoverElement> {
     return super.create({
       ...opts,
-      delegate: this.angularDelegate.create(this.resolver ?? this.environmentInjector, this.injector),
+      delegate: this.angularDelegate.create(
+        this.resolver ?? this.environmentInjector,
+        this.injector,
+        undefined,
+        'popover'
+      ),
     });
   }
 }

angular/test/base/scripts/sync.sh

@@ -2,19 +2,14 @@
 
 set -e
 
-# Copy angular dist
-rm -rf node_modules/@ionic/angular
-cp -a ../../../dist node_modules/@ionic/angular
+# Pack @ionic/core
+npm pack ../../../../core
 
-# Copy angular server
-rm -rf node_modules/@ionic/angular-server
-cp -a ../../../../packages/angular-server/dist node_modules/@ionic/angular-server
+# Pack @ionic/angular
+npm pack ../../../dist
 
-# # Copy core dist
-rm -rf node_modules/@ionic/core
-mkdir node_modules/@ionic/core
-cp -a ../../../../core/css node_modules/@ionic/core/css
-cp -a ../../../../core/dist node_modules/@ionic/core/dist
-cp -a ../../../../core/hydrate node_modules/@ionic/core/hydrate
-cp -a ../../../../core/loader node_modules/@ionic/core/loader
-cp -a ../../../../core/package.json node_modules/@ionic/core/package.json
+# Pack @ionic/angular-server
+npm pack ../../../../packages/angular-server/dist
+
+# Install Dependencies
+npm install *.tgz --no-save

core/CHANGELOG.md

@@ -1,8 +1,36 @@
+
 # Change Log
 
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.5.3](https://github.com/ionic-team/ionic/compare/v6.5.2...v6.5.3) (2023-02-08)
+
+
+### Bug Fixes
+
+* **button:** size and strong are respected in ion-buttons ([#26726](https://github.com/ionic-team/ionic/issues/26726)) ([3759125](https://github.com/ionic-team/ionic/commit/37591255b4ab3dde5ece6950024a3b66e7224364))
+* **chip:** descenders are not clipped in label ([#26729](https://github.com/ionic-team/ionic/issues/26729)) ([a9e000b](https://github.com/ionic-team/ionic/commit/a9e000b4338f75c27e9284dbe9a6501ba3b213bc)), closes [#18313](https://github.com/ionic-team/ionic/issues/18313)
+* **refresher:** prevent clearing virtual scroll overflow styling ([#26613](https://github.com/ionic-team/ionic/issues/26613)) ([9d6ec29](https://github.com/ionic-team/ionic/commit/9d6ec2925cb2314d5379b864aef467b34afbb318)), closes [#26553](https://github.com/ionic-team/ionic/issues/26553)
+
+
+
+
+
+## [6.5.2](https://github.com/ionic-team/ionic/compare/v6.5.1...v6.5.2) (2023-02-01)
+
+
+### Bug Fixes
+
+* **item:** inherit aria attributes before render ([#26546](https://github.com/ionic-team/ionic/issues/26546)) ([95a3c69](https://github.com/ionic-team/ionic/commit/95a3c69bbbe415cb5f14ac8e1faed287e91b4b40)), closes [#26538](https://github.com/ionic-team/ionic/issues/26538)
+* **popover:** popover opens on chrome 109 ([#26672](https://github.com/ionic-team/ionic/issues/26672)) ([69d89ea](https://github.com/ionic-team/ionic/commit/69d89eae940ccd8b0cca379a961166c4592f34c7)), closes [#26643](https://github.com/ionic-team/ionic/issues/26643)
+* **popover:** resolve import warning in stencil apps ([#26705](https://github.com/ionic-team/ionic/issues/26705)) ([95f65a5](https://github.com/ionic-team/ionic/commit/95f65a5a390eb600de8998c8be9dfd7c023d1eeb)), closes [#26704](https://github.com/ionic-team/ionic/issues/26704)
+* **select:** setting options async updates rendered text ([#26667](https://github.com/ionic-team/ionic/issues/26667)) ([a687457](https://github.com/ionic-team/ionic/commit/a6874579361db548d961fdee83299d664dd6541b)), closes [#19324](https://github.com/ionic-team/ionic/issues/19324)
+
+
+
+
+
 ## [6.5.1](https://github.com/ionic-team/ionic/compare/v6.5.0...v6.5.1) (2023-01-25)
 
 

core/README.md

@@ -1,3 +1,7 @@
+
+
+third commit
+
 # @ionic/core
 
 [Ionic](https://ionicframework.com/) is an open source App Development Framework that makes it easy to build top quality Native and Progressive Web Apps with web technologies.

core/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@ionic/core",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@ionic/core",
-      "version": "6.5.1",
+      "version": "6.5.3",
       "license": "MIT",
       "dependencies": {
         "@stencil/core": "^2.18.0",
@@ -24,7 +24,7 @@
         "@stencil/angular-output-target": "^0.4.0",
         "@stencil/react-output-target": "^0.2.1",
         "@stencil/sass": "^2.0.0",
-        "@stencil/vue-output-target": "^0.6.2",
+        "@stencil/vue-output-target": "^0.7.0",
         "@types/jest": "^27.5.2",
         "@types/node": "^14.6.0",
         "@types/swiper": "5.4.0",
@@ -1632,12 +1632,12 @@
       }
     },
     "node_modules/@stencil/vue-output-target": {
-      "version": "0.6.2",
-      "resolved": "https://registry.npmjs.org/@stencil/vue-output-target/-/vue-output-target-0.6.2.tgz",
-      "integrity": "sha512-Oh7SLFbOUchCSCbGe/Dqal2xSYPKCFQiVKnvzvS0dsHP/XS7rfHqp3qptW6JCp9lBoo3wmmBurHfldqxhLlnag==",
+      "version": "0.7.0",
+      "resolved": "https://registry.npmjs.org/@stencil/vue-output-target/-/vue-output-target-0.7.0.tgz",
+      "integrity": "sha512-iPEgnT2z6HsfWVRWVZk5C1AaMZnbJjB+c/hvtWoO7B3aErTJB8Up6oFk/t3IRsr12aNuZ4fUra0FEDx9WweH0Q==",
       "dev": true,
       "peerDependencies": {
-        "@stencil/core": "^2.9.0"
+        "@stencil/core": "^2.9.0 || ^3.0.0-beta.0"
       }
     },
     "node_modules/@stylelint/postcss-css-in-js": {
@@ -11638,9 +11638,9 @@
       "requires": {}
     },
     "@stencil/vue-output-target": {
-      "version": "0.6.2",
-      "resolved": "https://registry.npmjs.org/@stencil/vue-output-target/-/vue-output-target-0.6.2.tgz",
-      "integrity": "sha512-Oh7SLFbOUchCSCbGe/Dqal2xSYPKCFQiVKnvzvS0dsHP/XS7rfHqp3qptW6JCp9lBoo3wmmBurHfldqxhLlnag==",
+      "version": "0.7.0",
+      "resolved": "https://registry.npmjs.org/@stencil/vue-output-target/-/vue-output-target-0.7.0.tgz",
+      "integrity": "sha512-iPEgnT2z6HsfWVRWVZk5C1AaMZnbJjB+c/hvtWoO7B3aErTJB8Up6oFk/t3IRsr12aNuZ4fUra0FEDx9WweH0Q==",
       "dev": true,
       "requires": {}
     },

core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ionic/core",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "description": "Base components for Ionic",
   "keywords": [
     "ionic",
@@ -46,7 +46,7 @@
     "@stencil/angular-output-target": "^0.4.0",
     "@stencil/react-output-target": "^0.2.1",
     "@stencil/sass": "^2.0.0",
-    "@stencil/vue-output-target": "^0.6.2",
+    "@stencil/vue-output-target": "^0.7.0",
     "@types/jest": "^27.5.2",
     "@types/node": "^14.6.0",
     "@types/swiper": "5.4.0",

core/src/components/button/button.ios.scss

@@ -1,5 +1,6 @@
 @import "./button";
 @import "./button.ios.vars";
+@import "../toolbar/toolbar.ios.vars";
 
 
 // iOS Button
@@ -23,6 +24,20 @@
   letter-spacing: #{$button-ios-letter-spacing};
 }
 
+/**
+ * The default buttons in a toolbar
+ * have a different font size/weight
+ * than buttons outside of a toolbar on iOS.
+ * However, we still want the "size"/"strong"
+ * properties to be usable in a toolbar, so we add
+ * the .in-buttons selector such that we
+ * can add the different font size/weight in a toolbar
+ * but still let "size"/"strong" override it.
+ */
+:host(.in-buttons) {
+  font-size: #{$toolbar-ios-button-font-size};
+  font-weight: 400;
+}
 
 // iOS Solid Button
 // --------------------------------------------------

core/src/components/button/button.tsx

@@ -293,6 +293,7 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
           [`${buttonType}-strong`]: strong,
           'in-toolbar': hostContext('ion-toolbar', this.el),
           'in-toolbar-color': hostContext('ion-toolbar[color]', this.el),
+          'in-buttons': hostContext('ion-buttons', this.el),
           'button-has-icon-only': hasIconOnly,
           'button-disabled': disabled,
           'ion-activatable': true,

core/src/components/button/test/size/button.e2e.ts

@@ -2,11 +2,53 @@ import { expect } from '@playwright/test';
 import { test } from '@utils/test/playwright';
 
 test.describe('button: size', () => {
-  test('should not have visual regressions', async ({ page }) => {
-    await page.goto(`/src/components/button/test/size`);
+  test.beforeEach(({ skip }) => {
+    skip.rtl();
+  });
+  test('should render small buttons', async ({ page }) => {
+    await page.setContent(`
+      <ion-button size="small" fill="solid">Small Button</ion-button>
+    `);
 
-    await page.setIonViewport();
+    const wrapper = page.locator('ion-button');
 
-    expect(await page.screenshot()).toMatchSnapshot(`button-size-${page.getSnapshotSettings()}.png`);
+    expect(await wrapper.screenshot()).toMatchSnapshot(`button-size-small-${page.getSnapshotSettings()}.png`);
+  });
+  test('should render large buttons', async ({ page }) => {
+    await page.setContent(`
+      <ion-button size="large" fill="solid">Large Button</ion-button>
+    `);
+
+    const wrapper = page.locator('ion-button');
+
+    expect(await wrapper.screenshot()).toMatchSnapshot(`button-size-large-${page.getSnapshotSettings()}.png`);
+  });
+  test.describe('in ion-buttons', () => {
+    test('should render small button', async ({ page }) => {
+      await page.setContent(`
+        <ion-buttons>
+          <ion-button size="small" fill="solid">Small Button</ion-button>
+        </ion-buttons>
+      `);
+
+      const wrapper = page.locator('ion-button');
+
+      expect(await wrapper.screenshot()).toMatchSnapshot(
+        `button-size-small-in-buttons-${page.getSnapshotSettings()}.png`
+      );
+    });
+    test('should render large button', async ({ page }) => {
+      await page.setContent(`
+        <ion-buttons>
+          <ion-button size="large" fill="solid">Large Button</ion-button>
+        </ion-buttons>
+      `);
+
+      const wrapper = page.locator('ion-button');
+
+      expect(await wrapper.screenshot()).toMatchSnapshot(
+        `button-size-large-in-buttons-${page.getSnapshotSettings()}.png`
+      );
+    });
   });
 });

core/src/components/button/test/size/index.html

@@ -18,6 +18,11 @@
     <ion-app>
       <ion-header>
         <ion-toolbar>
+          <ion-buttons slot="start">
+            <ion-button fill="solid">Default Button</ion-button>
+            <ion-button fill="solid" size="small">Small Button</ion-button>
+            <ion-button fill="solid" size="large">Large Button</ion-button>
+          </ion-buttons>
           <ion-title>Button - Size</ion-title>
         </ion-toolbar>
       </ion-header>

core/src/components/button/test/strong/button.e2e.ts

@@ -1,12 +1,57 @@
 import { expect } from '@playwright/test';
 import { test } from '@utils/test/playwright';
 
+/**
+ * Clear buttons have special font-weight
+ * styles which is why we make sure
+ * to capture the clear button here.
+ */
 test.describe('button: strong', () => {
-  test('should not have visual regressions', async ({ page }) => {
-    await page.goto(`/src/components/button/test/strong`);
+  test.beforeEach(({ skip }) => {
+    skip.rtl();
+  });
+  test('should render strong button', async ({ page }) => {
+    await page.setContent(`
+      <ion-button fill="solid" strong="true">Button</ion-button>
+    `);
 
-    await page.setIonViewport();
+    const wrapper = page.locator('ion-button');
 
-    expect(await page.screenshot()).toMatchSnapshot(`button-strong-${page.getSnapshotSettings()}.png`);
+    expect(await wrapper.screenshot()).toMatchSnapshot(`button-strong-${page.getSnapshotSettings()}.png`);
+  });
+  test('should render strong clear button', async ({ page }) => {
+    await page.setContent(`
+      <ion-button fill="clear" strong="true">Button</ion-button>
+    `);
+
+    const wrapper = page.locator('ion-button');
+
+    expect(await wrapper.screenshot()).toMatchSnapshot(`button-clear-strong-${page.getSnapshotSettings()}.png`);
+  });
+  test.describe('in ion-buttons', () => {
+    test('should render strong button', async ({ page }) => {
+      await page.setContent(`
+        <ion-buttons>
+          <ion-button strong="true" fill="solid">Button</ion-button>
+        </ion-buttons>
+      `);
+
+      const wrapper = page.locator('ion-button');
+
+      expect(await wrapper.screenshot()).toMatchSnapshot(`button-strong-in-buttons-${page.getSnapshotSettings()}.png`);
+    });
+    test('should render strong clear button', async ({ page }) => {
+      await page.setContent(`
+        <ion-buttons>
+          <ion-button strong="true" fill="clear">Button</ion-button>
+        </ion-buttons>
+      `);
+
+      const wrapper = page.locator('ion-button');
+
+      expect(await wrapper.screenshot()).toMatchSnapshot(
+        `button-clear-strong-in-buttons-${page.getSnapshotSettings()}.png`
+      );
+    });
   });
 });

core/src/components/button/test/strong/index.html

@@ -18,6 +18,11 @@
     <ion-app>
       <ion-header>
         <ion-toolbar>
+          <ion-buttons slot="start">
+            <ion-button fill="solid" strong="true">Solid Button</ion-button>
+            <ion-button fill="outline" strong="true">Outline Button</ion-button>
+            <ion-button fill="clear" strong="true">Clear Button</ion-button>
+          </ion-buttons>
           <ion-title>Button - Strong</ion-title>
         </ion-toolbar>
       </ion-header>

core/src/components/buttons/buttons.ios.scss

@@ -12,9 +12,6 @@
   @include margin-horizontal(2px, 2px);
 
   height: 32px;
-
-  font-size: #{$toolbar-ios-button-font-size};
-  font-weight: 400;
 }
 
 ::slotted(*) ion-button:not(.button-round) {

core/src/components/buttons/buttons.md.scss

@@ -14,9 +14,6 @@
   @include margin-horizontal(2px, 2px);
 
   height: 32px;
-
-  font-size: #{$toolbar-md-button-font-size};
-  font-weight: 500;
 }
 
 ::slotted(*) ion-button:not(.button-round) {

core/src/components/chip/chip.scss

@@ -27,8 +27,6 @@
   font-family: $font-family-base;
   font-size: 14px;
 
-  line-height: 1;
-
   cursor: pointer;
 
   overflow: hidden;

core/src/components/chip/test/basic/chip.e2e.ts

@@ -9,4 +9,28 @@ test.describe('chip: rendering', () => {
 
     expect(await page.screenshot()).toMatchSnapshot(`chip-basic-${page.getSnapshotSettings()}.png`);
   });
+
+  test('should not clip descenders in item', async ({ page, skip }) => {
+    skip.rtl();
+    skip.mode('md');
+
+    test.info().annotations.push({
+      type: 'issue',
+      description: 'https://github.com/ionic-team/ionic-framework/issues/18313',
+    });
+
+    await page.setContent(`
+      <ion-list>
+        <ion-item>
+          <ion-chip>
+            <ion-label>Agreements</ion-label>
+          </ion-chip>
+        </ion-item>
+      </ion-list>
+    `);
+
+    const chip = page.locator('ion-chip');
+
+    expect(await chip.screenshot()).toMatchSnapshot(`chip-descender-${page.getSnapshotSettings()}.png`);
+  });
 });

core/src/components/datetime/test/locale/datetime.e2e.ts

@@ -27,23 +27,6 @@ test.describe('datetime: locale', () => {
     });
   });
 
-  test.describe('ta-IN', () => {
-    test('should not have visual regressions', async () => {
-      await datetimeFixture.goto('ta-IN', 'date');
-      await datetimeFixture.expectLocalizedDatePicker();
-    });
-
-    test('month/year picker should not have visual regressions', async () => {
-      await datetimeFixture.goto('ta-IN', 'month-year');
-      await datetimeFixture.expectLocalizedMonthYearPicker();
-    });
-
-    test('time picker should not have visual regressions', async () => {
-      await datetimeFixture.goto('ta-IN', 'time');
-      await datetimeFixture.expectLocalizedTimePicker();
-    });
-  });
-
   test.describe('ja-JP', () => {
     test('should not have visual regressions', async () => {
       await datetimeFixture.goto('ja-JP', 'date');