5.2.1

Release 5.2.0

.circleci/config.yml

@@ -1,4 +1,4 @@
-version: 2.1
+version: 2
 
 aliases:
   - &restore-cache
@@ -31,29 +31,10 @@ aliases:
 
 defaults: &defaults
   docker:
-    - image: circleci/node:latest-browsers
+    - image: circleci/node:10-browsers
   working_directory: /tmp/workspace
-  environment:
-    NODE_ENV: development
 
 jobs:
-  puppeteer-dependencies:
-    <<: *defaults
-    steps:
-    - run:
-        name: Install headless Chrome dependencies
-        command: |
-          sudo apt-get install -yq \
-          gconf-service libasound2 libatk1.0-0 libatk-bridge2.0-0 libc6 libcairo2 libcups2 libdbus-1-3 \
-          libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 \
-          libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 \
-          libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 ca-certificates \
-          fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget
-    - run:
-        name: Install Puppeteer with Chromium
-        command: |
-          npm i puppeteer
-
   build:
     <<: *defaults
     steps:
@@ -330,14 +311,13 @@ jobs:
           command: npm install
           working_directory: /tmp/workspace/angular/test/test-app
       - run:
-          command: npm run test -- --protractor-config=e2e/protractor-ci.conf.js
+          command: npm test
           working_directory: /tmp/workspace/angular/test/test-app
 
 workflows:
   version: 2
   build:
     jobs:
-      - puppeteer-dependencies
       - build
       - build-core:
           requires: [build]
@@ -346,7 +326,7 @@ workflows:
       - test-core-lint:
           requires: [build-core]
       - test-core-e2e:
-          requires: [puppeteer-dependencies, build-core]
+          requires: [build-core]
       - test-core-spec:
           requires: [build-core]
       - test-core-treeshake:

.github/ISSUE_TEMPLATE/bug_report.md

@@ -19,8 +19,7 @@ assignees: ''
 **Ionic version:**
 <!-- (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1) -->
 <!-- (For Ionic 2.x & 3.x issues, please use https://github.com/ionic-team/ionic-v3) -->
-[ ] **4.x**
-[x] **5.x**
+[x] **4.x**
 
 **Current behavior:**
 <!-- Describe how the bug manifests. -->

.gitignore

@@ -64,4 +64,3 @@ core/loader/
 core/www/
 .stencil/
 angular/build/
-core/components/

.scripts/common.js

@@ -209,13 +209,6 @@ function prepareDevPackage(tasks, package, version) {
         title: `${pkg.name}: npm link @ionic/core`,
         task: () => execa('npm', ['link', '@ionic/core'], { cwd: projectRoot })
       });
-
-      if (package === 'packages/react-router') {
-        projectTasks.push({
-          title: `${pkg.name}: npm link @ionic/react`,
-          task: () => execa('npm', ['link', '@ionic/react'], { cwd: projectRoot })
-        });
-      }
     }
 
     projectTasks.push({

.scripts/release-dev.js

@@ -78,9 +78,6 @@ async function setPackageVersionChanges(packages, version) {
     if (package !== 'core') {
       const pkg = common.readPkg(package);
       common.updateDependency(pkg, '@ionic/core', version);
-      if(package === 'packages/react-router') {
-        common.updateDependency(pkg, '@ionic/react', version);
-      }
       common.writePkg(package, pkg);
     }
     const projectRoot = common.projectPath(package);

.scripts/release.js

@@ -132,7 +132,7 @@ async function publishGithub(version, gitTag, changelog, npmTag) {
 
   await octokit.repos.createRelease({
     owner: 'ionic-team',
-    repo: 'ionic-framework',
+    repo: 'ionic',
     target_commitish: branch,
     tag_name: gitTag,
     name: version,

CHANGELOG.md

@@ -1,116 +1,3 @@
-## [5.3.4](https://github.com/ionic-team/ionic/compare/v5.3.3...v5.3.4) (2020-09-25)
-
-
-### Bug Fixes
-
-* **alert:** follow accessibility guidelines outlined by wai-aria ([#22159](https://github.com/ionic-team/ionic/issues/22159)) ([e9b2cc8](https://github.com/ionic-team/ionic/commit/e9b2cc8453f5e1c45d44397df738f60ea5b32efd)), closes [#21744](https://github.com/ionic-team/ionic/issues/21744)
-* **overlays:** return focus to presenting element after dismissal ([#22167](https://github.com/ionic-team/ionic/issues/22167)) ([cc45ad8](https://github.com/ionic-team/ionic/commit/cc45ad815c002c5d890f2e105c546b4c3b3a58c0)), closes [#21768](https://github.com/ionic-team/ionic/issues/21768)
-* **picker-column:** add cancelable check to avoid intervention error in chrome ([#22140](https://github.com/ionic-team/ionic/issues/22140)) ([a24a041](https://github.com/ionic-team/ionic/commit/a24a041064fd9ce6ca161d3522083d50e585e9dd)), closes [#22137](https://github.com/ionic-team/ionic/issues/22137)
-* **radio:** follow accessibility guidelines outlined by wai-aria ([#22113](https://github.com/ionic-team/ionic/issues/22113)) ([ea0e049](https://github.com/ionic-team/ionic/commit/ea0e0499e24865faad3d11f50f7037645f6cdcc8)), closes [#21743](https://github.com/ionic-team/ionic/issues/21743)
-* **reorder:** allow click event propagation when reorder group is disabled ([#21947](https://github.com/ionic-team/ionic/issues/21947)) ([baafe08](https://github.com/ionic-team/ionic/commit/baafe08927b7b858170496605781e6fa682e0147)), closes [#21017](https://github.com/ionic-team/ionic/issues/21017)
-* **segment:** do not allow text selection on desktop ([#22158](https://github.com/ionic-team/ionic/issues/22158)) ([1526bdf](https://github.com/ionic-team/ionic/commit/1526bdfb492c1fa8d71f8a1af8cd97abd9e62642))
-
-
-### Performance Improvements
-
-* **segment:** improve scrolling performance on ios when using segment ([#22110](https://github.com/ionic-team/ionic/issues/22110)) ([68afc49](https://github.com/ionic-team/ionic/commit/68afc49e9ed27acffb0b765b7be6b03e8574850d)), closes [#22095](https://github.com/ionic-team/ionic/issues/22095)
-
-
-
-## [5.3.3](https://github.com/ionic-team/ionic/compare/v5.3.2...v5.3.3) (2020-09-17)
-
-
-### Bug Fixes
-
-* **datetime:** do not reset to am when changing hour and pm is set ([#21997](https://github.com/ionic-team/ionic/issues/21997)) ([8b85fe0](https://github.com/ionic-team/ionic/commit/8b85fe0d9eea39adfdcf790bf00d8ef91d5edbe7)), closes [#19175](https://github.com/ionic-team/ionic/issues/19175) [#19260](https://github.com/ionic-team/ionic/issues/19260) [#20026](https://github.com/ionic-team/ionic/issues/20026) [#16630](https://github.com/ionic-team/ionic/issues/16630)
-* **input:** only focus the first input / textarea when clicking on the parent item ([#22049](https://github.com/ionic-team/ionic/issues/22049)) ([99f2532](https://github.com/ionic-team/ionic/commit/99f2532ee174da79e2b6a462cfa124673edc1170)), closes [#22037](https://github.com/ionic-team/ionic/issues/22037) [#22032](https://github.com/ionic-team/ionic/issues/22032)
-* **react:** Keep a hold of previous routes when doing a redirect, closes [#22053](https://github.com/ionic-team/ionic/issues/22053) ([74af3cb](https://github.com/ionic-team/ionic/commit/74af3cb50b089a6bd60d515158e03b18b86455b8))
-* **react:** redirect routes should unmount leaving component, fixes [#22022](https://github.com/ionic-team/ionic/issues/22022) ([#22029](https://github.com/ionic-team/ionic/issues/22029)) ([b11e06c](https://github.com/ionic-team/ionic/commit/b11e06cec1d3c28bab9f29185fe2c3a2975b092f))
-* **textarea:** do not generate duplicate IDs between ion-input and ion-textarea ([#22074](https://github.com/ionic-team/ionic/issues/22074)) ([c72c7ff](https://github.com/ionic-team/ionic/commit/c72c7ffa983af8885dd93f9adfcb3f2af232d2d9)), closes [#21542](https://github.com/ionic-team/ionic/issues/21542)
-
-
-
-## [5.3.2](https://github.com/ionic-team/ionic/compare/v5.3.1...v5.3.2) (2020-08-27)
-
-
-### Bug Fixes
-
-* **input:** improve reliability of scroll assist when accessory bar is enabled ([#21936](https://github.com/ionic-team/ionic/issues/21936)) ([22477fb](https://github.com/ionic-team/ionic/commit/22477fb9bf7c0637aa5c8d0aab34c8ccc521b0b9)), closes [#21912](https://github.com/ionic-team/ionic/issues/21912)
-* **input:** properly focus the input when clicking the item padding in WebKit ([#21930](https://github.com/ionic-team/ionic/issues/21930)) ([e4964ff](https://github.com/ionic-team/ionic/commit/e4964ff77b317c92b201cf7c265787b55bdde4d4)), closes [#21509](https://github.com/ionic-team/ionic/issues/21509)
-* **input:** remain focused in the input after pressing the clear button ([#21985](https://github.com/ionic-team/ionic/issues/21985)) ([6878fb9](https://github.com/ionic-team/ionic/commit/6878fb9eb99c17908f5630019efaa762b5b006e0)), closes [#21549](https://github.com/ionic-team/ionic/issues/21549)
-* **label:** use translateY so input caret shows up due to webkit issue ([#21949](https://github.com/ionic-team/ionic/issues/21949)) ([00eac33](https://github.com/ionic-team/ionic/commit/00eac33053f49dbebf22ef95fddcb66570ed117a)), closes [#21943](https://github.com/ionic-team/ionic/issues/21943)
-* **overlays:** prevent focus from being stolen when presenting another overlay from within a modal ([#21856](https://github.com/ionic-team/ionic/issues/21856)) ([5c177d7](https://github.com/ionic-team/ionic/commit/5c177d756f7755e766d5b619d49825c4799aee47)), closes [#21840](https://github.com/ionic-team/ionic/issues/21840)
-* **range:** properly display stacked labels in an item with a range ([#21944](https://github.com/ionic-team/ionic/issues/21944)) ([9f4b01e](https://github.com/ionic-team/ionic/commit/9f4b01e17fd2f5e742d32bc9e080b6b394c43d37)), closes [#21625](https://github.com/ionic-team/ionic/issues/21625)
-* **react:** export correct animation types ([#21950](https://github.com/ionic-team/ionic/issues/21950)) ([36e4bf7](https://github.com/ionic-team/ionic/commit/36e4bf7dd76e396f910d28445566b5503cc84c8c))
-* **react:** removed exporting of ionRenderToString to decrease bundle size, closes [#21917](https://github.com/ionic-team/ionic/issues/21917) ([#21928](https://github.com/ionic-team/ionic/issues/21928)) ([434befe](https://github.com/ionic-team/ionic/commit/434befea5f31aa599ee5b1b7edf29238912c23d9))
-* **react:** setting active tab properly on mount, closes [#21830](https://github.com/ionic-team/ionic/issues/21830) ([#21833](https://github.com/ionic-team/ionic/issues/21833)) ([f58424f](https://github.com/ionic-team/ionic/commit/f58424f62596b9eb82bebb8e07c211e1725c025a))
-* **react:** fix tab currentHref when changing tabs, closes [#21834](https://github.com/ionic-team/ionic/issues/21834) ([#21835](https://github.com/ionic-team/ionic/issues/21835)) ([74468ab](https://github.com/ionic-team/ionic/commit/74468ab7972b174ba85bf239306c27080f253a4a))
-
-
-
-## [5.3.1](https://github.com/ionic-team/ionic/compare/v5.3.0...v5.3.1) (2020-07-27)
-
-
-### Bug Fixes
-
-* **react:** properly extend HTMLElement for tabs ([bfddb17](https://github.com/ionic-team/ionic/commit/bfddb170659224d0f826762744dfe44a85813d36)), closes [#21803](https://github.com/ionic-team/ionic/issues/21803)
-
-
-
-# [5.3.0 Phosphorus](https://github.com/ionic-team/ionic/compare/v5.2.3...v5.3.0) (2020-07-23)
-
-
-### Bug Fixes
-
-* **angular:** per-page animations now work with swipe to go back ([#21706](https://github.com/ionic-team/ionic/issues/21706)) ([2664587](https://github.com/ionic-team/ionic/commit/2664587749e45100a04f70796733de162b26cdf7)), closes [#21692](https://github.com/ionic-team/ionic/issues/21692)
-* **datetime:** remove unneeded combobox role ([#21708](https://github.com/ionic-team/ionic/issues/21708)) ([f00ad8a](https://github.com/ionic-team/ionic/commit/f00ad8a8357ccd7fe85631dad0c841f2d4c72487))
-* **input:** clear button can now be tabbed to ([#21633](https://github.com/ionic-team/ionic/issues/21633)) ([1dcd9de](https://github.com/ionic-team/ionic/commit/1dcd9de50ae16bfa102e98120a022de5b0287baa))
-* **ios:** improve scroll assist reliability on password inputs ([#21703](https://github.com/ionic-team/ionic/issues/21703)) ([3cbf9e7](https://github.com/ionic-team/ionic/commit/3cbf9e7c4c225d6b02237d8ea8f16fb924ba360e)), closes [#21688](https://github.com/ionic-team/ionic/issues/21688)
-* **keyboard:** keyboard events now consistently fire on android ([#21741](https://github.com/ionic-team/ionic/issues/21741)) ([020f3cc](https://github.com/ionic-team/ionic/commit/020f3cc56cb6dac23dd8766a3802422500b510e2)), closes [#21734](https://github.com/ionic-team/ionic/issues/21734)
-* **nav:** insertPages method correctly inserts multiple pages with props ([#21725](https://github.com/ionic-team/ionic/issues/21725)) ([eb592b8](https://github.com/ionic-team/ionic/commit/eb592b8917b8a7412d8c346f41b47d3b79002b95)), closes [#21724](https://github.com/ionic-team/ionic/issues/21724)
-* **overlays:** trap focus inside overlay components except toast ([#21716](https://github.com/ionic-team/ionic/issues/21716)) ([fff4aec](https://github.com/ionic-team/ionic/commit/fff4aec6cfbd48566594a05f4af57dd0578977a8)), closes [#21647](https://github.com/ionic-team/ionic/issues/21647)
-* **segment-button:** allow min-width to be overridden ([#21722](https://github.com/ionic-team/ionic/issues/21722)) ([88f1828](https://github.com/ionic-team/ionic/commit/88f1828bd8f6b9a1c1f3dcb220d93067bed7f404)), closes [#21105](https://github.com/ionic-team/ionic/issues/21105)
-* **title:** allow overriding of large title transform-origin ([#21770](https://github.com/ionic-team/ionic/issues/21770)) ([dbe6853](https://github.com/ionic-team/ionic/commit/dbe6853884bd76c3d8e229cd58e1571d9b3a7249)), closes [#21761](https://github.com/ionic-team/ionic/issues/21761)
-* **virtual-scroll:** properly calculate top offset when nested ([#21581](https://github.com/ionic-team/ionic/issues/21581)) ([d297ecb](https://github.com/ionic-team/ionic/commit/d297ecb87ad3e1c8f0988f0571a475081ce368f8))
-
-
-### Features
-
-* **card:** expose global card css variables ([#21756](https://github.com/ionic-team/ionic/issues/21756)) ([096eef4](https://github.com/ionic-team/ionic/commit/096eef4a79c2d05c37eb224466c6d7d512d2be20)), closes [#21694](https://github.com/ionic-team/ionic/issues/21694)
-* **input:** accept datetime-local, month, and week type values ([#21758](https://github.com/ionic-team/ionic/issues/21758)) ([fa93dff](https://github.com/ionic-team/ionic/commit/fa93dffdb4f350e8db8acc7f06b06761974eea8e)), closes [#21757](https://github.com/ionic-team/ionic/issues/21757)
-* **input, textarea:** expose native events for ionBlur and ionFocus ([#21777](https://github.com/ionic-team/ionic/issues/21777)) ([a625c83](https://github.com/ionic-team/ionic/commit/a625c837a60abc07ad71c696196a89f1a25a4c27)), closes [#17363](https://github.com/ionic-team/ionic/issues/17363)
-* **react:** add custom history to IonReactRouter ([#21775](https://github.com/ionic-team/ionic/issues/21775)) ([d4a5fbd](https://github.com/ionic-team/ionic/commit/d4a5fbd955e8ecccba8b77491943d81fdf5a5ef4)), closes [#20297](https://github.com/ionic-team/ionic/issues/20297)
-* **react:** add new react router ([#21693](https://github.com/ionic-team/ionic/issues/21693)) ([c171ccb](https://github.com/ionic-team/ionic/commit/c171ccbd37c1ee4b4934758a3a759170ff357cb2))
-* **router:** add navigation hooks ([#21709](https://github.com/ionic-team/ionic/issues/21709)) ([77464ef](https://github.com/ionic-team/ionic/commit/77464ef21aaaa5afa7a02e5417f3ec295b240601))
-* **segment-button, toast:** expose additional shadow parts ([#21532](https://github.com/ionic-team/ionic/issues/21532)) ([a5e4669](https://github.com/ionic-team/ionic/commit/a5e4669c4bcbcb2cdd605ed17c35e42438bd5596))
-* **select:** add optional generic typings ([#21514](https://github.com/ionic-team/ionic/issues/21514)) ([7c2d0c9](https://github.com/ionic-team/ionic/commit/7c2d0c981ab91930478c4b76220ce4ec4ed4e471))
-
-
-
-## [5.2.3](https://github.com/ionic-team/ionic/compare/v5.2.2...v5.2.3) (2020-07-01)
-
-
-### Bug Fixes
-
-* **angular:** expose createAnimation in addition to AnimationController ([#21616](https://github.com/ionic-team/ionic/issues/21616)) ([a5b3750](https://github.com/ionic-team/ionic/commit/a5b3750ee2a7c005f80f8453b03c67dd1a5622ca)), closes [#21615](https://github.com/ionic-team/ionic/issues/21615)
-* **select:** change role to listbox ([#21609](https://github.com/ionic-team/ionic/issues/21609)) ([8c79e2c](https://github.com/ionic-team/ionic/commit/8c79e2c5b58ad562967f2d559c6b548e57536936))
-* **slides:** enable keyboard integration ([#21608](https://github.com/ionic-team/ionic/issues/21608)) ([26674f1](https://github.com/ionic-team/ionic/commit/26674f1dfa8c9a28f5525f1b16070e8ec494c232)), closes [#21554](https://github.com/ionic-team/ionic/issues/21554)
-* **textarea:** add aria-labelledby to native textarea ([#21606](https://github.com/ionic-team/ionic/issues/21606)) ([88f23b1](https://github.com/ionic-team/ionic/commit/88f23b1626eb400336f2f52a3e0d34ac3c161e64)), closes [#21600](https://github.com/ionic-team/ionic/issues/21600)
-
-
-
-## [5.2.2](https://github.com/ionic-team/ionic/compare/v5.2.1...v5.2.2) (2020-06-17)
-
-
-### Bug Fixes
-
-* **action-sheet, alert:** resolve double click issue when running in iOS mode on chrome ([#21506](https://github.com/ionic-team/ionic/issues/21506)) ([bcccc21](https://github.com/ionic-team/ionic/commit/bcccc217b8833a284a1781e287db5e46043b3548)), closes [#21503](https://github.com/ionic-team/ionic/issues/21503)
-* **angular:** fix issue where navAnimation was being incorrectly overridden ([#21508](https://github.com/ionic-team/ionic/issues/21508)) ([e968bd0](https://github.com/ionic-team/ionic/commit/e968bd029a4fb37b4001d96a490c6091a948785a)), closes [#21495](https://github.com/ionic-team/ionic/issues/21495)
-* **input:** add aria-label to clear button ([#21538](https://github.com/ionic-team/ionic/issues/21538)) ([d8b377f](https://github.com/ionic-team/ionic/commit/d8b377ffeb88eaae23b33eadeae5c8e54e1bc77c)), closes [#21537](https://github.com/ionic-team/ionic/issues/21537)
-* **ios:** respect toolbar opacity when doing nav transition ([#21512](https://github.com/ionic-team/ionic/issues/21512)) ([24cfdc3](https://github.com/ionic-team/ionic/commit/24cfdc308f63b7a55969ac58806eafd67116b017))
-* **segment:** ensure checked classes get set after not having a value ([#21547](https://github.com/ionic-team/ionic/issues/21547)) ([17308f2](https://github.com/ionic-team/ionic/commit/17308f247f8750029ece39548c9f457e15326189)), closes [#21546](https://github.com/ionic-team/ionic/issues/21546)
-
-
 ## [5.2.1](https://github.com/ionic-team/ionic/compare/v5.2.0...v5.2.1) (2020-06-11)
 
 
@@ -360,9 +247,9 @@
 * **modal:** presenting multiple card-style modals now adds border radius properly ([#20476](https://github.com/ionic-team/ionic/issues/20476)) ([abf594a](https://github.com/ionic-team/ionic/commit/abf594aa611562a76e3baecfa38456d41a1410f3)), closes [#20475](https://github.com/ionic-team/ionic/issues/20475)
 * **modal:** prevent card style modal styles from being overridden ([#20470](https://github.com/ionic-team/ionic/issues/20470)) ([86ab77a](https://github.com/ionic-team/ionic/commit/86ab77a6e2cb124510c244110fc78a4bc0654cd1)), closes [#20469](https://github.com/ionic-team/ionic/issues/20469)
 * **react:** do a better job matching up route to sync ([#20446](https://github.com/ionic-team/ionic/issues/20446)) ([c0aadd6](https://github.com/ionic-team/ionic/commit/c0aadd60077e5ba379959d93006e3a9c1418263c)), closes [#20363](https://github.com/ionic-team/ionic/issues/20363)
-* **react:** do not remove pages when navigating between tabs ([#20431](https://github.com/ionic-team/ionic/issues/20431)) ([b6fbe98](https://github.com/ionic-team/ionic/commit/b6fbe98812fbab5ef9e0723802605c0711581dd2)), closes [#20398](https://github.com/ionic-team/ionic/issues/20398)
+* **react:** do not remove pages when navigating between tabs ([#20431](https://github.com/ionic-team/ionic/issues/20431)) ([b6fbe98](https://github.com/ionic-team/ionic/commit/b6fbe98812fbab5ef9e0723802605c0711581dd2)), closes [#20398](https://github.com/ionic-team/ionic/issues/20398) 
 * **react:** icons with MD set should work in browser ([#20463](https://github.com/ionic-team/ionic/issues/20463)) ([82670fe](https://github.com/ionic-team/ionic/commit/82670fe4d0592451cbc243b3008beb3f8f483c30))
-* **react:** update paths of tab buttons when href changes in ion buttons ([#20480](https://github.com/ionic-team/ionic/issues/20480)) ([45d03ba](https://github.com/ionic-team/ionic/commit/45d03baf981d0e10eb1fe689908532adef2ba31d)), closes [#20321](https://github.com/ionic-team/ionic/issues/20321)
+* **react:** update paths of tab buttons when href changes in ion buttons ([#20480](https://github.com/ionic-team/ionic/issues/20480)) ([45d03ba](https://github.com/ionic-team/ionic/commit/45d03baf981d0e10eb1fe689908532adef2ba31d)), closes [#20321](https://github.com/ionic-team/ionic/issues/20321) 
 * **searchbar:** properly align placeholder ([#20460](https://github.com/ionic-team/ionic/issues/20460)) ([4d6e15a](https://github.com/ionic-team/ionic/commit/4d6e15ab18fc894c3826b89362163256adc227f4)), closes [#20456](https://github.com/ionic-team/ionic/issues/20456)
 * **segment:** border radius applies to indicator on ios ([#20541](https://github.com/ionic-team/ionic/issues/20541)) ([9b5854d](https://github.com/ionic-team/ionic/commit/9b5854d79712356f8a3772442c0cc412db09d5e0)), closes [#20539](https://github.com/ionic-team/ionic/issues/20539)
 * **segment:** do not show ripple effect if disabled via config ([#20542](https://github.com/ionic-team/ionic/issues/20542)) ([7a461c5](https://github.com/ionic-team/ionic/commit/7a461c59c5d9a23de0bcdd53397f452d17251fd6)), closes [#20533](https://github.com/ionic-team/ionic/issues/20533)

CODE_OF_CONDUCT.md

@@ -1,129 +1,11 @@
+# Contributor Code of Conduct
 
-# Contributor Covenant Code of Conduct
+As contributors and maintainers of the Ionic project, we pledge to respect everyone who contributes by posting issues, updating documentation, submitting pull requests, providing feedback in comments, and any other activities.
 
-## Our Pledge
+Communication through any of Ionic's channels (GitHub, Slack, Forum, IRC, mailing lists, Twitter, etc.) must be constructive and never resort to personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.
 
-We as members, contributors, and leaders pledge to make participation in our
-community a harassment-free experience for everyone, regardless of age, body
-size, visible or invisible disability, ethnicity, sex characteristics, gender
-identity and expression, level of experience, education, socio-economic status,
-nationality, personal appearance, race, religion, or sexual identity
-and orientation.
+We promise to extend courtesy and respect to everyone involved in this project regardless of gender, gender identity, sexual orientation, disability, age, race, ethnicity, religion, or level of experience. We expect anyone contributing to the Ionic project to do the same.
 
-We pledge to act and interact in ways that contribute to an open, welcoming,
-diverse, inclusive, and healthy community.
+If any member of the community violates this code of conduct, the maintainers of the Ionic project may take action, removing issues, comments, and PRs or blocking accounts as deemed appropriate.
 
-## Our Standards
-
-Examples of behavior that contributes to a positive environment for our
-community include:
-
-* Demonstrating empathy and kindness toward other people
-* Being respectful of differing opinions, viewpoints, and experiences
-* Giving and gracefully accepting constructive feedback
-* Accepting responsibility and apologizing to those affected by our mistakes,
-  and learning from the experience
-* Focusing on what is best not just for us as individuals, but for the
-  overall community
-
-Examples of unacceptable behavior include:
-
-* The use of sexualized language or imagery, and sexual attention or
-  advances of any kind
-* Trolling, insulting or derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or email
-  address, without their explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
-  professional setting
-
-## Enforcement Responsibilities
-
-Community leaders are responsible for clarifying and enforcing our standards of
-acceptable behavior and will take appropriate and fair corrective action in
-response to any behavior that they deem inappropriate, threatening, offensive,
-or harmful.
-
-Community leaders have the right and responsibility to remove, edit, or reject
-comments, commits, code, wiki edits, issues, and other contributions that are
-not aligned to this Code of Conduct, and will communicate reasons for moderation
-decisions when appropriate.
-
-## Scope
-
-This Code of Conduct applies within all community spaces, and also applies when
-an individual is officially representing the community in public spaces.
-Examples of representing our community include using an official e-mail address,
-posting via an official social media account, or acting as an appointed
-representative at an online or offline event.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported to the community leaders responsible for enforcement at
-[contact@ionic.io](mailto:contact@ionic.io).
-All complaints will be reviewed and investigated promptly and fairly.
-
-All community leaders are obligated to respect the privacy and security of the
-reporter of any incident.
-
-## Enforcement Guidelines
-
-Community leaders will follow these Community Impact Guidelines in determining
-the consequences for any action they deem in violation of this Code of Conduct:
-
-### 1. Correction
-
-**Community Impact**: Use of inappropriate language or other behavior deemed
-unprofessional or unwelcome in the community.
-
-**Consequence**: A private, written warning from community leaders, providing
-clarity around the nature of the violation and an explanation of why the
-behavior was inappropriate. A public apology may be requested.
-
-### 2. Warning
-
-**Community Impact**: A violation through a single incident or series
-of actions.
-
-**Consequence**: A warning with consequences for continued behavior. No
-interaction with the people involved, including unsolicited interaction with
-those enforcing the Code of Conduct, for a specified period of time. This
-includes avoiding interactions in community spaces as well as external channels
-like social media. Violating these terms may lead to a temporary or
-permanent ban.
-
-### 3. Temporary Ban
-
-**Community Impact**: A serious violation of community standards, including
-sustained inappropriate behavior.
-
-**Consequence**: A temporary ban from any sort of interaction or public
-communication with the community for a specified period of time. No public or
-private interaction with the people involved, including unsolicited interaction
-with those enforcing the Code of Conduct, is allowed during this period.
-Violating these terms may lead to a permanent ban.
-
-### 4. Permanent Ban
-
-**Community Impact**: Demonstrating a pattern of violation of community
-standards, including sustained inappropriate behavior,  harassment of an
-individual, or aggression toward or disparagement of classes of individuals.
-
-**Consequence**: A permanent ban from any sort of public interaction within
-the community.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage],
-version 2.0, available at
-https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
-
-Community Impact Guidelines were inspired by [Mozilla's code of conduct
-enforcement ladder](https://github.com/mozilla/diversity).
-
-[homepage]: https://www.contributor-covenant.org
-
-For answers to common questions about this code of conduct, see the FAQ at
-https://www.contributor-covenant.org/faq. Translations are available at
-https://www.contributor-covenant.org/translations.
+If you are subject to or witness unacceptable behavior, or have any other concerns, please email us at [hi@ionicframework.com](mailto:hi@ionicframework.com).

README.md

@@ -1,9 +1,9 @@
-# Ionic Framework
+# Ionic
 
-[Ionic Framework](https://ionicframework.com/) is the open-source mobile app development framework that makes it easy to
+[Ionic](https://ionicframework.com/) is the open-source mobile app development framework that makes it easy to
 build top quality native and progressive web apps with web technologies.
 
-Ionic Framework is based on [Web Components](https://www.webcomponents.org/introduction) and comes with many significant performance, usability, and feature improvements over the past versions.
+Ionic is based on [Web Components](https://www.webcomponents.org/introduction) and comes with many significant performance, usability, and feature improvements over the past versions.
 
 
 ### Packages
@@ -31,8 +31,6 @@ Thanks for your interest in contributing! Read up on our guidelines for
 and then look through our issues with a [help wanted](https://github.com/ionic-team/ionic/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22)
 label.
 
-Please note that this project is released with a [Contributor Code of Conduct](https://github.com/ionic-team/ionic/blob/master/CODE_OF_CONDUCT.md). By participating in this project you agree to abide by its terms.
-
 
 ### Examples
 
@@ -42,7 +40,7 @@ It is the perfect starting point for learning and building your own app.
 
 ### Future Goals
 
-As Ionic Framework components migrate to the web component standard, a goal of ours is to have Ionic Framework easily work within all of the popular frameworks.
+As Ionic components migrate to the web component standard, a goal of ours is to have Ionic components easily work within all of the popular frameworks.
 
 ### Earlier Versions
 

angular/.npmrc

@@ -0,0 +1 @@
+package-lock=false

angular/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ionic/angular",
-  "version": "5.3.4",
+  "version": "5.2.1",
   "description": "Angular specific wrappers for @ionic/core",
   "keywords": [
     "ionic",
@@ -42,7 +42,7 @@
     "validate": "npm i && npm run lint && npm run test && npm run build"
   },
   "dependencies": {
-    "@ionic/core": "5.3.4",
+    "@ionic/core": "5.2.1",
     "tslib": "^1.9.3"
   },
   "peerDependencies": {
@@ -67,12 +67,12 @@
     "ng-packagr": "^9.1.5",
     "rollup": "~1.17.0",
     "rollup-plugin-node-resolve": "~5.2.0",
-    "rxjs": "^6.6.2",
-    "tsickle": "^0.39.1",
+    "rxjs": "^6.5.2",
+    "tsickle": "^0.34.0",
     "tslint": "^5.12.1",
     "tslint-ionic-rules": "0.0.21",
     "typescript": "3.4.5",
-    "zone.js": "^0.11.1"
+    "zone.js": "^0.8.28"
   },
   "schematics": "./schematics/collection.json",
   "ngPackage": {

angular/scripts/rollup.config.js

@@ -1,4 +1,4 @@
-import resolve from '@rollup/plugin-node-resolve';
+import resolve from 'rollup-plugin-node-resolve';
 
 export default {
   input: 'build/es2015/core.js',

angular/src/directives/navigation/stack-controller.ts

@@ -127,7 +127,7 @@ export class StackController {
      * Save any custom animation so that navigating
      * back will use this custom animation by default.
      */
-    if (leavingView) {
+    if (animationBuilder !== undefined && leavingView) {
       leavingView.animationBuilder = animationBuilder;
     }
 
@@ -190,16 +190,13 @@ export class StackController {
     if (leavingView) {
       const views = this.getStack(leavingView.stackId);
       const enteringView = views[views.length - 2];
-      const customAnimation = enteringView.animationBuilder;
-
       return this.wait(() => {
         return this.transition(
           enteringView, // entering view
           leavingView, // leaving view
           'back',
           this.canGoBack(2),
-          true,
-          customAnimation
+          true
         );
       });
     }

angular/src/index.ts

@@ -43,7 +43,7 @@ export * from './types/ionic-lifecycle-hooks';
 export { IonicModule } from './ionic-module';
 
 // UTILS
-export { IonicSafeString, getPlatforms, isPlatform, createAnimation } from '@ionic/core';
+export { IonicSafeString, getPlatforms, isPlatform } from '@ionic/core';
 
 // CORE TYPES
-export { Animation, AnimationBuilder, AnimationCallbackOptions, AnimationDirection, AnimationFill, AnimationKeyFrames, AnimationLifecycle, Gesture, GestureConfig, GestureDetail, mdTransitionAnimation, iosTransitionAnimation, NavComponentWithProps } from '@ionic/core';
+export { Animation, AnimationBuilder, AnimationCallbackOptions, AnimationDirection, AnimationFill, AnimationKeyFrames, AnimationLifecycle, Gesture, GestureConfig, GestureDetail, mdTransitionAnimation, iosTransitionAnimation } from '@ionic/core';

angular/test/test-app/.npmrc

@@ -0,0 +1 @@
+package-lock=false

angular/test/test-app/e2e/protractor-ci.conf.js

@@ -1,14 +0,0 @@
-
-// Protractor CI configuration file, see link for more information
-// https://angular.io/guide/testing#configure-cli-for-ci-testing-in-chrome
-
-const config = require('./protractor.conf').config;
-
-config.capabilities = {
-  browserName: 'chrome',
-  chromeOptions: {
-    args: ['--headless', '--no-sandbox', '--window-size=1920,1080']
-  }
-};
-
-exports.config = config;

angular/test/test-app/e2e/protractor.conf.js

@@ -1,4 +1,4 @@
-// @ts-check
+  // @ts-check
 // Protractor configuration file, see link for more information
 // https://github.com/angular/protractor/blob/master/lib/config.ts
 

angular/test/test-app/e2e/src/form.e2e-spec.ts

@@ -31,13 +31,13 @@ describe('form', () => {
       await testStatus('INVALID');
       expect(await getText('#submit')).toEqual('false');
       await testData({
-        datetime: '2010-08-20',
-        select: null,
-        toggle: false,
-        input: '',
-        input2: 'Default Value',
-        checkbox: false,
-        range: 5
+        'datetime': '2010-08-20',
+        'select': null,
+        'toggle': false,
+        'input': '',
+        'input2': 'Default Value',
+        'checkbox': false,
+        'range': 5
       });
     });
 
@@ -49,39 +49,39 @@ describe('form', () => {
       await setProperty('ion-range', 'value', 40);
       await testStatus('VALID');
       await testData({
-        datetime: '2010-08-20',
-        select: 'nes',
-        toggle: false,
-        input: 'Some value',
-        input2: 'Default Value',
-        checkbox: false,
-        range: 40
+        'datetime': '2010-08-20',
+        'select': 'nes',
+        'toggle': false,
+        'input': 'Some value',
+        'input2': 'Default Value',
+        'checkbox': false,
+        'range': 40
       });
     });
 
     it('ion-toggle should change', async () => {
       await element(by.css('form ion-toggle')).click();
       await testData({
-        datetime: '2010-08-20',
-        select: null,
-        toggle: true,
-        input: '',
-        input2: 'Default Value',
-        checkbox: false,
-        range: 5
+        'datetime': '2010-08-20',
+        'select': null,
+        'toggle': true,
+        'input': '',
+        'input2': 'Default Value',
+        'checkbox': false,
+        'range': 5
       });
     });
 
     it('ion-checkbox should change', async () => {
       await element(by.css('ion-checkbox')).click();
       await testData({
-        datetime: '2010-08-20',
-        select: null,
-        toggle: false,
-        input: '',
-        input2: 'Default Value',
-        checkbox: true,
-        range: 5
+        'datetime': '2010-08-20',
+        'select': null,
+        'toggle': false,
+        'input': '',
+        'input2': 'Default Value',
+        'checkbox': true,
+        'range': 5
       });
     });
 
@@ -102,23 +102,23 @@ describe('form', () => {
     it('ion-toggle should change only after blur', async () => {
       await element(by.css('form ion-toggle')).click();
       await testData({
-        datetime: '2010-08-20',
-        select: null,
-        toggle: false,
-        input: '',
-        input2: 'Default Value',
-        checkbox: false,
-        range: 5
+        'datetime': '2010-08-20',
+        'select': null,
+        'toggle': false,
+        'input': '',
+        'input2': 'Default Value',
+        'checkbox': false,
+        'range': 5
       });
       await element(by.css('ion-checkbox')).click();
       await testData({
-        datetime: '2010-08-20',
-        select: null,
-        toggle: true,
-        input: '',
-        input2: 'Default Value',
-        checkbox: false,
-        range: 5
+        'datetime': '2010-08-20',
+        'select': null,
+        'toggle': true,
+        'input': '',
+        'input2': 'Default Value',
+        'checkbox': false,
+        'range': 5
       });
     });
   });

angular/test/test-app/e2e/src/tabs.e2e-spec.ts

@@ -149,7 +149,7 @@ describe('tabs', () => {
 
     it('should set root when clicking on an active tab to navigate to the root', async () => {
       const expectNestedTabUrlToContain = 'search=hello#fragment';
-      const tab = await getSelectedTab() as ElementFinder;
+      let tab = await getSelectedTab() as ElementFinder;
       const initialUrl = await browser.getCurrentUrl();
       await tab.$('#goto-nested-page1-with-query-params').click();
       await testTabTitle('Tab 1 - Page 2 (1)');
@@ -176,7 +176,7 @@ describe('tabs', () => {
     it('should preserve root url navigation extras when clicking on an active tab to navigate to the root', async () => {
       await browser.get(rootUrl);
 
-      const tab = await getSelectedTab() as ElementFinder;
+      let tab = await getSelectedTab() as ElementFinder;
       await tab.$('#goto-nested-page1-with-query-params').click();
       await testTabTitle('Tab 1 - Page 2 (1)');
       await testUrlContains(expectNestedTabUrlToContain);

angular/test/test-app/e2e/src/utils.ts

@@ -37,7 +37,7 @@ export interface LifeCycleCount {
 }
 
 export function handleErrorMessages() {
-  return browser.manage().logs().get('browser').then(browserLog => {
+  return browser.manage().logs().get('browser').then(function (browserLog) {
     for (let i = 0; i <= browserLog.length - 1; i++) {
       if (browserLog[i].level.name_ === 'SEVERE') {
         fail(browserLog[i].message);

angular/test/test-app/karma.conf.js

@@ -26,12 +26,6 @@ module.exports = function (config) {
     logLevel: config.LOG_INFO,
     autoWatch: true,
     browsers: ['Chrome'],
-    customLaunchers: {
-      ChromeHeadlessCI: {
-        base: 'ChromeHeadless',
-        flags: ['--no-sandbox']
-      }
-    },
     singleRun: false,
     restartOnFileChange: true
   });

angular/test/test-app/package.json

@@ -18,49 +18,46 @@
     "prerender": "ng run test-app:prerender"
   },
   "dependencies": {
-    "@angular/animations": "^9.1.12",
-    "@angular/common": "^9.1.12",
-    "@angular/compiler": "^9.1.12",
-    "@angular/core": "^9.1.12",
-    "@angular/forms": "^9.1.12",
-    "@angular/platform-browser": "^9.1.12",
-    "@angular/platform-browser-dynamic": "^9.1.12",
-    "@angular/platform-server": "^9.1.12",
-    "@angular/router": "^9.1.12",
-    "@ionic/angular": "^5.3.1",
-    "@ionic/angular-server": "^5.3.1",
+    "@angular/animations": "^9.0.0-rc.2",
+    "@angular/common": "^9.0.0-rc.2",
+    "@angular/compiler": "^9.0.0-rc.2",
+    "@angular/core": "^9.0.0-rc.2",
+    "@angular/forms": "^9.0.0-rc.2",
+    "@angular/platform-browser": "^9.0.0-rc.2",
+    "@angular/platform-browser-dynamic": "^9.0.0-rc.2",
+    "@angular/platform-server": "^9.0.0-rc.2",
+    "@angular/router": "^9.0.0-rc.2",
+    "@ionic/angular": "^4.7.0",
+    "@ionic/angular-server": "^0.0.2",
     "@nguniversal/express-engine": "9.0.0-next.9",
-    "angular-in-memory-web-api": "^0.11.0",
-    "core-js": "^2.6.11",
+    "core-js": "^2.6.2",
     "express": "^4.15.2",
-    "jasmine-marbles": "^0.6.0",
-    "rxjs": "^6.5.5",
-    "tslib": "^1.13.0",
-    "zone.js": "^0.10.3"
+    "rxjs": "^6.5.3",
+    "tslib": "^1.10.0",
+    "zone.js": "~0.10.2"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "^0.901.12",
-    "@angular/cli": "^9.1.12",
-    "@angular/compiler-cli": "^9.1.12",
-    "@angular/language-service": "^9.1.12",
+    "@angular-devkit/build-angular": "~0.900.0-rc.2",
+    "@angular/cli": "^9.0.0-rc.2",
+    "@angular/compiler-cli": "^9.0.0-rc.2",
+    "@angular/language-service": "^9.0.0-rc.2",
     "@nguniversal/builders": "9.0.0-next.9",
-    "@types/express": "^4.17.7",
-    "@types/jasmine": "^3.5.13",
-    "@types/jasminewd2": "^2.0.8",
-    "@types/node": "^12.12.54",
-    "codelyzer": "^5.2.2",
-    "jasmine-core": "^3.5.0",
-    "jasmine-spec-reporter": "^4.2.1",
-    "karma": "^4.4.1",
-    "karma-chrome-launcher": "^3.1.0",
-    "karma-coverage-istanbul-reporter": "^2.1.1",
-    "karma-jasmine": "^3.0.3",
-    "karma-jasmine-html-reporter": "^1.5.4",
-    "protractor": "^5.4.4",
-    "ts-loader": "^6.2.2",
-    "ts-node": "^8.3.0",
-    "tslint": "^6.1.3",
-    "typescript": "^3.8.3",
-    "webpack-cli": "^3.3.12"
+    "@types/express": "^4.17.0",
+    "@types/jasmine": "3.4.1",
+    "@types/node": "^12.11.1",
+    "codelyzer": "^5.1.2",
+    "jasmine-core": "~3.5.0",
+    "jasmine-spec-reporter": "~4.2.1",
+    "karma": "~4.3.0",
+    "karma-chrome-launcher": "~3.1.0",
+    "karma-coverage-istanbul-reporter": "~2.1.0",
+    "karma-jasmine": "~2.0.1",
+    "karma-jasmine-html-reporter": "^1.4.2",
+    "protractor": "~5.4.2",
+    "ts-loader": "^6.1.2",
+    "ts-node": "8.4.1",
+    "tslint": "~5.18.0",
+    "typescript": "~3.6.4",
+    "webpack-cli": "^3.3.9"
   }
 }

core/.npmrc

@@ -0,0 +1 @@
+package-lock=false

core/CONTRIBUTING.md

@@ -0,0 +1,121 @@
+# Contribution guide
+
+## Contribute to Ionic Core
+
+Ionic Core is the fundation of Ionic v4. It's based in [Stencil](https://stenciljs.com) and consist in a set of web components a long of JS and CSS utils.
+
+
+### Installing dependencies
+
+Before you can build ionic, we assume the following list of software is already installed in your system
+
+- Git
+- Node 8 or higher
+- Npm 6.0 or higher
+
+
+### Fork repository
+
+In order to contributo to Ionic, you must have a github account so you can push code and create a new Pull Request (PR).
+
+Once you are all setup, following the Github's guide of how to fork a repository: https://guides.github.com/activities/forking/
+
+
+### Build Ionic Core
+
+```bash
+# Clone your Github repository:
+git clone https://github.com/<github username>/ionic.git
+
+# Go to the core directory:
+cd ionic/core
+
+# Install npm dependencies
+npm install
+
+# Run Ionic dev server
+npm start
+```
+
+### Development Workflow
+
+#### 1. Run Dev Server
+
+```bash
+# Move to the core folder
+cd core
+
+# Run dev server
+npm start
+```
+
+You should be able to navigate to `http://localhost:3333` which will look like a file browser.
+
+E2E tests are located inside the `src/components` folder, in the following way: `http://localhost:3333/src/components/{COMPONENT}/test/`
+
+
+**Path examples:**
+
+- ActionSheet basic test: http://localhost:3333/src/components/action-sheet/test/basic
+- Nav basic test: http://localhost:3333/src/components/nav/test/basic
+- Button basic test:
+http://localhost:3333/src/components/button/test/basic
+
+
+**IMPORTANT**
+
+Leave the dev server running in the background while you make changes. The dev server listen for changes and automatically recompile Ionic for you.
+
+
+
+#### 2. Open `core` folder in your IDE
+
+Components implementations live inside the `core/src/components` folder.
+
+You can find each ionic component inside their directory.
+
+
+#### 3. Run test suite
+
+Before commiting your changes make sure tests are passing:
+
+```
+npm run validate
+```
+
+#### 4. Create a branch and commit
+
+```bash
+# Create a git branch
+git checkout -b my-improvement
+
+# Add changes
+git add .
+
+# Create commit
+git commit -m "fix(component): message"
+```
+
+Create a PR:
+https://guides.github.com/activities/forking/
+
+
+### Summary
+
+```bash
+# Clone repo
+git clone git@github.com:ionic-team/ionic.git
+
+# Move to ionic/core folder
+cd ionic/core
+
+# Install npm dependencies
+npm i
+
+# Run dev server
+npm start
+
+# Run test suite
+npm run validate
+```
+

core/api.txt

@@ -475,13 +475,13 @@ ion-input,prop,required,boolean,false,false,false
 ion-input,prop,size,number | undefined,undefined,false,false
 ion-input,prop,spellcheck,boolean,false,false,false
 ion-input,prop,step,string | undefined,undefined,false,false
-ion-input,prop,type,"date" | "datetime-local" | "email" | "month" | "number" | "password" | "search" | "tel" | "text" | "time" | "url" | "week",'text',false,false
+ion-input,prop,type,"date" | "email" | "number" | "password" | "search" | "tel" | "text" | "time" | "url",'text',false,false
 ion-input,prop,value,null | number | string | undefined,'',false,false
 ion-input,method,getInputElement,getInputElement() => Promise<HTMLInputElement>
 ion-input,method,setFocus,setFocus() => Promise<void>
-ion-input,event,ionBlur,FocusEvent,true
+ion-input,event,ionBlur,void,true
 ion-input,event,ionChange,InputChangeEventDetail,true
-ion-input,event,ionFocus,FocusEvent,true
+ion-input,event,ionFocus,void,true
 ion-input,event,ionInput,KeyboardEvent,true
 ion-input,css-prop,--background
 ion-input,css-prop,--color
@@ -745,13 +745,13 @@ ion-nav,method,getActive,getActive() => Promise<ViewController | undefined>
 ion-nav,method,getByIndex,getByIndex(index: number) => Promise<ViewController | undefined>
 ion-nav,method,getPrevious,getPrevious(view?: ViewController | undefined) => Promise<ViewController | undefined>
 ion-nav,method,insert,insert<T extends NavComponent>(insertIndex: number, component: T, componentProps?: ComponentProps<T> | null | undefined, opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
-ion-nav,method,insertPages,insertPages(insertIndex: number, insertComponents: NavComponent[] | NavComponentWithProps[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
+ion-nav,method,insertPages,insertPages(insertIndex: number, insertComponents: NavComponent[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
 ion-nav,method,pop,pop(opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
 ion-nav,method,popTo,popTo(indexOrViewCtrl: number | ViewController, opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
 ion-nav,method,popToRoot,popToRoot(opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
 ion-nav,method,push,push<T extends NavComponent>(component: T, componentProps?: ComponentProps<T> | null | undefined, opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
 ion-nav,method,removeIndex,removeIndex(startIndex: number, removeCount?: number, opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
-ion-nav,method,setPages,setPages(views: NavComponent[] | NavComponentWithProps[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
+ion-nav,method,setPages,setPages(views: any[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
 ion-nav,method,setRoot,setRoot<T extends NavComponent>(component: T, componentProps?: ComponentProps<T> | null | undefined, opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>
 ion-nav,event,ionNavDidChange,void,false
 ion-nav,event,ionNavWillChange,void,false
@@ -933,8 +933,6 @@ ion-ripple-effect,prop,type,"bounded" | "unbounded",'bounded',false,false
 ion-ripple-effect,method,addRipple,addRipple(x: number, y: number) => Promise<() => void>
 
 ion-route,none
-ion-route,prop,beforeEnter,(() => boolean | NavigationHookOptions | Promise<NavigationHookResult>) | undefined,undefined,false,false
-ion-route,prop,beforeLeave,(() => boolean | NavigationHookOptions | Promise<NavigationHookResult>) | undefined,undefined,false,false
 ion-route,prop,component,string,undefined,true,false
 ion-route,prop,componentProps,undefined | { [key: string]: any; },undefined,false,false
 ion-route,prop,url,string,'',false,false
@@ -1053,7 +1051,6 @@ ion-segment-button,css-prop,--padding-start
 ion-segment-button,css-prop,--padding-top
 ion-segment-button,css-prop,--transition
 ion-segment-button,part,indicator
-ion-segment-button,part,indicator-background
 ion-segment-button,part,native
 
 ion-select,shadow
@@ -1072,7 +1069,7 @@ ion-select,prop,value,any,undefined,false,false
 ion-select,method,open,open(event?: UIEvent | undefined) => Promise<any>
 ion-select,event,ionBlur,void,true
 ion-select,event,ionCancel,void,true
-ion-select,event,ionChange,SelectChangeEventDetail<any>,true
+ion-select,event,ionChange,SelectChangeEventDetail,true
 ion-select,event,ionFocus,void,true
 ion-select,css-prop,--padding-bottom
 ion-select,css-prop,--padding-end
@@ -1229,9 +1226,9 @@ ion-textarea,prop,value,null | string | undefined,'',false,false
 ion-textarea,prop,wrap,"hard" | "off" | "soft" | undefined,undefined,false,false
 ion-textarea,method,getInputElement,getInputElement() => Promise<HTMLTextAreaElement>
 ion-textarea,method,setFocus,setFocus() => Promise<void>
-ion-textarea,event,ionBlur,FocusEvent,true
+ion-textarea,event,ionBlur,void,true
 ion-textarea,event,ionChange,TextareaChangeEventDetail,true
-ion-textarea,event,ionFocus,FocusEvent,true
+ion-textarea,event,ionFocus,void,true
 ion-textarea,event,ionInput,KeyboardEvent,true
 ion-textarea,css-prop,--background
 ion-textarea,css-prop,--border-radius
@@ -1293,10 +1290,6 @@ ion-toast,css-prop,--min-width
 ion-toast,css-prop,--start
 ion-toast,css-prop,--white-space
 ion-toast,css-prop,--width
-ion-toast,part,button
-ion-toast,part,container
-ion-toast,part,header
-ion-toast,part,message
 
 ion-toggle,shadow
 ion-toggle,prop,checked,boolean,false,false,false

core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ionic/core",
-  "version": "5.3.4",
+  "version": "5.2.1",
   "description": "Base components for Ionic",
   "keywords": [
     "ionic",
@@ -30,38 +30,38 @@
     "loader/"
   ],
   "dependencies": {
-    "ionicons": "^5.1.2",
+    "ionicons": "^5.0.1",
     "tslib": "^1.10.0"
   },
   "devDependencies": {
-    "@rollup/plugin-node-resolve": "^8.4.0",
-    "@rollup/plugin-virtual": "^2.0.3",
-    "@stencil/core": "1.17.3",
-    "@stencil/sass": "1.3.2",
-    "@types/jest": "^26.0.10",
-    "@types/node": "^14.6.0",
-    "@types/puppeteer": "3.0.1",
-    "@types/swiper": "5.4.0",
-    "aws-sdk": "^2.738.0",
+    "@stencil/core": "1.14.0",
+    "@stencil/sass": "1.3.1",
+    "@types/jest": "24.9.1",
+    "@types/node": "12.12.3",
+    "@types/puppeteer": "1.19.1",
+    "@types/swiper": "5.3.1",
+    "aws-sdk": "^2.497.0",
     "clean-css-cli": "^4.1.11",
-    "domino": "^2.1.6",
-    "fs-extra": "^9.0.1",
-    "jest": "^26.4.1",
-    "jest-cli": "^26.4.1",
-    "np": "^6.4.0",
+    "domino": "^2.1.3",
+    "fs-extra": "^8.0.1",
+    "jest": "24.9.0",
+    "jest-cli": "24.9.0",
+    "np": "^5.0.3",
     "pixelmatch": "4.0.2",
-    "puppeteer": "^5.2.1",
-    "rollup": "^2.26.4",
-    "sass": "^1.26.10",
-    "stylelint": "^13.6.1",
-    "stylelint-order": "^4.1.0",
+    "puppeteer": "1.20.0",
+    "rollup": "1.32.0",
+    "rollup-plugin-node-resolve": "5.2.0",
+    "rollup-plugin-virtual": "^1.0.1",
+    "sass": "^1.22.9",
+    "stylelint": "10.1.0",
+    "stylelint-order": "3.0.1",
     "swiper": "5.4.1",
-    "tslint": "^6.1.3",
+    "tslint": "^5.10.0",
     "tslint-ionic-rules": "0.0.21",
-    "tslint-react": "^5.0.0"
+    "tslint-react": "^3.6.0"
   },
   "scripts": {
-    "build": "npm run clean && npm run build.css && npm run build.vendor && stencil build --docs --es5 && npm run cdnloader",
+    "build": "npm run clean && npm run build.css && npm run build.vendor && stencil build --docs && npm run cdnloader",
     "build.vendor": "rollup --config ./scripts/swiper.rollup.config.js",
     "build.css": "npm run css.sass && npm run css.minify",
     "build.debug": "npm run clean && stencil build --debug",

core/scripts/swiper.rollup.config.js

@@ -1,4 +1,4 @@
-import resolve from '@rollup/plugin-node-resolve';
+import resolve from 'rollup-plugin-node-resolve';
 
 export default {
   input: 'src/components/slides/swiper/swiper.js',

core/scripts/treeshaking.js

@@ -1,7 +1,7 @@
 
 const path = require('path');
 const { rollup } = require('rollup');
-const virtual = require('@rollup/plugin-virtual');
+const virtual = require('rollup-plugin-virtual');
 const fs = require('fs');
 
 function main() {

core/src/components.d.ts

@@ -5,9 +5,8 @@
  * It contains typing information for all components that exist in this project.
  */
 import { HTMLStencilElement, JSXBase } from "@stencil/core/internal";
-import { ActionSheetButton, AlertButton, AlertInput, AnimationBuilder, AutocompleteTypes, CheckboxChangeEventDetail, Color, ComponentProps, ComponentRef, DatetimeChangeEventDetail, DatetimeOptions, DomRenderFn, FooterHeightFn, FrameworkDelegate, HeaderFn, HeaderHeightFn, InputChangeEventDetail, ItemHeightFn, ItemRenderFn, ItemReorderEventDetail, MenuChangeEventDetail, NavComponent, NavComponentWithProps, NavOptions, OverlayEventDetail, PickerButton, PickerColumn, RadioGroupChangeEventDetail, RangeChangeEventDetail, RangeValue, RefresherEventDetail, RouteID, RouterDirection, RouterEventDetail, RouterOutletOptions, RouteWrite, ScrollBaseDetail, ScrollDetail, SearchbarChangeEventDetail, SegmentButtonLayout, SegmentChangeEventDetail, SelectChangeEventDetail, SelectInterface, SelectPopoverOption, Side, SpinnerTypes, StyleEventDetail, SwipeGestureHandler, TabBarChangedEventDetail, TabButtonClickEventDetail, TabButtonLayout, TextareaChangeEventDetail, TextFieldTypes, ToastButton, ToggleChangeEventDetail, TransitionDoneFn, TransitionInstruction, ViewController } from "./interface";
+import { ActionSheetButton, AlertButton, AlertInput, AnimationBuilder, AutocompleteTypes, CheckboxChangeEventDetail, Color, ComponentProps, ComponentRef, DatetimeChangeEventDetail, DatetimeOptions, DomRenderFn, FooterHeightFn, FrameworkDelegate, HeaderFn, HeaderHeightFn, InputChangeEventDetail, ItemHeightFn, ItemRenderFn, ItemReorderEventDetail, MenuChangeEventDetail, NavComponent, NavOptions, OverlayEventDetail, PickerButton, PickerColumn, RadioGroupChangeEventDetail, RangeChangeEventDetail, RangeValue, RefresherEventDetail, RouteID, RouterDirection, RouterEventDetail, RouterOutletOptions, RouteWrite, ScrollBaseDetail, ScrollDetail, SearchbarChangeEventDetail, SegmentButtonLayout, SegmentChangeEventDetail, SelectChangeEventDetail, SelectInterface, SelectPopoverOption, Side, SpinnerTypes, StyleEventDetail, SwipeGestureHandler, TabBarChangedEventDetail, TabButtonClickEventDetail, TabButtonLayout, TextareaChangeEventDetail, TextFieldTypes, ToastButton, ToggleChangeEventDetail, TransitionDoneFn, TransitionInstruction, ViewController } from "./interface";
 import { IonicSafeString } from "./utils/sanitization";
-import { NavigationHookCallback } from "./components/route/route-interface";
 import { SelectCompareFn } from "./components/select/select-interface";
 export namespace Components {
     interface IonActionSheet {
@@ -869,10 +868,6 @@ export namespace Components {
           * A hint to the browser for which enter key to display. Possible values: `"enter"`, `"done"`, `"go"`, `"next"`, `"previous"`, `"search"`, and `"send"`.
          */
         "enterkeyhint"?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send';
-        /**
-          * This is required for a WebKit bug which requires us to blur and focus an input to properly focus the input in an item with delegatesFocus. It will no longer be needed with iOS 14.
-         */
-        "fireFocusEvents": boolean;
         /**
           * Returns the native `<input>` element used under the hood.
          */
@@ -926,11 +921,7 @@ export namespace Components {
          */
         "required": boolean;
         /**
-          * Sets blur on the native `input` in `ion-input`. Use this method instead of the global `input.blur()`.
-         */
-        "setBlur": () => Promise<void>;
-        /**
-          * Sets focus on the native `input` in `ion-input`. Use this method instead of the global `input.focus()`.
+          * Sets focus on the specified `ion-input`. Use this method instead of the global `input.focus()`.
          */
         "setFocus": () => Promise<void>;
         /**
@@ -1421,7 +1412,7 @@ export namespace Components {
           * @param opts The navigation options.
           * @param done The transition complete function.
          */
-        "insertPages": (insertIndex: number, insertComponents: NavComponent[] | NavComponentWithProps[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>;
+        "insertPages": (insertIndex: number, insertComponents: NavComponent[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>;
         /**
           * Pop a component off of the navigation stack. Navigates back from the current component.
           * @param opts The navigation options.
@@ -1471,7 +1462,7 @@ export namespace Components {
           * @param opts The navigation options.
           * @param done The transition complete function.
          */
-        "setPages": (views: NavComponent[] | NavComponentWithProps[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>;
+        "setPages": (views: any[], opts?: NavOptions | null | undefined, done?: TransitionDoneFn | undefined) => Promise<boolean>;
         /**
           * Set the root for the current navigation stack to a component.
           * @param component The component to set as the root of the navigation stack.
@@ -1703,8 +1694,6 @@ export namespace Components {
           * The name of the control, which is submitted with the form data.
          */
         "name": string;
-        "setButtonTabindex": (value: number) => Promise<void>;
-        "setFocus": () => Promise<void>;
         /**
           * the value of the radio.
          */
@@ -1860,14 +1849,6 @@ export namespace Components {
         "type": 'bounded' | 'unbounded';
     }
     interface IonRoute {
-        /**
-          * A navigation hook that is fired when the route tries to enter. Returning `true` allows the navigation to proceed, while returning `false` causes it to be cancelled. Returning a `NavigationHookOptions` object causes the router to redirect to the path specified.
-         */
-        "beforeEnter"?: NavigationHookCallback;
-        /**
-          * A navigation hook that is fired when the route tries to leave. Returning `true` allows the navigation to proceed, while returning `false` causes it to be cancelled. Returning a `NavigationHookOptions` object causes the router to redirect to the path specified.
-         */
-        "beforeLeave"?: NavigationHookCallback;
         /**
           * Name of the component to load/select in the navigation outlet (`ion-tabs`, `ion-nav`) when the route matches.  The value of this property is not always the tagname of the component to load, in `ion-tabs` it actually refers to the name of the `ion-tab` to select.
          */
@@ -1896,7 +1877,6 @@ export namespace Components {
           * Go back to previous page in the window.history.
          */
         "back": () => Promise<void>;
-        "canTransition": () => Promise<string | boolean>;
         "navChanged": (direction: RouterDirection) => Promise<boolean>;
         "printDebug": () => Promise<void>;
         /**
@@ -2144,7 +2124,7 @@ export namespace Components {
     }
     interface IonSelectOption {
         /**
-          * If `true`, the user cannot interact with the select option. This property does not apply when `interface="action-sheet"` as `ion-action-sheet` does not allow for disabled buttons.
+          * If `true`, the user cannot interact with the select option.
          */
         "disabled": boolean;
         /**
@@ -2441,10 +2421,6 @@ export namespace Components {
           * A hint to the browser for which enter key to display. Possible values: `"enter"`, `"done"`, `"go"`, `"next"`, `"previous"`, `"search"`, and `"send"`.
          */
         "enterkeyhint"?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send';
-        /**
-          * This is required for a WebKit bug which requires us to blur and focus an input to properly focus the input in an item with delegatesFocus. It will no longer be needed with iOS 14.
-         */
-        "fireFocusEvents": boolean;
         /**
           * Returns the native `<textarea>` element used under the hood.
          */
@@ -2486,11 +2462,7 @@ export namespace Components {
          */
         "rows"?: number;
         /**
-          * Sets blur on the native `textarea` in `ion-textarea`. Use this method instead of the global `textarea.blur()`.
-         */
-        "setBlur": () => Promise<void>;
-        /**
-          * Sets focus on the native `textarea` in `ion-textarea`. Use this method instead of the global `textarea.focus()`.
+          * Sets focus on the specified `ion-textarea`. Use this method instead of the global `input.focus()`.
          */
         "setFocus": () => Promise<void>;
         /**
@@ -4208,10 +4180,6 @@ declare namespace LocalJSX {
           * A hint to the browser for which enter key to display. Possible values: `"enter"`, `"done"`, `"go"`, `"next"`, `"previous"`, `"search"`, and `"send"`.
          */
         "enterkeyhint"?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send';
-        /**
-          * This is required for a WebKit bug which requires us to blur and focus an input to properly focus the input in an item with delegatesFocus. It will no longer be needed with iOS 14.
-         */
-        "fireFocusEvents"?: boolean;
         /**
           * A hint to the browser for which keyboard to display. Possible values: `"none"`, `"text"`, `"tel"`, `"url"`, `"email"`, `"numeric"`, `"decimal"`, and `"search"`.
          */
@@ -4247,7 +4215,7 @@ declare namespace LocalJSX {
         /**
           * Emitted when the input loses focus.
          */
-        "onIonBlur"?: (event: CustomEvent<FocusEvent>) => void;
+        "onIonBlur"?: (event: CustomEvent<void>) => void;
         /**
           * Emitted when the value has changed.
          */
@@ -4255,7 +4223,7 @@ declare namespace LocalJSX {
         /**
           * Emitted when the input has focus.
          */
-        "onIonFocus"?: (event: CustomEvent<FocusEvent>) => void;
+        "onIonFocus"?: (event: CustomEvent<void>) => void;
         /**
           * Emitted when a keyboard input occurred.
          */
@@ -5127,14 +5095,6 @@ declare namespace LocalJSX {
         "type"?: 'bounded' | 'unbounded';
     }
     interface IonRoute {
-        /**
-          * A navigation hook that is fired when the route tries to enter. Returning `true` allows the navigation to proceed, while returning `false` causes it to be cancelled. Returning a `NavigationHookOptions` object causes the router to redirect to the path specified.
-         */
-        "beforeEnter"?: NavigationHookCallback;
-        /**
-          * A navigation hook that is fired when the route tries to leave. Returning `true` allows the navigation to proceed, while returning `false` causes it to be cancelled. Returning a `NavigationHookOptions` object causes the router to redirect to the path specified.
-         */
-        "beforeLeave"?: NavigationHookCallback;
         /**
           * Name of the component to load/select in the navigation outlet (`ion-tabs`, `ion-nav`) when the route matches.  The value of this property is not always the tagname of the component to load, in `ion-tabs` it actually refers to the name of the `ion-tab` to select.
          */
@@ -5461,7 +5421,7 @@ declare namespace LocalJSX {
     }
     interface IonSelectOption {
         /**
-          * If `true`, the user cannot interact with the select option. This property does not apply when `interface="action-sheet"` as `ion-action-sheet` does not allow for disabled buttons.
+          * If `true`, the user cannot interact with the select option.
          */
         "disabled"?: boolean;
         /**
@@ -5748,10 +5708,6 @@ declare namespace LocalJSX {
           * A hint to the browser for which enter key to display. Possible values: `"enter"`, `"done"`, `"go"`, `"next"`, `"previous"`, `"search"`, and `"send"`.
          */
         "enterkeyhint"?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send';
-        /**
-          * This is required for a WebKit bug which requires us to blur and focus an input to properly focus the input in an item with delegatesFocus. It will no longer be needed with iOS 14.
-         */
-        "fireFocusEvents"?: boolean;
         /**
           * A hint to the browser for which keyboard to display. Possible values: `"none"`, `"text"`, `"tel"`, `"url"`, `"email"`, `"numeric"`, `"decimal"`, and `"search"`.
          */
@@ -5775,7 +5731,7 @@ declare namespace LocalJSX {
         /**
           * Emitted when the input loses focus.
          */
-        "onIonBlur"?: (event: CustomEvent<FocusEvent>) => void;
+        "onIonBlur"?: (event: CustomEvent<void>) => void;
         /**
           * Emitted when the input value has changed.
          */
@@ -5783,7 +5739,7 @@ declare namespace LocalJSX {
         /**
           * Emitted when the input has focus.
          */
-        "onIonFocus"?: (event: CustomEvent<FocusEvent>) => void;
+        "onIonFocus"?: (event: CustomEvent<void>) => void;
         /**
           * Emitted when a keyboard input occurred.
          */

core/src/components/action-sheet/action-sheet.tsx

@@ -26,7 +26,6 @@ import { mdLeaveAnimation } from './animations/md.leave';
 export class ActionSheet implements ComponentInterface, OverlayInterface {
 
   presented = false;
-  lastFocus?: HTMLElement;
   animation?: any;
   private wrapperEl?: HTMLElement;
   private groupEl?: HTMLElement;
@@ -118,7 +117,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
     return present(this, 'actionSheetEnter', iosEnterAnimation, mdEnterAnimation);
   }
 
-  connectedCallback() {
+  constructor() {
     prepareOverlay(this.el);
   }
 
@@ -198,7 +197,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
     }
   }
 
-  disconnectedCallback() {
+  componentDidUnload() {
     if (this.gesture) {
       this.gesture.destroy();
       this.gesture = undefined;
@@ -251,10 +250,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
         onIonBackdropTap={this.onBackdropTap}
       >
         <ion-backdrop tappable={this.backdropDismiss}/>
-
-        <div tabindex="0"></div>
-
-        <div class="action-sheet-wrapper ion-overlay-wrapper" role="dialog" ref={el => this.wrapperEl = el}>
+        <div class="action-sheet-wrapper" role="dialog" ref={el => this.wrapperEl = el}>
           <div class="action-sheet-container">
             <div class="action-sheet-group" ref={el => this.groupEl = el}>
               {this.header !== undefined &&
@@ -296,8 +292,6 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
             }
           </div>
         </div>
-
-        <div tabindex="0"></div>
       </Host>
     );
   }

core/src/components/action-sheet/readme.md

@@ -280,19 +280,16 @@ export class ActionSheetExample {
 
 ```html
 <template>
-  <ion-button @click="presentActionSheet">Show Action Sheet</ion-button>
+  <IonVuePage :title="'Action Sheet'">
+    <ion-button @click="presentActionSheet">Show Action Sheet</ion-button>
+  </IonVuePage>
 </template>
 
 <script>
-import { IonButton, actionSheetController } from '@ionic/vue';
-import { defineComponent } from 'vue';
-import { caretForwardCircle, close, heart, trash, share } from 'ionicons/icons';
-
-export default defineComponent({
-  components: { IonButton },
+export default {
   methods: {
-    async presentActionSheet() {
-      const actionSheet = await actionSheetController
+    presentActionSheet() {
+      return this.$ionic.actionSheetController
         .create({
           header: 'Albums',
           cssClass: 'my-custom-class',
@@ -300,117 +297,46 @@ export default defineComponent({
             {
               text: 'Delete',
               role: 'destructive',
-              icon: trash,
+              icon: 'trash',
               handler: () => {
                 console.log('Delete clicked')
               },
             },
             {
               text: 'Share',
-              icon: share,
+              icon: 'share',
               handler: () => {
                 console.log('Share clicked')
               },
             },
             {
               text: 'Play (open modal)',
-              icon: caretForwardCircle,
+              icon: 'caret-forward-circle',
               handler: () => {
                 console.log('Play clicked')
               },
             },
             {
               text: 'Favorite',
-              icon: heart,
+              icon: 'heart',
               handler: () => {
                 console.log('Favorite clicked')
               },
             },
             {
               text: 'Cancel',
-              icon: close,
+              icon: 'close',
               role: 'cancel',
               handler: () => {
                 console.log('Cancel clicked')
               },
             },
           ],
-        });
-      return actionSheet.present();
+        })
+        .then(a => a.present())
     },
   },
-});
-</script>
-```
-
-Developers can also use this component directly in their template:
-
-```html
-<template>
-  <ion-button @click="setOpen(true)">Show Action Sheet</ion-button>
-  <ion-action-sheet
-    :is-open="isOpenRef"
-    header="Albums"
-    css-class="my-custom-class"
-    :buttons="buttons"
-    @onDidDismiss="setOpen(false)"
-  >
-  </ion-action-sheet>
-</template>
-
-<script>
-import { IonActionSheet, IonButton } from '@ionic/vue';
-import { defineComponent, ref } from 'vue';
-import { caretForwardCircle, close, heart, trash, share } from 'ionicons/icons';
-
-export default defineComponent({
-  components: { IonActionSheet, IonButton },
-  setup() {
-    const isOpenRef = ref(false);
-    const setOpen = (state: boolean) => isOpenRef.value = state;
-    const buttons = [
-      {
-        text: 'Delete',
-        role: 'destructive',
-        icon: trash,
-        handler: () => {
-          console.log('Delete clicked')
-        },
-      },
-      {
-        text: 'Share',
-        icon: share,
-        handler: () => {
-          console.log('Share clicked')
-        },
-      },
-      {
-        text: 'Play (open modal)',
-        icon: caretForwardCircle,
-        handler: () => {
-          console.log('Play clicked')
-        },
-      },
-      {
-        text: 'Favorite',
-        icon: heart,
-        handler: () => {
-          console.log('Favorite clicked')
-        },
-      },
-      {
-        text: 'Cancel',
-        icon: close,
-        role: 'cancel',
-        handler: () => {
-          console.log('Cancel clicked')
-        },
-      },
-    ];
-    
-    return { buttons, isOpenRef, setOpen }
-  }
-});
+}
 </script>
 ```
 

core/src/components/action-sheet/test/basic/e2e.ts

@@ -1,40 +1,6 @@
 import { testActionSheet, testActionSheetAlert, testActionSheetBackdrop } from '../test.utils';
-import { newE2EPage } from '@stencil/core/testing';
 
 const DIRECTORY = 'basic';
-const getActiveElementText = async (page) => {
-  const activeElement = await page.evaluateHandle(() => document.activeElement);
-  return await page.evaluate(el => el && el.textContent, activeElement);
-}
-
-test('action-sheet: focus trap', async () => {
-  const page = await newE2EPage({ url: '/src/components/action-sheet/test/basic?ionic:_testing=true' });
-
-  await page.click('#basic');
-  await page.waitForSelector('#basic');
-
-  let actionSheet = await page.find('ion-action-sheet');
-
-  expect(actionSheet).not.toBe(null);
-  await actionSheet.waitForVisible();
-
-  await page.keyboard.press('Tab');
-
-  const activeElementText = await getActiveElementText(page);
-  expect(activeElementText).toEqual('Delete');
-
-  await page.keyboard.down('Shift');
-  await page.keyboard.press('Tab');
-  await page.keyboard.up('Shift');
-
-  const activeElementTextTwo = await getActiveElementText(page);
-  expect(activeElementTextTwo).toEqual('Cancel');
-
-  await page.keyboard.press('Tab');
-
-  const activeElementTextThree = await getActiveElementText(page);
-  expect(activeElementTextThree).toEqual('Delete');
-});
 
 test('action-sheet: basic', async () => {
   await testActionSheet(DIRECTORY, '#basic');

core/src/components/action-sheet/usage/vue.md

@@ -1,18 +1,15 @@
 ```html
 <template>
-  <ion-button @click="presentActionSheet">Show Action Sheet</ion-button>
+  <IonVuePage :title="'Action Sheet'">
+    <ion-button @click="presentActionSheet">Show Action Sheet</ion-button>
+  </IonVuePage>
 </template>
 
 <script>
-import { IonButton, actionSheetController } from '@ionic/vue';
-import { defineComponent } from 'vue';
-import { caretForwardCircle, close, heart, trash, share } from 'ionicons/icons';
-
-export default defineComponent({
-  components: { IonButton },
+export default {
   methods: {
-    async presentActionSheet() {
-      const actionSheet = await actionSheetController
+    presentActionSheet() {
+      return this.$ionic.actionSheetController
         .create({
           header: 'Albums',
           cssClass: 'my-custom-class',
@@ -20,116 +17,45 @@ export default defineComponent({
             {
               text: 'Delete',
               role: 'destructive',
-              icon: trash,
+              icon: 'trash',
               handler: () => {
                 console.log('Delete clicked')
               },
             },
             {
               text: 'Share',
-              icon: share,
+              icon: 'share',
               handler: () => {
                 console.log('Share clicked')
               },
             },
             {
               text: 'Play (open modal)',
-              icon: caretForwardCircle,
+              icon: 'caret-forward-circle',
               handler: () => {
                 console.log('Play clicked')
               },
             },
             {
               text: 'Favorite',
-              icon: heart,
+              icon: 'heart',
               handler: () => {
                 console.log('Favorite clicked')
               },
             },
             {
               text: 'Cancel',
-              icon: close,
+              icon: 'close',
               role: 'cancel',
               handler: () => {
                 console.log('Cancel clicked')
               },
             },
           ],
-        });
-      return actionSheet.present();
+        })
+        .then(a => a.present())
     },
   },
-});
-</script>
-```
-
-Developers can also use this component directly in their template:
-
-```html
-<template>
-  <ion-button @click="setOpen(true)">Show Action Sheet</ion-button>
-  <ion-action-sheet
-    :is-open="isOpenRef"
-    header="Albums"
-    css-class="my-custom-class"
-    :buttons="buttons"
-    @onDidDismiss="setOpen(false)"
-  >
-  </ion-action-sheet>
-</template>
-
-<script>
-import { IonActionSheet, IonButton } from '@ionic/vue';
-import { defineComponent, ref } from 'vue';
-import { caretForwardCircle, close, heart, trash, share } from 'ionicons/icons';
-
-export default defineComponent({
-  components: { IonActionSheet, IonButton },
-  setup() {
-    const isOpenRef = ref(false);
-    const setOpen = (state: boolean) => isOpenRef.value = state;
-    const buttons = [
-      {
-        text: 'Delete',
-        role: 'destructive',
-        icon: trash,
-        handler: () => {
-          console.log('Delete clicked')
-        },
-      },
-      {
-        text: 'Share',
-        icon: share,
-        handler: () => {
-          console.log('Share clicked')
-        },
-      },
-      {
-        text: 'Play (open modal)',
-        icon: caretForwardCircle,
-        handler: () => {
-          console.log('Play clicked')
-        },
-      },
-      {
-        text: 'Favorite',
-        icon: heart,
-        handler: () => {
-          console.log('Favorite clicked')
-        },
-      },
-      {
-        text: 'Cancel',
-        icon: close,
-        role: 'cancel',
-        handler: () => {
-          console.log('Cancel clicked')
-        },
-      },
-    ];
-    
-    return { buttons, isOpenRef, setOpen }
-  }
-});
+}
 </script>
 ```

core/src/components/alert/alert-interface.ts

@@ -36,7 +36,6 @@ export interface AlertInput {
   max?: string | number;
   cssClass?: string | string[];
   attributes?: AlertInputAttributes | AlertTextareaAttributes;
-  tabindex?: number;
 }
 
 export interface AlertTextareaAttributes extends JSXBase.TextareaHTMLAttributes<HTMLTextAreaElement> {}

core/src/components/alert/alert.tsx

@@ -1,4 +1,4 @@
-import { Component, ComponentInterface, Element, Event, EventEmitter, Host, Listen, Method, Prop, Watch, forceUpdate, h } from '@stencil/core';
+import { Component, ComponentInterface, Element, Event, EventEmitter, Host, Method, Prop, Watch, forceUpdate, h } from '@stencil/core';
 
 import { getIonMode } from '../../global/ionic-global';
 import { AlertButton, AlertInput, AlertInputAttributes, AlertTextareaAttributes, AnimationBuilder, CssClassMap, OverlayEventDetail, OverlayInterface } from '../../interface';
@@ -34,7 +34,6 @@ export class Alert implements ComponentInterface, OverlayInterface {
   private gesture?: Gesture;
 
   presented = false;
-  lastFocus?: HTMLElement;
 
   @Element() el!: HTMLIonAlertElement;
 
@@ -130,59 +129,6 @@ export class Alert implements ComponentInterface, OverlayInterface {
    */
   @Event({ eventName: 'ionAlertDidDismiss' }) didDismiss!: EventEmitter<OverlayEventDetail>;
 
-  @Listen('keydown', { target: 'document' })
-  onKeydown(ev: any) {
-    const inputTypes = new Set(this.processedInputs.map(i => i.type));
-
-    // The only inputs we want to navigate between using arrow keys are the radios
-    // ignore the keydown event if it is not on a radio button
-    if (
-      !inputTypes.has('radio')
-      || (ev.target && !this.el.contains(ev.target))
-      || ev.target.classList.contains('alert-button'))
-    {
-      return;
-    }
-
-    // Get all radios inside of the radio group and then
-    // filter out disabled radios since we need to skip those
-    const query = this.el.querySelectorAll('.alert-radio') as NodeListOf<HTMLButtonElement>;
-    const radios = Array.from(query).filter(radio => !radio.disabled);
-
-    // The focused radio is the one that shares the same id as
-    // the event target
-    const index = radios.findIndex(radio => radio.id === ev.target.id);
-
-    // We need to know what the next radio element should
-    // be in order to change the focus
-    let nextEl: HTMLButtonElement | undefined;
-
-    // If hitting arrow down or arrow right, move to the next radio
-    // If we're on the last radio, move to the first radio
-    if (['ArrowDown', 'ArrowRight'].includes(ev.key)) {
-      nextEl = (index === radios.length - 1)
-        ? radios[0]
-        : radios[index + 1];
-    }
-
-    // If hitting arrow up or arrow left, move to the previous radio
-    // If we're on the first radio, move to the last radio
-    if (['ArrowUp', 'ArrowLeft'].includes(ev.key)) {
-      nextEl = (index === 0)
-        ? radios[radios.length - 1]
-        : radios[index - 1]
-    }
-
-    if (nextEl && radios.includes(nextEl)) {
-      const nextProcessed = this.processedInputs.find(input => input.id === nextEl?.id);
-
-      if (nextProcessed) {
-        this.rbClick(nextProcessed);
-        nextEl.focus();
-      }
-    }
-  }
-
   @Watch('buttons')
   buttonsChanged() {
     const buttons = this.buttons;
@@ -197,21 +143,12 @@ export class Alert implements ComponentInterface, OverlayInterface {
   inputsChanged() {
     const inputs = this.inputs;
 
-    // Get the first input that is not disabled and the checked one
-    // If an enabled checked input exists, set it to be the focusable input
-    // otherwise we default to focus the first input
-    // This will only be used when the input is type radio
-    const first = inputs.find(input => !input.disabled);
-    const checked = inputs.find(input => input.checked && !input.disabled);
-    const focusable = checked || first;
-
     // An alert can be created with several different inputs. Radios,
     // checkboxes and inputs are all accepted, but they cannot be mixed.
     const inputTypes = new Set(inputs.map(i => i.type));
     if (inputTypes.has('checkbox') && inputTypes.has('radio')) {
       console.warn(`Alert cannot mix input types: ${(Array.from(inputTypes.values()).join('/'))}. Please see alert docs for more info.`);
     }
-
     this.inputType = inputTypes.values().next().value;
     this.processedInputs = inputs.map((i, index) => ({
       type: i.type || 'text',
@@ -227,11 +164,10 @@ export class Alert implements ComponentInterface, OverlayInterface {
       max: i.max,
       cssClass: i.cssClass || '',
       attributes: i.attributes || {},
-      tabindex: (i.type === 'radio' && i !== focusable) ? -1 : 0
     }) as AlertInput);
   }
 
-  connectedCallback() {
+  constructor() {
     prepareOverlay(this.el);
   }
 
@@ -240,7 +176,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
     this.buttonsChanged();
   }
 
-  disconnectedCallback() {
+  componentDidUnload() {
     if (this.gesture) {
       this.gesture.destroy();
       this.gesture = undefined;
@@ -304,7 +240,6 @@ export class Alert implements ComponentInterface, OverlayInterface {
   private rbClick(selectedInput: AlertInput) {
     for (const input of this.processedInputs) {
       input.checked = input === selectedInput;
-      input.tabindex = input === selectedInput ? 0 : -1;
     }
     this.activeId = selectedInput.id;
     safeCall(selectedInput.handler, selectedInput);
@@ -397,7 +332,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
             aria-checked={`${i.checked}`}
             id={i.id}
             disabled={i.disabled}
-            tabIndex={i.tabindex}
+            tabIndex={0}
             role="checkbox"
             class={{
               ...getClassMap(i.cssClass),
@@ -437,7 +372,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
             aria-checked={`${i.checked}`}
             disabled={i.disabled}
             id={i.id}
-            tabIndex={i.tabindex}
+            tabIndex={0}
             class={{
               ...getClassMap(i.cssClass),
               'alert-radio-button': true,
@@ -475,7 +410,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
                   placeholder={i.placeholder}
                   value={i.value}
                   id={i.id}
-                  tabIndex={i.tabindex}
+                  tabIndex={0}
                   {...i.attributes as AlertTextareaAttributes}
                   disabled={i.attributes?.disabled ?? i.disabled}
                   class={inputClass(i)}
@@ -496,7 +431,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
                   max={i.max}
                   value={i.value}
                   id={i.id}
-                  tabIndex={i.tabindex}
+                  tabIndex={0}
                   {...i.attributes as AlertInputAttributes}
                   disabled={i.attributes?.disabled ?? i.disabled}
                   class={inputClass(i)}
@@ -579,9 +514,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
 
         <ion-backdrop tappable={this.backdropDismiss}/>
 
-        <div tabindex="0"></div>
-
-        <div class="alert-wrapper ion-overlay-wrapper" ref={el => this.wrapperEl = el}>
+        <div class="alert-wrapper" ref={el => this.wrapperEl = el}>
 
           <div class="alert-head">
             {header && <h2 id={hdrId} class="alert-title">{header}</h2>}
@@ -594,8 +527,6 @@ export class Alert implements ComponentInterface, OverlayInterface {
           {this.renderAlertButtons()}
 
         </div>
-
-        <div tabindex="0"></div>
       </Host>
     );
   }

core/src/components/alert/readme.md

@@ -1155,47 +1155,45 @@ export class AlertExample {
 
 ```html
 <template>
-  <ion-button @click="presentAlert">Show Alert</ion-button>
-  <ion-button @click="presentAlertMultipleButtons">Show Alert (multiple buttons)</ion-button>
-  <ion-button @click="presentAlertConfirm">Show Alert (confirm)</ion-button>
-  <ion-button @click="presentAlertPrompt">Show Alert (prompt)</ion-button>
-  <ion-button @click="presentAlertRadio">Show Alert (radio)</ion-button>
-  <ion-button @click="presentAlertCheckbox">Show Alert (checkbox)</ion-button>
+  <IonVuePage :title="'Alert'">
+    <ion-button @click="presentAlert">Show Alert</ion-button>
+    <ion-button @click="presentAlertMultipleButtons">Show Alert (multiple buttons)</ion-button>
+    <ion-button @click="presentAlertConfirm">Show Alert (confirm)</ion-button>
+    <ion-button @click="presentAlertPrompt">Show Alert (prompt)</ion-button>
+    <ion-button @click="presentAlertRadio">Show Alert (radio)</ion-button>
+    <ion-button @click="presentAlertCheckbox">Show Alert (checkbox)</ion-button>
+  </IonVuePage>
 </template>
 
 <script>
-import { IonButton, alertController } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonButton },
+export default {
   methods: {
-    async presentAlert() {
-      const alert = await alertController
+    presentAlert() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Alert',
           subHeader: 'Subtitle',
           message: 'This is an alert message.',
           buttons: ['OK'],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertMultipleButtons() {
-      const alert = await alertController
+    presentAlertMultipleButtons() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Alert',
           subHeader: 'Subtitle',
           message: 'This is an alert message.',
           buttons: ['Cancel', 'Open Modal', 'Delete'],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertConfirm() {
-      const alert = await alertController
+    presentAlertConfirm() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Confirm!',
@@ -1216,12 +1214,12 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertPrompt() {
-      const alert = await alertController
+    presentAlertPrompt() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Prompt!',
@@ -1290,12 +1288,12 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertRadio() {
-      const alert = await alertController
+    presentAlertRadio() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Radio',
@@ -1348,12 +1346,12 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertCheckbox() {
-      const alert = await alertController
+    presentAlertCheckbox() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Checkbox',
@@ -1411,45 +1409,11 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
   },
-});
-</script>
-```
-
-Developers can also use this component directly in their template:
-
-```html
-<template>
-  <ion-button @click="setOpen(true)">Show Alert</ion-button>
-  <ion-alert
-    :is-open="isOpenRef"
-    header="Alert"
-    sub-header="Subtitle"
-    message="This is an alert message."
-    css-class="my-custom-class"
-    :buttons="buttons"
-    @onDidDismiss="setOpen(false)"
-  >
-  </ion-alert>
-</template>
-
-<script>
-import { IonAlert, IonButton } from '@ionic/vue';
-import { defineComponent, ref } from 'vue';
-
-export default defineComponent({
-  components: { IonAlert, IonButton },
-  setup() {
-    const isOpenRef = ref(false);
-    const setOpen = (state: boolean) => isOpenRef.value = state;
-    const buttons = ['Ok'];
-    
-    return { buttons, isOpenRef, setOpen }
-  }
-});
+}
 </script>
 ```
 

core/src/components/alert/test/basic/e2e.ts

@@ -1,40 +1,6 @@
 import { testAlert } from '../test.utils';
-import { newE2EPage } from '@stencil/core/testing';
 
 const DIRECTORY = 'basic';
-const getActiveElementText = async (page) => {
-  const activeElement = await page.evaluateHandle(() => document.activeElement);
-  return await page.evaluate(el => el && el.textContent, activeElement);
-}
-
-test('alert: focus trap', async () => {
-  const page = await newE2EPage({ url: '/src/components/alert/test/basic?ionic:_testing=true' });
-
-  await page.click('#multipleButtons');
-  await page.waitForSelector('#multipleButtons');
-
-  let alert = await page.find('ion-alert');
-
-  expect(alert).not.toBe(null);
-  await alert.waitForVisible();
-
-  await page.keyboard.press('Tab');
-
-  const activeElementText = await getActiveElementText(page);
-  expect(activeElementText).toEqual('Open Modal');
-
-  await page.keyboard.down('Shift');
-  await page.keyboard.press('Tab');
-  await page.keyboard.up('Shift');
-
-  const activeElementTextTwo = await getActiveElementText(page);
-  expect(activeElementTextTwo).toEqual('Cancel');
-
-  await page.keyboard.press('Tab');
-
-  const activeElementTextThree = await getActiveElementText(page);
-  expect(activeElementTextThree).toEqual('Open Modal');
-});
 
 test(`alert: basic`, async () => {
   await testAlert(DIRECTORY, '#basic');

core/src/components/alert/test/basic/index.html

@@ -206,6 +206,7 @@
             type: 'radio',
             label: 'Radio 1',
             value: 'value1',
+            checked: true
           },
           {
             type: 'radio',
@@ -215,8 +216,7 @@
           {
             type: 'radio',
             label: 'Radio 3',
-            value: 'value3',
-            checked: true
+            value: 'value3'
           },
           {
             type: 'radio',
@@ -241,12 +241,12 @@
             role: 'cancel',
             cssClass: 'secondary',
             handler: () => {
-              console.log('Confirm Cancel');
+              console.log('Confirm Cancel')
             }
           }, {
             text: 'Ok',
-            handler: (ev) => {
-              console.log('Confirm Ok', ev);
+            handler: () => {
+              console.log('Confirm Ok')
             }
           }
         ]

core/src/components/alert/usage/vue.md

@@ -1,46 +1,44 @@
 ```html
 <template>
-  <ion-button @click="presentAlert">Show Alert</ion-button>
-  <ion-button @click="presentAlertMultipleButtons">Show Alert (multiple buttons)</ion-button>
-  <ion-button @click="presentAlertConfirm">Show Alert (confirm)</ion-button>
-  <ion-button @click="presentAlertPrompt">Show Alert (prompt)</ion-button>
-  <ion-button @click="presentAlertRadio">Show Alert (radio)</ion-button>
-  <ion-button @click="presentAlertCheckbox">Show Alert (checkbox)</ion-button>
+  <IonVuePage :title="'Alert'">
+    <ion-button @click="presentAlert">Show Alert</ion-button>
+    <ion-button @click="presentAlertMultipleButtons">Show Alert (multiple buttons)</ion-button>
+    <ion-button @click="presentAlertConfirm">Show Alert (confirm)</ion-button>
+    <ion-button @click="presentAlertPrompt">Show Alert (prompt)</ion-button>
+    <ion-button @click="presentAlertRadio">Show Alert (radio)</ion-button>
+    <ion-button @click="presentAlertCheckbox">Show Alert (checkbox)</ion-button>
+  </IonVuePage>
 </template>
 
 <script>
-import { IonButton, alertController } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonButton },
+export default {
   methods: {
-    async presentAlert() {
-      const alert = await alertController
+    presentAlert() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Alert',
           subHeader: 'Subtitle',
           message: 'This is an alert message.',
           buttons: ['OK'],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertMultipleButtons() {
-      const alert = await alertController
+    presentAlertMultipleButtons() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Alert',
           subHeader: 'Subtitle',
           message: 'This is an alert message.',
           buttons: ['Cancel', 'Open Modal', 'Delete'],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertConfirm() {
-      const alert = await alertController
+    presentAlertConfirm() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Confirm!',
@@ -61,12 +59,12 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertPrompt() {
-      const alert = await alertController
+    presentAlertPrompt() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Prompt!',
@@ -135,12 +133,12 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertRadio() {
-      const alert = await alertController
+    presentAlertRadio() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Radio',
@@ -193,12 +191,12 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
 
-    async presentAlertCheckbox() {
-      const alert = await alertController
+    presentAlertCheckbox() {
+      return this.$ionic.alertController
         .create({
           cssClass: 'my-custom-class',
           header: 'Checkbox',
@@ -256,44 +254,10 @@ export default defineComponent({
               },
             },
           ],
-        });
-      return alert.present();
+        })
+        .then(a => a.present())
     },
   },
-});
-</script>
-```
-
-Developers can also use this component directly in their template:
-
-```html
-<template>
-  <ion-button @click="setOpen(true)">Show Alert</ion-button>
-  <ion-alert
-    :is-open="isOpenRef"
-    header="Alert"
-    sub-header="Subtitle"
-    message="This is an alert message."
-    css-class="my-custom-class"
-    :buttons="buttons"
-    @onDidDismiss="setOpen(false)"
-  >
-  </ion-alert>
-</template>
-
-<script>
-import { IonAlert, IonButton } from '@ionic/vue';
-import { defineComponent, ref } from 'vue';
-
-export default defineComponent({
-  components: { IonAlert, IonButton },
-  setup() {
-    const isOpenRef = ref(false);
-    const setOpen = (state: boolean) => isOpenRef.value = state;
-    const buttons = ['Ok'];
-    
-    return { buttons, isOpenRef, setOpen }
-  }
-});
+}
 </script>
 ```

core/src/components/avatar/readme.md

@@ -120,15 +120,6 @@ export class AvatarExample {
     <ion-label>Item Avatar</ion-label>
   </ion-item>
 </template>
-
-<script>
-import { IonAvatar, IonChip, IonItem, IonLabel } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonAvatar, IonChip, IonItem, IonLabel }
-});
-</script>
 ```
 
 

core/src/components/avatar/usage/vue.md

@@ -18,13 +18,4 @@
     <ion-label>Item Avatar</ion-label>
   </ion-item>
 </template>
-
-<script>
-import { IonAvatar, IonChip, IonItem, IonLabel } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonAvatar, IonChip, IonItem, IonLabel }
-});
-</script>
 ```

core/src/components/back-button/back-button.tsx

@@ -40,7 +40,7 @@ export class BackButton implements ComponentInterface, ButtonInterface {
   /**
    * If `true`, the user cannot interact with the button.
    */
-  @Prop({ reflect: true }) disabled = false;
+  @Prop({ reflectToAttr: true }) disabled = false;
 
   /**
    * The icon name to use for the back button.
@@ -122,8 +122,10 @@ export class BackButton implements ComponentInterface, ButtonInterface {
     return (
       <Host
         onClick={this.onClick}
-        class={createColorClasses(color, {
+        class={{
+          ...createColorClasses(color),
           [mode]: true,
+
           'button': true, // ion-buttons target .button
           'back-button-disabled': disabled,
           'back-button-has-icon-only': hasIconOnly,
@@ -132,7 +134,7 @@ export class BackButton implements ComponentInterface, ButtonInterface {
           'ion-activatable': true,
           'ion-focusable': true,
           'show-back-button': showBackButton
-        })}
+        }}
       >
         <button
           type={type}

core/src/components/back-button/readme.md

@@ -295,15 +295,6 @@ export class BackButtonExample {
     </ion-toolbar>
   </ion-header>
 </template>
-
-<script>
-import { IonButtons, IonHeader, IonMenuButton, IonToolbar } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonButtons, IonHeader, IonMenuButton, IonToolbar }
-});
-</script>
 ```
 
 

core/src/components/back-button/usage/vue.md

@@ -49,13 +49,4 @@
     </ion-toolbar>
   </ion-header>
 </template>
-
-<script>
-import { IonButtons, IonHeader, IonMenuButton, IonToolbar } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonButtons, IonHeader, IonMenuButton, IonToolbar }
-});
-</script>
 ```

core/src/components/backdrop/readme.md

@@ -164,20 +164,15 @@ export class BackdropExample {
   </ion-backdrop>
 </template>
 
-<script>
-import { IonBackdrop } from '@ionic/vue';
-import { defineComponent } from 'vue';
+<script lang="ts">
+  import { Component, Vue } from 'vue-property-decorator';
 
-export default defineComponent({
-  components: { IonBackdrop },
-  setup() {
-    return {
-      enableBackdropDismiss: true,
-      showBackdrop: true,
-      shouldPropagate: true
-    }
+  @Component()
+  export default class Example extends Vue {
+    enableBackdropDismiss = false;
+    showBackdrop = false;
+    shouldPropagate = false;
   }
-});
 </script>
 ```
 

core/src/components/backdrop/usage/vue.md

@@ -20,19 +20,14 @@
   </ion-backdrop>
 </template>
 
-<script>
-import { IonBackdrop } from '@ionic/vue';
-import { defineComponent } from 'vue';
+<script lang="ts">
+  import { Component, Vue } from 'vue-property-decorator';
 
-export default defineComponent({
-  components: { IonBackdrop },
-  setup() {
-    return {
-      enableBackdropDismiss: true,
-      showBackdrop: true,
-      shouldPropagate: true
-    }
+  @Component()
+  export default class Example extends Vue {
+    enableBackdropDismiss = false;
+    showBackdrop = false;
+    shouldPropagate = false;
   }
-});
 </script>
 ```

core/src/components/badge/badge.tsx

@@ -27,9 +27,10 @@ export class Badge implements ComponentInterface {
     const mode = getIonMode(this);
     return (
       <Host
-        class={createColorClasses(this.color, {
+        class={{
+          ...createColorClasses(this.color),
           [mode]: true,
-        })}
+        }}
       >
         <slot></slot>
       </Host>

core/src/components/badge/readme.md

@@ -130,15 +130,6 @@ export class BadgeExample {
     <ion-badge slot="end">22</ion-badge>
   </ion-item>
 </template>
-
-<script>
-import { IonBadge, IonItem, IonLabel } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonBadge, IonItem, IonLabel }
-});
-</script>
 ```
 
 

core/src/components/badge/usage/vue.md

@@ -21,13 +21,4 @@
     <ion-badge slot="end">22</ion-badge>
   </ion-item>
 </template>
-
-<script>
-import { IonBadge, IonItem, IonLabel } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonBadge, IonItem, IonLabel }
-});
-</script>
 ```

core/src/components/button/button.tsx

@@ -46,20 +46,20 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
   /**
    * If `true`, the user cannot interact with the button.
    */
-  @Prop({ reflect: true }) disabled = false;
+  @Prop({ reflectToAttr: true }) disabled = false;
 
   /**
    * Set to `"block"` for a full-width button or to `"full"` for a full-width button
    * without left and right borders.
    */
-  @Prop({ reflect: true }) expand?: 'full' | 'block';
+  @Prop({ reflectToAttr: true }) expand?: 'full' | 'block';
 
   /**
    * Set to `"clear"` for a transparent button, to `"outline"` for a transparent
    * button with a border, or to `"solid"`. The default style is `"solid"` except inside of
    * a toolbar, where the default is `"clear"`.
    */
-  @Prop({ reflect: true, mutable: true }) fill?: 'clear' | 'outline' | 'solid' | 'default';
+  @Prop({ reflectToAttr: true, mutable: true }) fill?: 'clear' | 'outline' | 'solid' | 'default';
 
   /**
    * When using a router, it specifies the transition direction when navigating to
@@ -96,12 +96,12 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
   /**
    * The button shape.
    */
-  @Prop({ reflect: true }) shape?: 'round';
+  @Prop({ reflectToAttr: true }) shape?: 'round';
 
   /**
    * The button size.
    */
-  @Prop({ reflect: true }) size?: 'small' | 'default' | 'large';
+  @Prop({ reflectToAttr: true }) size?: 'small' | 'default' | 'large';
 
   /**
    * If `true`, activates a button with a heavier font weight.
@@ -204,7 +204,8 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
       <Host
         onClick={this.handleClick}
         aria-disabled={disabled ? 'true' : null}
-        class={createColorClasses(color, {
+        class={{
+          ...createColorClasses(color),
           [mode]: true,
           [buttonType]: true,
           [`${buttonType}-${expand}`]: expand !== undefined,
@@ -218,7 +219,7 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
           'button-disabled': disabled,
           'ion-activatable': true,
           'ion-focusable': true,
-        })}
+        }}
       >
         <TagType
           {...attrs}

core/src/components/button/readme.md

@@ -274,15 +274,6 @@ export class ButtonExample {
   <ion-button>Default</ion-button>
   <ion-button size="small">Small</ion-button>
 </template>
-
-<script>
-import { IonButton } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonButton }
-});
-</script>
 ```
 
 

core/src/components/button/usage/vue.md

@@ -49,13 +49,4 @@
   <ion-button>Default</ion-button>
   <ion-button size="small">Small</ion-button>
 </template>
-
-<script>
-import { IonButton } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonButton }
-});
-</script>
 ```

core/src/components/buttons/readme.md

@@ -260,10 +260,10 @@ export class ButtonsExample {
   <ion-toolbar>
     <ion-buttons slot="secondary">
       <ion-button>
-        <ion-icon slot="icon-only" :icon="personCircle"></ion-icon>
+        <ion-icon slot="icon-only" name="person-circle"></ion-icon>
       </ion-button>
       <ion-button>
-        <ion-icon slot="icon-only" :icon="search"></ion-icon>
+        <ion-icon slot="icon-only" name="search"></ion-icon>
       </ion-button>
     </ion-buttons>
     <ion-title>Default Buttons</ion-title>
@@ -295,22 +295,6 @@ export class ButtonsExample {
     <ion-title>Collapsible Buttons</ion-title>
   </ion-toolbar>
 </template>
-
-<script>
-import { IonBackButton, IonButton, IonButtons, IonIcon, IonMenuButton, IonTitle, IonToolbar } from '@ionic/vue';
-import { personCircle, search } from 'ionicons/icons';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonBackButton, IonButton, IonButtons, IonIcon, IonMenuButton, IonTitle, IonToolbar },
-  setup() {
-    const clickedStar = () => {
-      console.log('Star clicked!');
-    }
-    return { personCircle, search, clickedStar };
-  }
-});
-</script>
 ```
 
 

core/src/components/buttons/usage/vue.md

@@ -10,10 +10,10 @@
   <ion-toolbar>
     <ion-buttons slot="secondary">
       <ion-button>
-        <ion-icon slot="icon-only" :icon="personCircle"></ion-icon>
+        <ion-icon slot="icon-only" name="person-circle"></ion-icon>
       </ion-button>
       <ion-button>
-        <ion-icon slot="icon-only" :icon="search"></ion-icon>
+        <ion-icon slot="icon-only" name="search"></ion-icon>
       </ion-button>
     </ion-buttons>
     <ion-title>Default Buttons</ion-title>
@@ -45,20 +45,4 @@
     <ion-title>Collapsible Buttons</ion-title>
   </ion-toolbar>
 </template>
-
-<script>
-import { IonBackButton, IonButton, IonButtons, IonIcon, IonMenuButton, IonTitle, IonToolbar } from '@ionic/vue';
-import { personCircle, search } from 'ionicons/icons';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonBackButton, IonButton, IonButtons, IonIcon, IonMenuButton, IonTitle, IonToolbar },
-  setup() {
-    const clickedStar = () => {
-      console.log('Star clicked!');
-    }
-    return { personCircle, search, clickedStar };
-  }
-});
-</script>
 ```

core/src/components/card-header/card-header.tsx

@@ -34,11 +34,12 @@ export class CardHeader implements ComponentInterface {
     const mode = getIonMode(this);
     return (
       <Host
-        class={createColorClasses(this.color, {
+        class={{
+          ...createColorClasses(this.color),
           'card-header-translucent': this.translucent,
           'ion-inherit-color': true,
           [mode]: true
-        })}
+        }}
       >
         <slot></slot>
       </Host>

core/src/components/card-subtitle/card-subtitle.tsx

@@ -29,10 +29,11 @@ export class CardSubtitle implements ComponentInterface {
       <Host
         role="heading"
         aria-level="3"
-        class={createColorClasses(this.color, {
+        class={{
+          ...createColorClasses(this.color),
           'ion-inherit-color': true,
           [mode]: true
-        })}
+        }}
       >
         <slot></slot>
       </Host>

core/src/components/card-title/card-title.tsx

@@ -29,10 +29,11 @@ export class CardTitle implements ComponentInterface {
       <Host
         role="heading"
         aria-level="2"
-        class={createColorClasses(this.color, {
+        class={{
+          ...createColorClasses(this.color),
           'ion-inherit-color': true,
           [mode]: true
-        })}
+        }}
       >
         <slot></slot>
       </Host>

core/src/components/card/card.ios.scss

@@ -5,8 +5,8 @@
 // --------------------------------------------------
 
 :host {
-  --background: #{$card-ios-background};
-  --color: #{$card-ios-color};
+  --background: #{$item-ios-background};
+  --color: #{$card-ios-text-color};
 
   @include margin($card-ios-margin-top, $card-ios-margin-end, $card-ios-margin-bottom, $card-ios-margin-start);
   @include border-radius($card-ios-border-radius);
@@ -22,4 +22,4 @@
 
 :host(.ion-activated) {
   transform: #{$card-ios-transform-activated};
-}
+}

core/src/components/card/card.ios.vars.scss

@@ -15,6 +15,9 @@ $card-ios-margin-bottom:               $card-ios-margin-top !default;
 /// @prop - Margin start of the card
 $card-ios-margin-start:                16px !default;
 
+/// @prop - Background color of the card
+$card-ios-background-color:            $item-ios-background !default;
+
 /// @prop - Box shadow color of the card
 $card-ios-box-shadow-color:            rgba(0, 0, 0, .12) !default;
 
@@ -27,8 +30,11 @@ $card-ios-border-radius:               8px !default;
 /// @prop - Font size of the card
 $card-ios-font-size:                   14px !default;
 
+/// @prop - Color of the card text
+$card-ios-text-color:                  $text-color-step-400 !default;
+
 /// @prop - Transition timing function of the card
 $card-ios-transition-timing-function:  cubic-bezier(0.12, 0.72, 0.29, 1) !default;
 
 /// @prop - Transform of the card on activate
-$card-ios-transform-activated:         scale3d(.97, .97, 1) !default;
+$card-ios-transform-activated:         scale3d(.97, .97, 1) !default;

core/src/components/card/card.md.scss

@@ -5,8 +5,8 @@
 // --------------------------------------------------
 
 :host {
-  --background: #{$card-md-background};
-  --color: #{$card-md-color};
+  --background: #{$item-md-background};
+  --color: #{$card-md-text-color};
 
   @include margin($card-md-margin-top, $card-md-margin-end, $card-md-margin-bottom, $card-md-margin-start);
   @include border-radius($card-md-border-radius);

core/src/components/card/card.md.vars.scss

@@ -15,6 +15,9 @@ $card-md-margin-bottom:               10px !default;
 /// @prop - Margin start of the card
 $card-md-margin-start:                10px !default;
 
+/// @prop - Background color of the card
+$card-md-background-color:            $item-md-background !default;
+
 /// @prop - Box shadow of the card
 $card-md-box-shadow:                  0 3px 1px -2px rgba(0,0,0,.2), 0 2px 2px 0 rgba(0,0,0,.14), 0 1px 5px 0 rgba(0,0,0,.12) !default;
 
@@ -26,3 +29,6 @@ $card-md-font-size:                   14px !default;
 
 /// @prop - Line height of the card
 $card-md-line-height:                 1.5 !default;
+
+/// @prop - Color of the card text
+$card-md-text-color:                  $text-color-step-450 !default;

core/src/components/card/card.tsx

@@ -122,11 +122,13 @@ export class Card implements ComponentInterface, AnchorInterface, ButtonInterfac
     const mode = getIonMode(this);
     return (
       <Host
-        class={createColorClasses(this.color, {
+        class={{
           [mode]: true,
+
+          ...createColorClasses(this.color),
           'card-disabled': this.disabled,
           'ion-activatable': this.isClickable()
-        })}
+        }}
       >
         {this.renderCard(mode)}
       </Host>

core/src/components/card/readme.md

@@ -215,7 +215,7 @@ export class CardExample {
 
   <ion-card>
     <ion-item>
-      <ion-icon :icon="pin" slot="start"></ion-icon>
+      <ion-icon name="pin" slot="start"></ion-icon>
       <ion-label>ion-item in a card, icon left, button right</ion-label>
       <ion-button fill="outline" slot="end">View</ion-button>
     </ion-item>
@@ -228,39 +228,26 @@ export class CardExample {
 
   <ion-card>
     <ion-item href="#" class="ion-activated">
-      <ion-icon :icon="wifi" slot="start"></ion-icon>
+      <ion-icon name="wifi" slot="start"></ion-icon>
       <ion-label>Card Link Item 1 activated</ion-label>
     </ion-item>
 
     <ion-item href="#">
-      <ion-icon :icon="wine" slot="start"></ion-icon>
+      <ion-icon name="wine" slot="start"></ion-icon>
       <ion-label>Card Link Item 2</ion-label>
     </ion-item>
 
     <ion-item class="ion-activated">
-      <ion-icon :icon="warning" slot="start"></ion-icon>
+      <ion-icon name="warning" slot="start"></ion-icon>
       <ion-label>Card Button Item 1 activated</ion-label>
     </ion-item>
 
     <ion-item>
-      <ion-icon :icon="walk" slot="start"></ion-icon>
+      <ion-icon name="walk" slot="start"></ion-icon>
       <ion-label>Card Button Item 2</ion-label>
     </ion-item>
   </ion-card>
 </template>
-
-<script>
-import { IonCard, IonCardContent, IonCardSubtitle, IonCardTitle, IonIcon, IonItem, IonLabel } from '@ionic/vue';
-import { pin, walk, warning, wifi, wine } from 'ionicons/icons';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonCard, IonCardContent, IonCardSubtitle, IonCardTitle, IonIcon, IonItem, IonLabel }
-  setup() {
-    return { warning };
-  }
-});
-</script>
 ```
 
 

core/src/components/card/usage/vue.md

@@ -14,7 +14,7 @@
 
   <ion-card>
     <ion-item>
-      <ion-icon :icon="pin" slot="start"></ion-icon>
+      <ion-icon name="pin" slot="start"></ion-icon>
       <ion-label>ion-item in a card, icon left, button right</ion-label>
       <ion-button fill="outline" slot="end">View</ion-button>
     </ion-item>
@@ -27,37 +27,24 @@
 
   <ion-card>
     <ion-item href="#" class="ion-activated">
-      <ion-icon :icon="wifi" slot="start"></ion-icon>
+      <ion-icon name="wifi" slot="start"></ion-icon>
       <ion-label>Card Link Item 1 activated</ion-label>
     </ion-item>
 
     <ion-item href="#">
-      <ion-icon :icon="wine" slot="start"></ion-icon>
+      <ion-icon name="wine" slot="start"></ion-icon>
       <ion-label>Card Link Item 2</ion-label>
     </ion-item>
 
     <ion-item class="ion-activated">
-      <ion-icon :icon="warning" slot="start"></ion-icon>
+      <ion-icon name="warning" slot="start"></ion-icon>
       <ion-label>Card Button Item 1 activated</ion-label>
     </ion-item>
 
     <ion-item>
-      <ion-icon :icon="walk" slot="start"></ion-icon>
+      <ion-icon name="walk" slot="start"></ion-icon>
       <ion-label>Card Button Item 2</ion-label>
     </ion-item>
   </ion-card>
 </template>
-
-<script>
-import { IonCard, IonCardContent, IonCardSubtitle, IonCardTitle, IonIcon, IonItem, IonLabel } from '@ionic/vue';
-import { pin, walk, warning, wifi, wine } from 'ionicons/icons';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonCard, IonCardContent, IonCardSubtitle, IonCardTitle, IonIcon, IonItem, IonLabel }
-  setup() {
-    return { warning };
-  }
-});
-</script>
 ```

core/src/components/checkbox/checkbox.tsx

@@ -155,14 +155,15 @@ export class Checkbox implements ComponentInterface {
         aria-disabled={disabled ? 'true' : null}
         aria-checked={`${checked}`}
         aria-labelledby={labelId}
-        class={createColorClasses(color, {
+        class={{
+          ...createColorClasses(color),
           [mode]: true,
           'in-item': hostContext('ion-item', el),
           'checkbox-checked': checked,
           'checkbox-disabled': disabled,
           'checkbox-indeterminate': indeterminate,
           'interactive': true
-        })}
+        }}
       >
         <svg class="checkbox-icon" viewBox="0 0 24 24" part="container">
           {path}

core/src/components/checkbox/readme.md

@@ -235,22 +235,17 @@ export class CheckboxExample {
   </ion-list>
 </template>
 
-<script>
-import { IonCheckbox, IonItem, IonLabel, IonList } from '@ionic/vue';
-import { defineComponent } from 'vue';
+<script lang="ts">
+  import { Component, Vue } from 'vue-property-decorator';
 
-export default defineComponent({
-  components: { IonCheckbox, IonItem, IonLabel, IonList },
-  setup() {
-    const form = [
+  @Component()
+  export default class Example extends Vue {
+    form = [
       { val: 'Pepperoni', isChecked: true },
       { val: 'Sausage', isChecked: false },
       { val: 'Mushroom', isChecked: false }
     ];
-    
-    return { form };
   }
-});
 </script>
 ```
 

core/src/components/checkbox/usage/vue.md

@@ -29,21 +29,16 @@
   </ion-list>
 </template>
 
-<script>
-import { IonCheckbox, IonItem, IonLabel, IonList } from '@ionic/vue';
-import { defineComponent } from 'vue';
+<script lang="ts">
+  import { Component, Vue } from 'vue-property-decorator';
 
-export default defineComponent({
-  components: { IonCheckbox, IonItem, IonLabel, IonList },
-  setup() {
-    const form = [
+  @Component()
+  export default class Example extends Vue {
+    form = [
       { val: 'Pepperoni', isChecked: true },
       { val: 'Sausage', isChecked: false },
       { val: 'Mushroom', isChecked: false }
     ];
-    
-    return { form };
   }
-});
 </script>
 ```

core/src/components/chip/chip.scss

@@ -64,6 +64,7 @@
 }
 
 :host(.chip-outline) {
+
   border-color: rgba(0, 0, 0, .32);
 
   background: transparent;

core/src/components/chip/chip.tsx

@@ -33,11 +33,12 @@ export class Chip implements ComponentInterface {
 
     return (
       <Host
-        class={createColorClasses(this.color, {
+        class={{
+          ...createColorClasses(this.color),
           [mode]: true,
           'chip-outline': this.outline,
           'ion-activatable': true,
-        })}
+        }}
       >
         <slot></slot>
         {mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}

core/src/components/chip/readme.md

@@ -192,24 +192,24 @@ export class ChipExample {
   </ion-chip>
 
   <ion-chip>
-    <ion-icon :icon="pin"></ion-icon>
+    <ion-icon name="pin"></ion-icon>
     <ion-label>Default</ion-label>
   </ion-chip>
 
   <ion-chip>
-    <ion-icon :icon="heart" color="dark"></ion-icon>
+    <ion-icon name="heart" color="dark"></ion-icon>
     <ion-label>Default</ion-label>
   </ion-chip>
 
   <ion-chip>
     <ion-label>Button Chip</ion-label>
-    <ion-icon :icon="closeCircle"></ion-icon>
+    <ion-icon name="close-circle"></ion-icon>
   </ion-chip>
 
   <ion-chip>
-    <ion-icon :icon="pin" color="primary"></ion-icon>
+    <ion-icon name="pin" color="primary"></ion-icon>
     <ion-label>Icon Chip</ion-label>
-    <ion-icon :icon="close"></ion-icon>
+    <ion-icon name="close"></ion-icon>
   </ion-chip>
 
   <ion-chip>
@@ -217,23 +217,9 @@ export class ChipExample {
       <img src="https://gravatar.com/avatar/dba6bae8c566f9d4041fb9cd9ada7741?d=identicon&f=y">
     </ion-avatar>
     <ion-label>Avatar Chip</ion-label>
-    <ion-icon :icon="closeCircle"></ion-icon>
+    <ion-icon name="close-circle"></ion-icon>
   </ion-chip>
 </template>
-
-<script>
-import { IonAvatar, IonChip, IonIcon, IonLabel } from '@ionic/vue';
-import { close, closeCircle, heart, pin } from 'ionicons/icons';
-
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonAvatar, IonChip, IonIcon, IonLabel },
-  setup() {
-    return { close, closeCircle, heart, pin }
-  }
-});
-</script>
 ```
 
 

core/src/components/chip/usage/vue.md

@@ -13,24 +13,24 @@
   </ion-chip>
 
   <ion-chip>
-    <ion-icon :icon="pin"></ion-icon>
+    <ion-icon name="pin"></ion-icon>
     <ion-label>Default</ion-label>
   </ion-chip>
 
   <ion-chip>
-    <ion-icon :icon="heart" color="dark"></ion-icon>
+    <ion-icon name="heart" color="dark"></ion-icon>
     <ion-label>Default</ion-label>
   </ion-chip>
 
   <ion-chip>
     <ion-label>Button Chip</ion-label>
-    <ion-icon :icon="closeCircle"></ion-icon>
+    <ion-icon name="close-circle"></ion-icon>
   </ion-chip>
 
   <ion-chip>
-    <ion-icon :icon="pin" color="primary"></ion-icon>
+    <ion-icon name="pin" color="primary"></ion-icon>
     <ion-label>Icon Chip</ion-label>
-    <ion-icon :icon="close"></ion-icon>
+    <ion-icon name="close"></ion-icon>
   </ion-chip>
 
   <ion-chip>
@@ -38,21 +38,7 @@
       <img src="https://gravatar.com/avatar/dba6bae8c566f9d4041fb9cd9ada7741?d=identicon&f=y">
     </ion-avatar>
     <ion-label>Avatar Chip</ion-label>
-    <ion-icon :icon="closeCircle"></ion-icon>
+    <ion-icon name="close-circle"></ion-icon>
   </ion-chip>
 </template>
-
-<script>
-import { IonAvatar, IonChip, IonIcon, IonLabel } from '@ionic/vue';
-import { close, closeCircle, heart, pin } from 'ionicons/icons';
-
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonAvatar, IonChip, IonIcon, IonLabel },
-  setup() {
-    return { close, closeCircle, heart, pin }
-  }
-});
-</script>
 ```

core/src/components/content/content.scss

@@ -128,6 +128,7 @@
 }
 
 .transition-effect {
+
   display: none;
   position: absolute;
 

core/src/components/content/content.tsx

@@ -313,11 +313,12 @@ export class Content implements ComponentInterface {
 
     return (
       <Host
-        class={createColorClasses(this.color, {
+        class={{
+          ...createColorClasses(this.color),
           [mode]: true,
           'content-sizing': hostContext('ion-popover', this.el),
           'overscroll': forceOverscroll,
-        })}
+        }}
         style={{
           '--offset-top': `${this.cTop}px`,
           '--offset-bottom': `${this.cBottom}px`,

core/src/components/content/readme.md

@@ -123,7 +123,7 @@ export class ContentExample {
 ```html
 <template>
   <ion-content
-    :scroll-events="true"
+    :scrollEvents="true"
     @ionScrollStart="logScrollStart()"
     @ionScroll="logScrolling($event)"
     @ionScrollEnd="logScrollEnd()">
@@ -134,16 +134,6 @@ export class ContentExample {
       </div>
   </ion-content>
 </template>
-
-<script>
-import { IonContent } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonContent }
-});
-</script>
-
 ```
 
 

core/src/components/content/usage/vue.md

@@ -1,7 +1,7 @@
 ```html
 <template>
   <ion-content
-    :scroll-events="true"
+    :scrollEvents="true"
     @ionScrollStart="logScrollStart()"
     @ionScroll="logScrolling($event)"
     @ionScrollEnd="logScrollEnd()">
@@ -12,15 +12,5 @@
       </div>
   </ion-content>
 </template>
-
-<script>
-import { IonContent } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonContent }
-});
-</script>
-
 ```
 

core/src/components/datetime/datetime-util.spec.ts

@@ -220,7 +220,6 @@ describe('datetime-util', () => {
         "second": undefined,
         "tzOffset": 0,
         "year": 1000,
-        "ampm": "am"
       });
     });
 
@@ -235,7 +234,6 @@ describe('datetime-util', () => {
         "second": undefined,
         "tzOffset": 0,
         "year": undefined,
-        "ampm": "pm"
       });
     });
 
@@ -250,7 +248,6 @@ describe('datetime-util', () => {
         "second": 20,
         "tzOffset": 0,
         "year": 1994,
-        "ampm": "pm"
       });
     });
 
@@ -265,7 +262,6 @@ describe('datetime-util', () => {
         "second": undefined,
         "tzOffset": 0,
         "year": 2018,
-        "ampm": "am"
       });
     });
 

core/src/components/datetime/datetime-util.ts

@@ -238,7 +238,6 @@ export const parseDate = (val: string | undefined | null): DatetimeData | undefi
     second: parse[6],
     millisecond: parse[7],
     tzOffset,
-    ampm: parse[4] >= 12 ? 'pm' : 'am'
   };
 };
 
@@ -323,33 +322,11 @@ export const updateDate = (existingData: DatetimeData, newData: any, displayTime
       }
 
     } else if ((newData.year || newData.hour || newData.month || newData.day || newData.minute || newData.second)) {
-      // newData is from the datetime picker's selected values
-      // update the existing datetimeValue with the new values
-      if (newData.ampm !== undefined && newData.hour !== undefined) {
-        // If the date we came from exists, we need to change the meridiem value when
-        // going to and from 12
-        if (existingData.ampm !== undefined && existingData.hour !== undefined) {
-          // If the existing meridiem is am, we want to switch to pm if it is either
-          // A) coming from 0 (12 am)
-          // B) going to 12 (12 pm)
-          if (existingData.ampm === 'am' && (existingData.hour === 0 || newData.hour.value === 12)) {
-            newData.ampm.value = 'pm';
-          }
+      // newData is from of a datetime picker's selected values
+      // update the existing DatetimeData data with the new values
 
-          // If the existing meridiem is pm, we want to switch to am if it is either
-          // A) coming from 12 (12 pm)
-          // B) going to 12 (12 am)
-          if (existingData.ampm === 'pm' && (existingData.hour === 12 || newData.hour.value === 12)) {
-            newData.ampm.value = 'am';
-          }
-        }
-
-        // change the value of the hour based on whether or not it is am or pm
-        // if the meridiem is pm and equal to 12, it remains 12
-        // otherwise we add 12 to the hour value
-        // if the meridiem is am and equal to 12, we change it to 0
-        // otherwise we use its current hour value
-        // for example: 8 pm becomes 20, 12 am becomes 0, 4 am becomes 4
+      // do some magic for 12-hour values
+      if (newData.ampm && newData.hour) {
         newData.hour.value = (newData.ampm.value === 'pm')
           ? (newData.hour.value === 12 ? 12 : newData.hour.value + 12)
           : (newData.hour.value === 12 ? 0 : newData.hour.value);
@@ -372,8 +349,7 @@ export const updateDate = (existingData: DatetimeData, newData: any, displayTime
             ? (existingData.hour! < 12 ? existingData.hour! + 12 : existingData.hour!)
             : (existingData.hour! >= 12 ? existingData.hour! - 12 : existingData.hour))
       };
-      existingData['hour'] = newData['hour'].value;
-      existingData['ampm'] = newData['ampm'].value;
+      (existingData as any)['hour'] = newData['hour'].value;
       return true;
     }
 
@@ -575,7 +551,6 @@ export interface DatetimeData {
   second?: number;
   millisecond?: number;
   tzOffset?: number;
-  ampm?: string;
 }
 
 export interface LocaleData {

core/src/components/datetime/datetime.tsx

@@ -282,12 +282,6 @@ export class Datetime implements ComponentInterface {
         value: colOptions[colSelectedIndex].value
       };
 
-      if (data.name !== 'ampm' && this.datetimeValue.ampm !== undefined) {
-        changeData['ampm'] = {
-          value: this.datetimeValue.ampm
-        }
-      }
-
       this.updateDatetimeValue(changeData);
       picker.columns = this.generateColumns();
     });
@@ -638,6 +632,7 @@ export class Datetime implements ComponentInterface {
     return (
       <Host
         onClick={this.onClick}
+        role="combobox"
         aria-disabled={disabled ? 'true' : null}
         aria-expanded={`${isExpanded}`}
         aria-haspopup="true"

core/src/components/datetime/readme.md

@@ -748,15 +748,14 @@ export class DatetimeExample {
   </ion-item>
 </template>
 
-<script>
-import { IonDatetime, IonItem, IonLabel } from '@ionic/vue';
-import { defineComponent } from 'vue';
+<script lang="ts">
+  import { Component, Vue } from 'vue-property-decorator';
 
-export default defineComponent({
-  components: { IonDatetime, IonItem, IonLabel },
-  setup() {
-    const customYearValues = [2020, 2016, 2008, 2004, 2000, 1996];
-    const customDayShortNames = [
+  @Component()
+  export default class Example extends Vue {
+    customYearValues = [2020, 2016, 2008, 2004, 2000, 1996];
+
+    customDayShortNames = [
       's\u00f8n',
       'man',
       'tir',
@@ -765,7 +764,8 @@ export default defineComponent({
       'fre',
       'l\u00f8r'
     ];
-    const customPickerOptions = {
+
+    customPickerOptions = {
       buttons: [{
         text: 'Save',
         handler: () => console.log('Clicked Save!')
@@ -777,14 +777,7 @@ export default defineComponent({
         }
       }]
     }
-    
-    return {
-      customYearValues,
-      customDayShortNames,
-      customPickerOptions
-    }
   }
-});
 </script>
 ```
 

core/src/components/datetime/test/basic/e2e.ts

@@ -1,40 +1,5 @@
 import { newE2EPage } from '@stencil/core/testing';
 
-const getActiveElementText = async (page) => {
-  const activeElement = await page.evaluateHandle(() => document.activeElement);
-  return await page.evaluate(el => el && el.textContent, activeElement);
-}
-
-test('datetime/picker: focus trap', async () => {
-  const page = await newE2EPage({ url: '/src/components/datetime/test/basic?ionic:_testing=true' });
-  await page.click('#datetime-part');
-  await page.waitForSelector('#datetime-part');
-
-  let datetime = await page.find('ion-datetime');
-
-  expect(datetime).not.toBe(null);
-
-  // TODO fix
-  await page.waitFor(100);
-
-  await page.keyboard.press('Tab');
-
-  const activeElementText = await getActiveElementText(page);
-  expect(activeElementText).toEqual('Cancel');
-
-  await page.keyboard.down('Shift');
-  await page.keyboard.press('Tab');
-  await page.keyboard.up('Shift');
-
-  const activeElementTextTwo = await getActiveElementText(page);
-  expect(activeElementTextTwo).toEqual('1920');
-
-  await page.keyboard.press('Tab');
-
-  const activeElementTextThree = await getActiveElementText(page);
-  expect(activeElementTextThree).toEqual('Cancel');
-});
-
 test('datetime: basic', async () => {
   const page = await newE2EPage({
     url: '/src/components/datetime/test/basic?ionic:_testing=true'

core/src/components/datetime/test/basic/index.html

@@ -132,15 +132,6 @@
           <ion-datetime display-format="h:mm A" minute-values="0,15,30,45"></ion-datetime>
         </ion-item>
 
-        <ion-item>
-          <ion-label>YYYY MMM DD hh:mm A</ion-label>
-          <ion-datetime
-            id="todaysDate"
-            display-format="YYYY MMM DD hh:mm A"
-            minute-values="00,05,10,15,20,25,30,35,40,45,50,55">
-          </ion-datetime>
-        </ion-item>
-
         <ion-item>
           <ion-label>Leap years, summer months</ion-label>
           <ion-datetime id="customYearValues" display-format="MM/YYYY" pickerFormat="MMMM YYYY" month-values="6,7,8"></ion-datetime>
@@ -206,9 +197,6 @@
     </style>
 
     <script>
-      var todaysDateDatetime = document.querySelector('#todaysDate');
-      todaysDateDatetime.value = '2020-09-02T17:15:03.488Z';
-
       var yearValuesArray = [2020, 2016, 2008, 2004, 2000, 1996];
       var customYearValues = document.getElementById('customYearValues');
       customYearValues.yearValues = yearValuesArray;

core/src/components/datetime/usage/vue.md

@@ -79,15 +79,14 @@
   </ion-item>
 </template>
 
-<script>
-import { IonDatetime, IonItem, IonLabel } from '@ionic/vue';
-import { defineComponent } from 'vue';
+<script lang="ts">
+  import { Component, Vue } from 'vue-property-decorator';
 
-export default defineComponent({
-  components: { IonDatetime, IonItem, IonLabel },
-  setup() {
-    const customYearValues = [2020, 2016, 2008, 2004, 2000, 1996];
-    const customDayShortNames = [
+  @Component()
+  export default class Example extends Vue {
+    customYearValues = [2020, 2016, 2008, 2004, 2000, 1996];
+
+    customDayShortNames = [
       's\u00f8n',
       'man',
       'tir',
@@ -96,7 +95,8 @@ export default defineComponent({
       'fre',
       'l\u00f8r'
     ];
-    const customPickerOptions = {
+
+    customPickerOptions = {
       buttons: [{
         text: 'Save',
         handler: () => console.log('Clicked Save!')
@@ -108,13 +108,6 @@ export default defineComponent({
         }
       }]
     }
-    
-    return {
-      customYearValues,
-      customDayShortNames,
-      customPickerOptions
-    }
   }
-});
 </script>
 ```

core/src/components/fab-button/fab-button.tsx

@@ -142,7 +142,8 @@ export class FabButton implements ComponentInterface, AnchorInterface, ButtonInt
     return (
       <Host
         aria-disabled={disabled ? 'true' : null}
-        class={createColorClasses(color, {
+        class={{
+          ...createColorClasses(color),
           [mode]: true,
           'fab-button-in-list': inList,
           'fab-button-translucent-in-list': inList && translucent,
@@ -153,7 +154,7 @@ export class FabButton implements ComponentInterface, AnchorInterface, ButtonInt
           'ion-activatable': true,
           'ion-focusable': true,
           [`fab-button-${size}`]: size !== undefined,
-        })}
+        }}
       >
 
         <TagType

core/src/components/fab-button/readme.md

@@ -131,15 +131,6 @@ export class FabButtonExample {
 
   </ion-content>
 </template>
-
-<script>
-import { IonContent, IonFab, IonFabButton } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonContent, IonFab, IonFabButton }
-});
-</script>
 ```
 
 

core/src/components/fab-button/usage/vue.md

@@ -22,13 +22,4 @@
 
   </ion-content>
 </template>
-
-<script>
-import { IonContent, IonFab, IonFabButton } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonContent, IonFab, IonFabButton }
-});
-</script>
 ```

core/src/components/fab-list/readme.md

@@ -215,15 +215,6 @@ export class FabListExample {
 
   </ion-fab>
 </template>
-
-<script>
-import { IonFab, IonFabButton, IonFabList } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonFab, IonFabButton, IonFabList }
-});
-</script>
 ```
 
 

core/src/components/fab-list/usage/vue.md

@@ -15,13 +15,4 @@
 
   </ion-fab>
 </template>
-
-<script>
-import { IonFab, IonFabButton, IonFabList } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonFab, IonFabButton, IonFabList }
-});
-</script>
 ```

core/src/components/fab/readme.md

@@ -416,61 +416,6 @@ export class FabExample {
     </ion-toolbar>
   </ion-footer>
 </template>
-
-<script>
-import { 
-  IonContent, 
-  IonFab, 
-  IonFabButton, 
-  IonFabList, 
-  IonFooter, 
-  IonHeader, 
-  IonIcon, 
-  IonTitle, 
-  IonToolbar 
-} from '@ionic/vue';
-import { 
-  add, 
-  arrowBackCircle,
-  arrowForwardCircle, 
-  logoFacebook, 
-  logoInstagram, 
-  logoTwitter, 
-  logoVimeo, 
-  person, 
-  settings, 
-  share
-} from 'ionicons/icons';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { 
-    IonContent, 
-    IonFab, 
-    IonFabButton, 
-    IonFabList, 
-    IonFooter, 
-    IonHeader, 
-    IonIcon, 
-    IonTitle, 
-    IonToolbar
-  },
-  setup() {
-    return {
-      add, 
-      arrowBackCircle,
-      arrowForwardCircle, 
-      logoFacebook, 
-      logoInstagram, 
-      logoTwitter, 
-      logoVimeo, 
-      person, 
-      settings, 
-      share
-    }
-  }
-});
-</script>
 ```
 
 

core/src/components/fab/usage/vue.md

@@ -92,59 +92,4 @@
     </ion-toolbar>
   </ion-footer>
 </template>
-
-<script>
-import { 
-  IonContent, 
-  IonFab, 
-  IonFabButton, 
-  IonFabList, 
-  IonFooter, 
-  IonHeader, 
-  IonIcon, 
-  IonTitle, 
-  IonToolbar 
-} from '@ionic/vue';
-import { 
-  add, 
-  arrowBackCircle,
-  arrowForwardCircle, 
-  logoFacebook, 
-  logoInstagram, 
-  logoTwitter, 
-  logoVimeo, 
-  person, 
-  settings, 
-  share
-} from 'ionicons/icons';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { 
-    IonContent, 
-    IonFab, 
-    IonFabButton, 
-    IonFabList, 
-    IonFooter, 
-    IonHeader, 
-    IonIcon, 
-    IonTitle, 
-    IonToolbar
-  },
-  setup() {
-    return {
-      add, 
-      arrowBackCircle,
-      arrowForwardCircle, 
-      logoFacebook, 
-      logoInstagram, 
-      logoTwitter, 
-      logoVimeo, 
-      person, 
-      settings, 
-      share
-    }
-  }
-});
-</script>
 ```

core/src/components/footer/readme.md

@@ -106,15 +106,6 @@ export class FooterExample {
     </ion-toolbar>
   </ion-footer>
 </template>
-
-<script>
-import { IonContent, IonFooter, IonTitle, IonToolbar } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonContent, IonFooter, IonTitle, IonToolbar }
-});
-</script>
 ```
 
 

core/src/components/footer/usage/vue.md

@@ -15,13 +15,4 @@
     </ion-toolbar>
   </ion-footer>
 </template>
-
-<script>
-import { IonContent, IonFooter, IonTitle, IonToolbar } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonContent, IonFooter, IonTitle, IonToolbar }
-});
-</script>
 ```

core/src/components/grid/readme.md

@@ -714,15 +714,6 @@ export class GridExample {
     </ion-row>
   </ion-grid>
 </template>
-
-<script>
-import { IonCol, IonGrid, IonRow } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonCol, IonGrid, IonRow }
-});
-</script>
 ```
 
 

core/src/components/grid/usage/vue.md

@@ -178,13 +178,4 @@
     </ion-row>
   </ion-grid>
 </template>
-
-<script>
-import { IonCol, IonGrid, IonRow } from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { IonCol, IonGrid, IonRow }
-});
-</script>
 ```

core/src/components/header/header.tsx

@@ -49,7 +49,7 @@ export class Header implements ComponentInterface {
     await this.checkCollapsibleHeader();
   }
 
-  disconnectedCallback() {
+  componentDidUnload() {
     this.destroyCollapsibleHeader();
   }
 

core/src/components/header/header.utils.ts

@@ -150,6 +150,7 @@ export const scaleLargeTitles = (toolbars: ToolbarIndex[] = [], scale = 1, trans
     const titleDiv = toolbar.innerTitleEl;
     if (!ionTitle || ionTitle.size !== 'large') { return; }
 
+    titleDiv.style.transformOrigin = 'left center';
     titleDiv.style.transition = (transition) ? TRANSITION : '';
     titleDiv.style.transform = `scale3d(${scale}, ${scale}, 1)`;
   });

core/src/components/header/readme.md

@@ -160,29 +160,6 @@ export class HeaderExample {
     </ion-header>
   </ion-content>
 </template>
-
-<script>
-import { 
-  IonBackButton, 
-  IonButtons, 
-  IonContent, 
-  IonHeader, 
-  IonTitle, 
-  IonToolbar
-} from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { 
-    IonBackButton, 
-    IonButtons, 
-    IonContent, 
-    IonHeader, 
-    IonTitle, 
-    IonToolbar
-  }
-});
-</script>
 ```
 
 

core/src/components/header/usage/vue.md

@@ -28,27 +28,4 @@
     </ion-header>
   </ion-content>
 </template>
-
-<script>
-import { 
-  IonBackButton, 
-  IonButtons, 
-  IonContent, 
-  IonHeader, 
-  IonTitle, 
-  IonToolbar
-} from '@ionic/vue';
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-  components: { 
-    IonBackButton, 
-    IonButtons, 
-    IonContent, 
-    IonHeader, 
-    IonTitle, 
-    IonToolbar
-  }
-});
-</script>
 ```