v6.4.2-nightly.20230109

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -21,7 +21,6 @@ body:
         - label: v4.x
         - label: v5.x
         - label: v6.x
-        - label: v7.x
         - label: Nightly
   - type: textarea
     attributes:

.github/dependabot.yml

@@ -6,4 +6,3 @@ updates:
       interval: "daily"
     allow:
       - dependency-name: "@playwright/test"
-        dependency-name: "@axe-core/playwright"

.github/workflows/actions/build-angular-server/action.yml

@@ -8,7 +8,7 @@ runs:
         node-version: 16.x
 
     - name: Install Angular Server Dependencies
-      run: npm ci
+      run: npm install --legacy-peer-deps
       shell: bash
       working-directory: ./packages/angular-server
     - name: Build

.github/workflows/actions/build-angular/action.yml

@@ -12,7 +12,7 @@ runs:
         path: ./core
         filename: CoreBuild.zip
     - name: Install Angular Dependencies
-      run: npm ci
+      run: npm install --legacy-peer-deps
       shell: bash
       working-directory: ./angular
     - name: Sync

.github/workflows/actions/build-react-router/action.yml

@@ -6,6 +6,15 @@ runs:
     - uses: actions/setup-node@v3
       with:
         node-version: 16.x
+    - name: Install Dependencies
+      run: npm install --legacy-peer-deps
+      shell: bash
+      working-directory: ./packages/react-router
+    - uses: ./.github/workflows/actions/download-archive
+      with:
+        name: ionic-react
+        path: ./packages/react
+        filename: ReactBuild.zip
     - uses: ./.github/workflows/actions/download-archive
       with:
         name: ionic-core
@@ -17,7 +26,7 @@ runs:
         path: ./packages/react
         filename: ReactBuild.zip
     - name: Install Dependencies
-      run: npm ci
+      run: npm install --legacy-peer-deps
       shell: bash
       working-directory: ./packages/react-router
     - name: Sync

.github/workflows/actions/build-react/action.yml

@@ -12,7 +12,7 @@ runs:
         path: ./core
         filename: CoreBuild.zip
     - name: Install React Dependencies
-      run: npm ci
+      run: npm install --legacy-peer-deps
       shell: bash
       working-directory: ./packages/react
     - name: Sync

.github/workflows/actions/build-vue-router/action.yml

@@ -17,7 +17,7 @@ runs:
         path: ./packages/vue
         filename: VueBuild.zip
     - name: Install Vue Router Dependencies
-      run: npm ci
+      run: npm install
       shell: bash
       working-directory: ./packages/vue-router
     - name: Sync

.github/workflows/actions/build-vue/action.yml

@@ -12,7 +12,7 @@ runs:
         path: ./core
         filename: CoreBuild.zip
     - name: Install Vue Dependencies
-      run: npm ci
+      run: npm install --legacy-peer-deps
       shell: bash
       working-directory: ./packages/vue
     - name: Sync

.github/workflows/build.yml

@@ -3,8 +3,7 @@ name: 'Ionic Framework Build'
 on:
   pull_request:
     branches: [ '**' ]
-  merge_group:
-  
+
 # When pushing a new commit we should
 # cancel the previous test run to not
 # consume more runners than we need to.
@@ -12,7 +11,6 @@ concurrency:
   group: ${{ github.ref }}
   cancel-in-progress: true
 
-
 jobs:
   build-core:
     runs-on: ubuntu-latest
@@ -46,6 +44,10 @@ jobs:
 
   test-core-screenshot:
     strategy:
+      # This ensures that all screenshot shard
+      # failures are reported so the dev can
+      # review everything at once.
+      fail-fast: false
       matrix:
         # Divide the tests into n buckets
         # and run those buckets in parallel.

.github/workflows/release.yml

@@ -57,7 +57,7 @@ jobs:
     # so we do that here.
     - name: Bump Package Lock
       run: |
-        lerna exec "npm install --package-lock-only"
+        lerna exec "npm install --package-lock-only --legacy-peer-deps"
         git add .
         git commit -m "chore(): update package lock files"
         git push

.gitignore

@@ -7,7 +7,6 @@
 log.txt
 *.sublime-project
 *.sublime-workspace
-*.tgz
 
 .idea/
 .vscode/

BETA.md

@@ -1,5 +1,3 @@
-Test B
-
 # Ionic Framework v6 Beta
 
 Thanks for your interest in trying out the Framework v6 beta! We are looking for developers to help test our new changes and provide feedback so that we can make Framework v6 the best release yet! Follow this guide to get setup with the beta.

BREAKING.md

@@ -1,5 +1,3 @@
-test branch update
-
 # Breaking Changes
 
 This is a comprehensive list of the breaking changes introduced in the major version releases of Ionic Framework.

CHANGELOG.md

@@ -3,89 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [6.5.3](https://github.com/ionic-team/ionic-framework/compare/v6.5.2...v6.5.3) (2023-02-08)
-
-
-### Bug Fixes
-
-* **button:** size and strong are respected in ion-buttons ([#26726](https://github.com/ionic-team/ionic-framework/issues/26726)) ([3759125](https://github.com/ionic-team/ionic-framework/commit/37591255b4ab3dde5ece6950024a3b66e7224364))
-* **chip:** descenders are not clipped in label ([#26729](https://github.com/ionic-team/ionic-framework/issues/26729)) ([a9e000b](https://github.com/ionic-team/ionic-framework/commit/a9e000b4338f75c27e9284dbe9a6501ba3b213bc)), closes [#18313](https://github.com/ionic-team/ionic-framework/issues/18313)
-* **refresher:** prevent clearing virtual scroll overflow styling ([#26613](https://github.com/ionic-team/ionic-framework/issues/26613)) ([9d6ec29](https://github.com/ionic-team/ionic-framework/commit/9d6ec2925cb2314d5379b864aef467b34afbb318)), closes [#26553](https://github.com/ionic-team/ionic-framework/issues/26553)
-
-
-
-
-
-## [6.5.2](https://github.com/ionic-team/ionic-framework/compare/v6.5.1...v6.5.2) (2023-02-01)
-
-
-### Bug Fixes
-
-* **item:** inherit aria attributes before render ([#26546](https://github.com/ionic-team/ionic-framework/issues/26546)) ([95a3c69](https://github.com/ionic-team/ionic-framework/commit/95a3c69bbbe415cb5f14ac8e1faed287e91b4b40)), closes [#26538](https://github.com/ionic-team/ionic-framework/issues/26538)
-* **popover:** popover opens on chrome 109 ([#26672](https://github.com/ionic-team/ionic-framework/issues/26672)) ([69d89ea](https://github.com/ionic-team/ionic-framework/commit/69d89eae940ccd8b0cca379a961166c4592f34c7)), closes [#26643](https://github.com/ionic-team/ionic-framework/issues/26643)
-* **popover:** resolve import warning in stencil apps ([#26705](https://github.com/ionic-team/ionic-framework/issues/26705)) ([95f65a5](https://github.com/ionic-team/ionic-framework/commit/95f65a5a390eb600de8998c8be9dfd7c023d1eeb)), closes [#26704](https://github.com/ionic-team/ionic-framework/issues/26704)
-* **select:** setting options async updates rendered text ([#26667](https://github.com/ionic-team/ionic-framework/issues/26667)) ([a687457](https://github.com/ionic-team/ionic-framework/commit/a6874579361db548d961fdee83299d664dd6541b)), closes [#19324](https://github.com/ionic-team/ionic-framework/issues/19324)
-* **vue:** cache attached view reference ([#26694](https://github.com/ionic-team/ionic-framework/issues/26694)) ([7c00897](https://github.com/ionic-team/ionic-framework/commit/7c0089718afbbe3e19fecee4abbea00a6e618d95)), closes [#26695](https://github.com/ionic-team/ionic-framework/issues/26695)
-
-
-
-
-
-## [6.5.1](https://github.com/ionic-team/ionic-framework/compare/v6.5.0...v6.5.1) (2023-01-25)
-
-
-### Bug Fixes
-
-* **action-sheet:** button icons are not announced by screen readers ([#26640](https://github.com/ionic-team/ionic-framework/issues/26640)) ([22e9ff8](https://github.com/ionic-team/ionic-framework/commit/22e9ff866f8bd7e2e4ca82eae70969ea4f2658df))
-* **fab-button:** icon is not announced by screen readers ([#26619](https://github.com/ionic-team/ionic-framework/issues/26619)) ([dd7cd8c](https://github.com/ionic-team/ionic-framework/commit/dd7cd8c0bfe652d293dc2c2b1bd2a36fd9cf0a0b)), closes [#22296](https://github.com/ionic-team/ionic-framework/issues/22296)
-* **modal, popover:** warn if trigger element was not found ([#26650](https://github.com/ionic-team/ionic-framework/issues/26650)) ([1115203](https://github.com/ionic-team/ionic-framework/commit/11152031202a513121861486e50ea7942b9118d3))
-* **picker-column:** cssClass is set on column ([#26658](https://github.com/ionic-team/ionic-framework/issues/26658)) ([c6620c7](https://github.com/ionic-team/ionic-framework/commit/c6620c7c74abe04c3041e8b256441af72ea12131)), closes [#26653](https://github.com/ionic-team/ionic-framework/issues/26653)
-* **react:** hardware back button works in dev mode ([#26614](https://github.com/ionic-team/ionic-framework/issues/26614)) ([abcfe9f](https://github.com/ionic-team/ionic-framework/commit/abcfe9fe867730f29b9379c3736f86b3d20c5b0a)), closes [#26599](https://github.com/ionic-team/ionic-framework/issues/26599)
-* **select:** focusing item works in firefox ([#26668](https://github.com/ionic-team/ionic-framework/issues/26668)) ([946807d](https://github.com/ionic-team/ionic-framework/commit/946807d67b972c41b52c23c8f00feca4c705b224))
-* **toggle:** on-off icon is not announced by screen readers ([#26641](https://github.com/ionic-team/ionic-framework/issues/26641)) ([77ccac0](https://github.com/ionic-team/ionic-framework/commit/77ccac059091d5d9f7daf9c7fb01a9e855b86ce3))
-* **vue:** unmount teleported components ([#26647](https://github.com/ionic-team/ionic-framework/issues/26647)) ([6b16a0c](https://github.com/ionic-team/ionic-framework/commit/6b16a0c020fc6afb6a5a6e6fa6f0758384f026b9)), closes [#26644](https://github.com/ionic-team/ionic-framework/issues/26644)
-
-
-
-
-
-# [6.5.0](https://github.com/ionic-team/ionic-framework/compare/v6.4.3...v6.5.0) (2023-01-18)
-
-
-### Features
-
-* **deps:** update ionicons to 6.1.0 ([#26617](https://github.com/ionic-team/ionic-framework/issues/26617)) ([ccd2a92](https://github.com/ionic-team/ionic-framework/commit/ccd2a9224e018ad0d67903d44ec312934c3b35ec))
-* **deps:** update ionicons to 6.1.1 ([#26626](https://github.com/ionic-team/ionic-framework/issues/26626)) ([90405eb](https://github.com/ionic-team/ionic-framework/commit/90405eb0af69ce04faf5855189449d0b7518288c))
-* **router:** export hook interfaces ([#26551](https://github.com/ionic-team/ionic-framework/issues/26551)) ([2752702](https://github.com/ionic-team/ionic-framework/commit/27527025e4588f43f9f79640f0929e7c7d0618ee))
-
-
-
-
-
-## [6.4.3](https://github.com/ionic-team/ionic-framework/compare/v6.4.2...v6.4.3) (2023-01-18)
-
-
-### Bug Fixes
-
-* **datetime:** allow header to render in all wheel picker presentations ([#26616](https://github.com/ionic-team/ionic-framework/issues/26616)) ([7b947b5](https://github.com/ionic-team/ionic-framework/commit/7b947b5d58ff51a3a6ac360fef6d4df073e1bfec))
-* **input:** clear button uses contrast when setting color on item ([#26592](https://github.com/ionic-team/ionic-framework/issues/26592)) ([a31e1e5](https://github.com/ionic-team/ionic-framework/commit/a31e1e594d4ed7bbcf690b27eee143da232f2bdc)), closes [#26337](https://github.com/ionic-team/ionic-framework/issues/26337)
-* **list:** inset lists render correctly ([#26586](https://github.com/ionic-team/ionic-framework/issues/26586)) ([911b1d4](https://github.com/ionic-team/ionic-framework/commit/911b1d496efe595ddbf8e980f052e505ce9716c2)), closes [#20819](https://github.com/ionic-team/ionic-framework/issues/20819)
-
-
-
-
-
-## [6.4.2](https://github.com/ionic-team/ionic-framework/compare/v6.4.1...v6.4.2) (2023-01-11)
+## [6.4.2-nightly.20230109](https://github.com/ionic-team/ionic-framework/compare/v6.4.1...v6.4.2-nightly.20230109) (2023-01-09)
 
 
 ### Bug Fixes
 
 * **datetime:** time wheel input mode is dismissed on user scroll ([#26567](https://github.com/ionic-team/ionic-framework/issues/26567)) ([d13a146](https://github.com/ionic-team/ionic-framework/commit/d13a14658df2723aff908a94181cb563cb1f5b43))
-* **loading:** support custom aria-label ([#26581](https://github.com/ionic-team/ionic-framework/issues/26581)) ([2450a1e](https://github.com/ionic-team/ionic-framework/commit/2450a1e821d3901c8efb57ec256a10a951d22c8f)), closes [#24486](https://github.com/ionic-team/ionic-framework/issues/24486)
 * **modal:** canDismiss type with data and role ([#26547](https://github.com/ionic-team/ionic-framework/issues/26547)) ([32c2622](https://github.com/ionic-team/ionic-framework/commit/32c2622ab04a70d00684e9a813d9bcef698d7551)), closes [#26544](https://github.com/ionic-team/ionic-framework/issues/26544)
 * **picker-column-internal:** blurring picker does not throw error ([#26560](https://github.com/ionic-team/ionic-framework/issues/26560)) ([3e671b9](https://github.com/ionic-team/ionic-framework/commit/3e671b9c8ff62945a12eff431839ddae37d9d1a7)), closes [#26559](https://github.com/ionic-team/ionic-framework/issues/26559)
-* **segment:** nested interactive is not rendered ([#26575](https://github.com/ionic-team/ionic-framework/issues/26575)) ([77ce9e0](https://github.com/ionic-team/ionic-framework/commit/77ce9e066e1ee71438ceac35479ea04e8df021f5))
-* **tab-button:** nested interactives are not rendered ([#26576](https://github.com/ionic-team/ionic-framework/issues/26576)) ([df4882d](https://github.com/ionic-team/ionic-framework/commit/df4882d4d1c516038badfa647db484e070fbd099)), closes [#23332](https://github.com/ionic-team/ionic-framework/issues/23332)
 * **vue:** unmount teleported user component ([#26543](https://github.com/ionic-team/ionic-framework/issues/26543)) ([c996384](https://github.com/ionic-team/ionic-framework/commit/c996384786257524842cc1dca8d0fb940699719b)), closes [#26542](https://github.com/ionic-team/ionic-framework/issues/26542)
 
 

README.md

@@ -1,5 +1,3 @@
-TEST A
-
 <p align="center">
   <a href="#">
     <img alt="Ionic" src="https://github.com/ionic-team/ionic-framework/blob/main/.github/assets/logo.png?raw=true" width="60" />

angular/CHANGELOG.md

@@ -3,54 +3,7 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [6.5.3](https://github.com/ionic-team/ionic/compare/v6.5.2...v6.5.3) (2023-02-08)
-
-**Note:** Version bump only for package @ionic/angular
-
-
-
-
-
-## [6.5.2](https://github.com/ionic-team/ionic/compare/v6.5.1...v6.5.2) (2023-02-01)
-
-
-### Bug Fixes
-
-* **popover:** popover opens on chrome 109 ([#26672](https://github.com/ionic-team/ionic/issues/26672)) ([69d89ea](https://github.com/ionic-team/ionic/commit/69d89eae940ccd8b0cca379a961166c4592f34c7)), closes [#26643](https://github.com/ionic-team/ionic/issues/26643)
-
-
-
-
-
-## [6.5.1](https://github.com/ionic-team/ionic/compare/v6.5.0...v6.5.1) (2023-01-25)
-
-**Note:** Version bump only for package @ionic/angular
-
-
-
-
-
-# [6.5.0](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.5.0) (2023-01-18)
-
-
-### Features
-
-* **deps:** update ionicons to 6.1.0 ([#26617](https://github.com/ionic-team/ionic/issues/26617)) ([ccd2a92](https://github.com/ionic-team/ionic/commit/ccd2a9224e018ad0d67903d44ec312934c3b35ec))
-* **deps:** update ionicons to 6.1.1 ([#26626](https://github.com/ionic-team/ionic/issues/26626)) ([90405eb](https://github.com/ionic-team/ionic/commit/90405eb0af69ce04faf5855189449d0b7518288c))
-
-
-
-
-
-## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)
-
-**Note:** Version bump only for package @ionic/angular
-
-
-
-
-
-## [6.4.2](https://github.com/ionic-team/ionic/compare/v6.4.1...v6.4.2) (2023-01-11)
+## [6.4.2-nightly.20230109](https://github.com/ionic-team/ionic/compare/v6.4.1...v6.4.2-nightly.20230109) (2023-01-09)
 
 **Note:** Version bump only for package @ionic/angular
 

angular/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ionic/angular",
-  "version": "6.5.3",
+  "version": "6.4.2-nightly.20230109",
   "description": "Angular specific wrappers for @ionic/core",
   "keywords": [
     "ionic",
@@ -42,8 +42,8 @@
     "validate": "npm i && npm run lint && npm run test && npm run build"
   },
   "dependencies": {
-    "@ionic/core": "^6.5.3",
-    "ionicons": "^6.1.1",
+    "@ionic/core": "^6.4.2-nightly.20230109",
+    "ionicons": "^6.0.4",
     "jsonc-parser": "^3.0.0",
     "tslib": "^2.0.0"
   },

angular/scripts/sync.sh

@@ -2,11 +2,8 @@
 
 set -e
 
-# Pack @ionic/core
-npm pack ../core
-
-# Pack @ionic/angular
-npm pack ./
-
-# Install Dependencies
-npm install *.tgz --no-save
+# Copy core dist
+rm -rf node_modules/@ionic/core/dist node_modules/@ionic/core/components
+cp -a ../core/dist node_modules/@ionic/core/dist
+cp -a ../core/components node_modules/@ionic/core/components
+cp -a ../core/package.json node_modules/@ionic/core/package.json

angular/src/app-initialize.ts

@@ -6,8 +6,6 @@ import { Config } from './providers/config';
 import { IonicWindow } from './types/interfaces';
 import { raf } from './util/util';
 
-// TODO(FW-2827): types
-
 export const appInitialize = (config: Config, doc: Document, zone: NgZone) => {
   return (): any => {
     const win: IonicWindow | undefined = doc.defaultView as any;

angular/src/directives/control-value-accessors/boolean-value-accessor.ts

@@ -18,13 +18,13 @@ export class BooleanValueAccessorDirective extends ValueAccessor {
     super(injector, el);
   }
 
-  writeValue(value: boolean): void {
+  writeValue(value: any): void {
     this.el.nativeElement.checked = this.lastValue = value == null ? false : value;
     setIonicClasses(this.el);
   }
 
   @HostListener('ionChange', ['$event.target'])
-  _handleIonChange(el: HTMLIonCheckboxElement | HTMLIonToggleElement): void {
+  _handleIonChange(el: any): void {
     this.handleChangeEvent(el, el.checked);
   }
 }

angular/src/directives/control-value-accessors/radio-value-accessor.ts

@@ -19,7 +19,6 @@ export class RadioValueAccessorDirective extends ValueAccessor {
     super(injector, el);
   }
 
-  // TODO(FW-2827): type (HTMLIonRadioElement and HTMLElement are both missing `checked`)
   @HostListener('ionSelect', ['$event.target'])
   _handleIonSelect(el: any): void {
     this.handleChangeEvent(el, el.checked);

angular/src/directives/control-value-accessors/select-value-accessor.ts

@@ -20,14 +20,7 @@ export class SelectValueAccessorDirective extends ValueAccessor {
   }
 
   @HostListener('ionChange', ['$event.target'])
-  _handleChangeEvent(
-    el:
-      | HTMLIonRangeElement
-      | HTMLIonSelectElement
-      | HTMLIonRadioGroupElement
-      | HTMLIonSegmentElement
-      | HTMLIonDatetimeElement
-  ): void {
+  _handleChangeEvent(el: any): void {
     this.handleChangeEvent(el, el.value);
   }
 }

angular/src/directives/control-value-accessors/text-value-accessor.ts

@@ -20,7 +20,7 @@ export class TextValueAccessorDirective extends ValueAccessor {
   }
 
   @HostListener('ionChange', ['$event.target'])
-  _handleInputEvent(el: HTMLIonInputElement | HTMLIonTextareaElement | HTMLIonSearchbarElement): void {
+  _handleInputEvent(el: any): void {
     this.handleChangeEvent(el, el.value);
   }
 }

angular/src/directives/control-value-accessors/value-accessor.ts

@@ -4,8 +4,6 @@ import { Subscription } from 'rxjs';
 
 import { raf } from '../../util/util';
 
-// TODO(FW-2827): types
-
 @Directive()
 export class ValueAccessor implements ControlValueAccessor, AfterViewInit, OnDestroy {
   private onChange: (value: any) => void = () => {

angular/src/directives/navigation/ion-router-outlet.ts

@@ -30,8 +30,6 @@ import { isComponentFactoryResolver } from '../../util/util';
 import { StackController } from './stack-controller';
 import { RouteView, getUrl } from './stack-utils';
 
-// TODO(FW-2827): types
-
 @Directive({
   selector: 'ion-router-outlet',
   exportAs: 'outlet',

angular/src/directives/navigation/stack-controller.ts

@@ -17,8 +17,6 @@ import {
   toSegments,
 } from './stack-utils';
 
-// TODO(FW-2827): types
-
 export class StackController {
   private views: RouteView[] = [];
   private runningTask?: Promise<any>;

angular/src/directives/navigation/stack-utils.ts

@@ -86,7 +86,6 @@ export interface StackEvent {
   tabSwitch: boolean;
 }
 
-// TODO(FW-2827): types
 export interface RouteView {
   id: number;
   url: string;

angular/src/directives/overlays/modal.ts

@@ -108,7 +108,6 @@ export declare interface IonModal extends Components.IonModal {
   ],
 })
 export class IonModal {
-  // TODO(FW-2827): type
   @ContentChild(TemplateRef, { static: false }) template: TemplateRef<any>;
 
   isCmpOpen: boolean = false;

angular/src/directives/overlays/popover.ts

@@ -99,7 +99,6 @@ export declare interface IonPopover extends Components.IonPopover {
   ],
 })
 export class IonPopover {
-  // TODO(FW-2827): type
   @ContentChild(TemplateRef, { static: false }) template: TemplateRef<any>;
 
   isCmpOpen: boolean = false;

angular/src/providers/angular-delegate.ts

@@ -21,8 +21,6 @@ import { EnvironmentInjector } from '../di/r3_injector';
 import { NavParams } from '../directives/navigation/nav-params';
 import { isComponentFactoryResolver } from '../util/util';
 
-// TODO(FW-2827): types
-
 @Injectable()
 export class AngularDelegate {
   constructor(private zone: NgZone, private appRef: ApplicationRef) {}
@@ -30,17 +28,9 @@ export class AngularDelegate {
   create(
     resolverOrInjector: ComponentFactoryResolver,
     injector: Injector,
-    location?: ViewContainerRef,
-    elementReferenceKey?: string
+    location?: ViewContainerRef
   ): AngularFrameworkDelegate {
-    return new AngularFrameworkDelegate(
-      resolverOrInjector,
-      injector,
-      location,
-      this.appRef,
-      this.zone,
-      elementReferenceKey
-    );
+    return new AngularFrameworkDelegate(resolverOrInjector, injector, location, this.appRef, this.zone);
   }
 }
 
@@ -53,29 +43,12 @@ export class AngularFrameworkDelegate implements FrameworkDelegate {
     private injector: Injector,
     private location: ViewContainerRef | undefined,
     private appRef: ApplicationRef,
-    private zone: NgZone,
-    private elementReferenceKey?: string
+    private zone: NgZone
   ) {}
 
   attachViewToDom(container: any, component: any, params?: any, cssClasses?: string[]): Promise<any> {
     return this.zone.run(() => {
       return new Promise((resolve) => {
-        const componentProps = {
-          ...params,
-        };
-
-        /**
-         * Ionic Angular passes a reference to a modal
-         * or popover that can be accessed using a
-         * variable in the overlay component. If
-         * elementReferenceKey is defined, then we should
-         * pass a reference to the component using
-         * elementReferenceKey as the key.
-         */
-        if (this.elementReferenceKey !== undefined) {
-          componentProps[this.elementReferenceKey] = container;
-        }
-
         const el = attachView(
           this.zone,
           this.resolverOrInjector,
@@ -86,7 +59,7 @@ export class AngularFrameworkDelegate implements FrameworkDelegate {
           this.elEventsMap,
           container,
           component,
-          componentProps,
+          params,
           cssClasses
         );
         resolve(el);

angular/src/providers/modal-controller.ts

@@ -21,12 +21,7 @@ export class ModalController extends OverlayBaseController<ModalOptions, HTMLIon
   create(opts: ModalOptions): Promise<HTMLIonModalElement> {
     return super.create({
       ...opts,
-      delegate: this.angularDelegate.create(
-        this.resolver ?? this.environmentInjector,
-        this.injector,
-        undefined,
-        'modal'
-      ),
+      delegate: this.angularDelegate.create(this.resolver ?? this.environmentInjector, this.injector),
     });
   }
 }

angular/src/providers/platform.ts

@@ -3,8 +3,6 @@ import { NgZone, Inject, Injectable } from '@angular/core';
 import { BackButtonEventDetail, KeyboardEventDetail, Platforms, getPlatforms, isPlatform } from '@ionic/core';
 import { Subscription, Subject } from 'rxjs';
 
-// TODO(FW-2827): types
-
 export interface BackButtonEmitter extends Subject<BackButtonEventDetail> {
   subscribeWithPriority(
     priority: number,

angular/src/providers/popover-controller.ts

@@ -21,12 +21,7 @@ export class PopoverController extends OverlayBaseController<PopoverOptions, HTM
   create(opts: PopoverOptions): Promise<HTMLIonPopoverElement> {
     return super.create({
       ...opts,
-      delegate: this.angularDelegate.create(
-        this.resolver ?? this.environmentInjector,
-        this.injector,
-        undefined,
-        'popover'
-      ),
+      delegate: this.angularDelegate.create(this.resolver ?? this.environmentInjector, this.injector),
     });
   }
 }

angular/src/schematics/utils/config.ts

@@ -4,8 +4,6 @@ import { parse } from 'jsonc-parser';
 
 const CONFIG_PATH = 'angular.json';
 
-// TODO(FW-2827): types
-
 export function readConfig(host: Tree): any {
   const sourceText = host.read(CONFIG_PATH)?.toString('utf-8');
   return JSON.parse(sourceText);

angular/src/types/interfaces.ts

@@ -1,5 +1,5 @@
 export interface IonicGlobal {
-  config?: any; // TODO(FW-2827): type
+  config?: any;
   asyncQueue?: boolean;
 }
 

angular/src/util/overlay.ts

@@ -1,5 +1,3 @@
-// TODO(FW-2827): types
-
 interface ControllerShape<Opts, HTMLElm> {
   create(options: Opts): Promise<HTMLElm>;
   dismiss(data?: any, role?: string, id?: string): Promise<boolean>;

angular/test/base/scripts/sync.sh

@@ -2,14 +2,19 @@
 
 set -e
 
-# Pack @ionic/core
-npm pack ../../../../core
+# Copy angular dist
+rm -rf node_modules/@ionic/angular
+cp -a ../../../dist node_modules/@ionic/angular
 
-# Pack @ionic/angular
-npm pack ../../../dist
+# Copy angular server
+rm -rf node_modules/@ionic/angular-server
+cp -a ../../../../packages/angular-server/dist node_modules/@ionic/angular-server
 
-# Pack @ionic/angular-server
-npm pack ../../../../packages/angular-server/dist
-
-# Install Dependencies
-npm install *.tgz --no-save
+# # Copy core dist
+rm -rf node_modules/@ionic/core
+mkdir node_modules/@ionic/core
+cp -a ../../../../core/css node_modules/@ionic/core/css
+cp -a ../../../../core/dist node_modules/@ionic/core/dist
+cp -a ../../../../core/hydrate node_modules/@ionic/core/hydrate
+cp -a ../../../../core/loader node_modules/@ionic/core/loader
+cp -a ../../../../core/package.json node_modules/@ionic/core/package.json

core/CHANGELOG.md

@@ -1,89 +1,16 @@
-
 # Change Log
 
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-## [6.5.3](https://github.com/ionic-team/ionic/compare/v6.5.2...v6.5.3) (2023-02-08)
-
-
-### Bug Fixes
-
-* **button:** size and strong are respected in ion-buttons ([#26726](https://github.com/ionic-team/ionic/issues/26726)) ([3759125](https://github.com/ionic-team/ionic/commit/37591255b4ab3dde5ece6950024a3b66e7224364))
-* **chip:** descenders are not clipped in label ([#26729](https://github.com/ionic-team/ionic/issues/26729)) ([a9e000b](https://github.com/ionic-team/ionic/commit/a9e000b4338f75c27e9284dbe9a6501ba3b213bc)), closes [#18313](https://github.com/ionic-team/ionic/issues/18313)
-* **refresher:** prevent clearing virtual scroll overflow styling ([#26613](https://github.com/ionic-team/ionic/issues/26613)) ([9d6ec29](https://github.com/ionic-team/ionic/commit/9d6ec2925cb2314d5379b864aef467b34afbb318)), closes [#26553](https://github.com/ionic-team/ionic/issues/26553)
-
-
-
-
-
-## [6.5.2](https://github.com/ionic-team/ionic/compare/v6.5.1...v6.5.2) (2023-02-01)
-
-
-### Bug Fixes
-
-* **item:** inherit aria attributes before render ([#26546](https://github.com/ionic-team/ionic/issues/26546)) ([95a3c69](https://github.com/ionic-team/ionic/commit/95a3c69bbbe415cb5f14ac8e1faed287e91b4b40)), closes [#26538](https://github.com/ionic-team/ionic/issues/26538)
-* **popover:** popover opens on chrome 109 ([#26672](https://github.com/ionic-team/ionic/issues/26672)) ([69d89ea](https://github.com/ionic-team/ionic/commit/69d89eae940ccd8b0cca379a961166c4592f34c7)), closes [#26643](https://github.com/ionic-team/ionic/issues/26643)
-* **popover:** resolve import warning in stencil apps ([#26705](https://github.com/ionic-team/ionic/issues/26705)) ([95f65a5](https://github.com/ionic-team/ionic/commit/95f65a5a390eb600de8998c8be9dfd7c023d1eeb)), closes [#26704](https://github.com/ionic-team/ionic/issues/26704)
-* **select:** setting options async updates rendered text ([#26667](https://github.com/ionic-team/ionic/issues/26667)) ([a687457](https://github.com/ionic-team/ionic/commit/a6874579361db548d961fdee83299d664dd6541b)), closes [#19324](https://github.com/ionic-team/ionic/issues/19324)
-
-
-
-
-
-## [6.5.1](https://github.com/ionic-team/ionic/compare/v6.5.0...v6.5.1) (2023-01-25)
-
-
-### Bug Fixes
-
-* **action-sheet:** button icons are not announced by screen readers ([#26640](https://github.com/ionic-team/ionic/issues/26640)) ([22e9ff8](https://github.com/ionic-team/ionic/commit/22e9ff866f8bd7e2e4ca82eae70969ea4f2658df))
-* **fab-button:** icon is not announced by screen readers ([#26619](https://github.com/ionic-team/ionic/issues/26619)) ([dd7cd8c](https://github.com/ionic-team/ionic/commit/dd7cd8c0bfe652d293dc2c2b1bd2a36fd9cf0a0b)), closes [#22296](https://github.com/ionic-team/ionic/issues/22296)
-* **modal, popover:** warn if trigger element was not found ([#26650](https://github.com/ionic-team/ionic/issues/26650)) ([1115203](https://github.com/ionic-team/ionic/commit/11152031202a513121861486e50ea7942b9118d3))
-* **picker-column:** cssClass is set on column ([#26658](https://github.com/ionic-team/ionic/issues/26658)) ([c6620c7](https://github.com/ionic-team/ionic/commit/c6620c7c74abe04c3041e8b256441af72ea12131)), closes [#26653](https://github.com/ionic-team/ionic/issues/26653)
-* **select:** focusing item works in firefox ([#26668](https://github.com/ionic-team/ionic/issues/26668)) ([946807d](https://github.com/ionic-team/ionic/commit/946807d67b972c41b52c23c8f00feca4c705b224))
-* **toggle:** on-off icon is not announced by screen readers ([#26641](https://github.com/ionic-team/ionic/issues/26641)) ([77ccac0](https://github.com/ionic-team/ionic/commit/77ccac059091d5d9f7daf9c7fb01a9e855b86ce3))
-
-
-
-
-
-# [6.5.0](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.5.0) (2023-01-18)
-
-
-### Features
-
-* **deps:** update ionicons to 6.1.0 ([#26617](https://github.com/ionic-team/ionic/issues/26617)) ([ccd2a92](https://github.com/ionic-team/ionic/commit/ccd2a9224e018ad0d67903d44ec312934c3b35ec))
-* **deps:** update ionicons to 6.1.1 ([#26626](https://github.com/ionic-team/ionic/issues/26626)) ([90405eb](https://github.com/ionic-team/ionic/commit/90405eb0af69ce04faf5855189449d0b7518288c))
-* **router:** export hook interfaces ([#26551](https://github.com/ionic-team/ionic/issues/26551)) ([2752702](https://github.com/ionic-team/ionic/commit/27527025e4588f43f9f79640f0929e7c7d0618ee))
-
-
-
-
-
-## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)
-
-
-### Bug Fixes
-
-* **datetime:** allow header to render in all wheel picker presentations ([#26616](https://github.com/ionic-team/ionic/issues/26616)) ([7b947b5](https://github.com/ionic-team/ionic/commit/7b947b5d58ff51a3a6ac360fef6d4df073e1bfec))
-* **input:** clear button uses contrast when setting color on item ([#26592](https://github.com/ionic-team/ionic/issues/26592)) ([a31e1e5](https://github.com/ionic-team/ionic/commit/a31e1e594d4ed7bbcf690b27eee143da232f2bdc)), closes [#26337](https://github.com/ionic-team/ionic/issues/26337)
-* **list:** inset lists render correctly ([#26586](https://github.com/ionic-team/ionic/issues/26586)) ([911b1d4](https://github.com/ionic-team/ionic/commit/911b1d496efe595ddbf8e980f052e505ce9716c2)), closes [#20819](https://github.com/ionic-team/ionic/issues/20819)
-
-
-
-
-
-## [6.4.2](https://github.com/ionic-team/ionic/compare/v6.4.1...v6.4.2) (2023-01-11)
+## [6.4.2-nightly.20230109](https://github.com/ionic-team/ionic/compare/v6.4.1...v6.4.2-nightly.20230109) (2023-01-09)
 
 
 ### Bug Fixes
 
 * **datetime:** time wheel input mode is dismissed on user scroll ([#26567](https://github.com/ionic-team/ionic/issues/26567)) ([d13a146](https://github.com/ionic-team/ionic/commit/d13a14658df2723aff908a94181cb563cb1f5b43))
-* **loading:** support custom aria-label ([#26581](https://github.com/ionic-team/ionic/issues/26581)) ([2450a1e](https://github.com/ionic-team/ionic/commit/2450a1e821d3901c8efb57ec256a10a951d22c8f)), closes [#24486](https://github.com/ionic-team/ionic/issues/24486)
 * **modal:** canDismiss type with data and role ([#26547](https://github.com/ionic-team/ionic/issues/26547)) ([32c2622](https://github.com/ionic-team/ionic/commit/32c2622ab04a70d00684e9a813d9bcef698d7551)), closes [#26544](https://github.com/ionic-team/ionic/issues/26544)
 * **picker-column-internal:** blurring picker does not throw error ([#26560](https://github.com/ionic-team/ionic/issues/26560)) ([3e671b9](https://github.com/ionic-team/ionic/commit/3e671b9c8ff62945a12eff431839ddae37d9d1a7)), closes [#26559](https://github.com/ionic-team/ionic/issues/26559)
-* **segment:** nested interactive is not rendered ([#26575](https://github.com/ionic-team/ionic/issues/26575)) ([77ce9e0](https://github.com/ionic-team/ionic/commit/77ce9e066e1ee71438ceac35479ea04e8df021f5))
-* **tab-button:** nested interactives are not rendered ([#26576](https://github.com/ionic-team/ionic/issues/26576)) ([df4882d](https://github.com/ionic-team/ionic/commit/df4882d4d1c516038badfa647db484e070fbd099)), closes [#23332](https://github.com/ionic-team/ionic/issues/23332)
 
 
 

core/README.md

@@ -1,7 +1,3 @@
-
-
-third commit
-
 # @ionic/core
 
 [Ionic](https://ionicframework.com/) is an open source App Development Framework that makes it easy to build top quality Native and Progressive Web Apps with web technologies.

core/api.txt

@@ -193,6 +193,8 @@ ion-breadcrumbs,prop,itemsBeforeCollapse,number,1,false,false
 ion-breadcrumbs,prop,maxItems,number | undefined,undefined,false,false
 ion-breadcrumbs,prop,mode,"ios" | "md",undefined,false,false
 ion-breadcrumbs,event,ionCollapsedClick,BreadcrumbCollapsedClickEventDetail,true
+ion-breadcrumbs,css-prop,--background
+ion-breadcrumbs,css-prop,--color
 
 ion-button,shadow
 ion-button,prop,buttonType,string,'button',false,false

core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ionic/core",
-  "version": "6.5.3",
+  "version": "6.4.2-nightly.20230109",
   "description": "Base components for Ionic",
   "keywords": [
     "ionic",
@@ -32,7 +32,7 @@
   ],
   "dependencies": {
     "@stencil/core": "^2.18.0",
-    "ionicons": "^6.1.1",
+    "ionicons": "^6.0.4",
     "tslib": "^2.1.0"
   },
   "devDependencies": {
@@ -46,7 +46,7 @@
     "@stencil/angular-output-target": "^0.4.0",
     "@stencil/react-output-target": "^0.2.1",
     "@stencil/sass": "^2.0.0",
-    "@stencil/vue-output-target": "^0.7.0",
+    "@stencil/vue-output-target": "^0.6.2",
     "@types/jest": "^27.5.2",
     "@types/node": "^14.6.0",
     "@types/swiper": "5.4.0",

core/src/components.d.ts

@@ -2484,7 +2484,6 @@ export namespace Components {
           * The mode determines which platform styles to use.
          */
         "mode"?: "ios" | "md";
-        "setFocus": () => Promise<void>;
         /**
           * The type of the button.
          */

core/src/components/action-sheet/action-sheet.tsx

@@ -287,7 +287,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
               {buttons.map((b) => (
                 <button type="button" id={b.id} class={buttonClass(b)} onClick={() => this.buttonClick(b)}>
                   <span class="action-sheet-button-inner">
-                    {b.icon && <ion-icon icon={b.icon} aria-hidden="true" lazy={false} class="action-sheet-icon" />}
+                    {b.icon && <ion-icon icon={b.icon} lazy={false} class="action-sheet-icon" />}
                     {b.text}
                   </span>
                   {mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
@@ -299,9 +299,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
               <div class="action-sheet-group action-sheet-group-cancel">
                 <button type="button" class={buttonClass(cancelButton)} onClick={() => this.buttonClick(cancelButton)}>
                   <span class="action-sheet-button-inner">
-                    {cancelButton.icon && (
-                      <ion-icon icon={cancelButton.icon} aria-hidden="true" lazy={false} class="action-sheet-icon" />
-                    )}
+                    {cancelButton.icon && <ion-icon icon={cancelButton.icon} lazy={false} class="action-sheet-icon" />}
                     {cancelButton.text}
                   </span>
                   {mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}

core/src/components/alert/alert-interface.ts

@@ -30,7 +30,7 @@ export interface AlertInput {
   type?: TextFieldTypes | 'checkbox' | 'radio' | 'textarea';
   name?: string;
   placeholder?: string;
-  value?: any; // TODO(FW-2832): type
+  value?: any;
   label?: string;
   checked?: boolean;
   disabled?: boolean;
@@ -60,6 +60,5 @@ export interface AlertButton {
   role?: 'cancel' | 'destructive' | string;
   cssClass?: string | string[];
   id?: string;
-  // TODO(FW-2832): type
   handler?: (value: any) => AlertButtonOverlayHandler | Promise<AlertButtonOverlayHandler>;
 }

core/src/components/alert/alert.tsx

@@ -25,8 +25,6 @@ import { iosLeaveAnimation } from './animations/ios.leave';
 import { mdEnterAnimation } from './animations/md.enter';
 import { mdLeaveAnimation } from './animations/md.leave';
 
-// TODO(FW-2832): types
-
 /**
  * @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use.
  */

core/src/components/app/app.tsx

@@ -10,7 +10,7 @@ import { isPlatform } from '../../utils/platform';
   styleUrl: 'app.scss',
 })
 export class App implements ComponentInterface {
-  private focusVisible?: any; // TODO(FW-2832): type
+  private focusVisible?: any;
 
   @Element() el!: HTMLElement;
 

core/src/components/breadcrumbs/breadcrumbs.scss

@@ -4,6 +4,10 @@
 // --------------------------------------------------
 
 :host {
+  /**
+   * @prop --background: Background of the breadcrumbs
+   * @prop --color: Text color of the breadcrumbs
+   */
   @include font-smoothing();
 
   display: flex;

core/src/components/button/button.ios.scss

@@ -1,6 +1,5 @@
 @import "./button";
 @import "./button.ios.vars";
-@import "../toolbar/toolbar.ios.vars";
 
 
 // iOS Button
@@ -24,20 +23,6 @@
   letter-spacing: #{$button-ios-letter-spacing};
 }
 
-/**
- * The default buttons in a toolbar
- * have a different font size/weight
- * than buttons outside of a toolbar on iOS.
- * However, we still want the "size"/"strong"
- * properties to be usable in a toolbar, so we add
- * the .in-buttons selector such that we
- * can add the different font size/weight in a toolbar
- * but still let "size"/"strong" override it.
- */
-:host(.in-buttons) {
-  font-size: #{$toolbar-ios-button-font-size};
-  font-weight: 400;
-}
 
 // iOS Solid Button
 // --------------------------------------------------

core/src/components/button/button.tsx

@@ -293,7 +293,6 @@ export class Button implements ComponentInterface, AnchorInterface, ButtonInterf
           [`${buttonType}-strong`]: strong,
           'in-toolbar': hostContext('ion-toolbar', this.el),
           'in-toolbar-color': hostContext('ion-toolbar[color]', this.el),
-          'in-buttons': hostContext('ion-buttons', this.el),
           'button-has-icon-only': hasIconOnly,
           'button-disabled': disabled,
           'ion-activatable': true,

core/src/components/button/test/size/button.e2e.ts

@@ -2,53 +2,11 @@ import { expect } from '@playwright/test';
 import { test } from '@utils/test/playwright';
 
 test.describe('button: size', () => {
-  test.beforeEach(({ skip }) => {
-    skip.rtl();
-  });
-  test('should render small buttons', async ({ page }) => {
-    await page.setContent(`
-      <ion-button size="small" fill="solid">Small Button</ion-button>
-    `);
+  test('should not have visual regressions', async ({ page }) => {
+    await page.goto(`/src/components/button/test/size`);
 
-    const wrapper = page.locator('ion-button');
+    await page.setIonViewport();
 
-    expect(await wrapper.screenshot()).toMatchSnapshot(`button-size-small-${page.getSnapshotSettings()}.png`);
-  });
-  test('should render large buttons', async ({ page }) => {
-    await page.setContent(`
-      <ion-button size="large" fill="solid">Large Button</ion-button>
-    `);
-
-    const wrapper = page.locator('ion-button');
-
-    expect(await wrapper.screenshot()).toMatchSnapshot(`button-size-large-${page.getSnapshotSettings()}.png`);
-  });
-  test.describe('in ion-buttons', () => {
-    test('should render small button', async ({ page }) => {
-      await page.setContent(`
-        <ion-buttons>
-          <ion-button size="small" fill="solid">Small Button</ion-button>
-        </ion-buttons>
-      `);
-
-      const wrapper = page.locator('ion-button');
-
-      expect(await wrapper.screenshot()).toMatchSnapshot(
-        `button-size-small-in-buttons-${page.getSnapshotSettings()}.png`
-      );
-    });
-    test('should render large button', async ({ page }) => {
-      await page.setContent(`
-        <ion-buttons>
-          <ion-button size="large" fill="solid">Large Button</ion-button>
-        </ion-buttons>
-      `);
-
-      const wrapper = page.locator('ion-button');
-
-      expect(await wrapper.screenshot()).toMatchSnapshot(
-        `button-size-large-in-buttons-${page.getSnapshotSettings()}.png`
-      );
-    });
+    expect(await page.screenshot()).toMatchSnapshot(`button-size-${page.getSnapshotSettings()}.png`);
   });
 });

core/src/components/button/test/size/index.html

@@ -18,11 +18,6 @@
     <ion-app>
       <ion-header>
         <ion-toolbar>
-          <ion-buttons slot="start">
-            <ion-button fill="solid">Default Button</ion-button>
-            <ion-button fill="solid" size="small">Small Button</ion-button>
-            <ion-button fill="solid" size="large">Large Button</ion-button>
-          </ion-buttons>
           <ion-title>Button - Size</ion-title>
         </ion-toolbar>
       </ion-header>

core/src/components/button/test/strong/button.e2e.ts

@@ -1,57 +1,12 @@
 import { expect } from '@playwright/test';
 import { test } from '@utils/test/playwright';
 
-/**
- * Clear buttons have special font-weight
- * styles which is why we make sure
- * to capture the clear button here.
- */
 test.describe('button: strong', () => {
-  test.beforeEach(({ skip }) => {
-    skip.rtl();
-  });
-  test('should render strong button', async ({ page }) => {
-    await page.setContent(`
-      <ion-button fill="solid" strong="true">Button</ion-button>
-    `);
+  test('should not have visual regressions', async ({ page }) => {
+    await page.goto(`/src/components/button/test/strong`);
 
-    const wrapper = page.locator('ion-button');
+    await page.setIonViewport();
 
-    expect(await wrapper.screenshot()).toMatchSnapshot(`button-strong-${page.getSnapshotSettings()}.png`);
-  });
-  test('should render strong clear button', async ({ page }) => {
-    await page.setContent(`
-      <ion-button fill="clear" strong="true">Button</ion-button>
-    `);
-
-    const wrapper = page.locator('ion-button');
-
-    expect(await wrapper.screenshot()).toMatchSnapshot(`button-clear-strong-${page.getSnapshotSettings()}.png`);
-  });
-  test.describe('in ion-buttons', () => {
-    test('should render strong button', async ({ page }) => {
-      await page.setContent(`
-        <ion-buttons>
-          <ion-button strong="true" fill="solid">Button</ion-button>
-        </ion-buttons>
-      `);
-
-      const wrapper = page.locator('ion-button');
-
-      expect(await wrapper.screenshot()).toMatchSnapshot(`button-strong-in-buttons-${page.getSnapshotSettings()}.png`);
-    });
-    test('should render strong clear button', async ({ page }) => {
-      await page.setContent(`
-        <ion-buttons>
-          <ion-button strong="true" fill="clear">Button</ion-button>
-        </ion-buttons>
-      `);
-
-      const wrapper = page.locator('ion-button');
-
-      expect(await wrapper.screenshot()).toMatchSnapshot(
-        `button-clear-strong-in-buttons-${page.getSnapshotSettings()}.png`
-      );
-    });
+    expect(await page.screenshot()).toMatchSnapshot(`button-strong-${page.getSnapshotSettings()}.png`);
   });
 });