Brandy Carney
db94ef606f
test(rtl): do not set dir to ltr by default, add reorder e2e
2017-05-12 16:43:33 -04:00
Amit Moryossef
a30379bef6
feat(rtl): add rtl margin, padding, position and border-radius ( #11342 )
...
* refactor(item): replaced item-left with item-start
replaced item-right with item-end
* style(item): fix spacing
* fix(item): add backwards support for left/right in ng-content
* fix(item): deprecated old variables, not breaking change
* feat(rtl): padding mixin
* feat(rtl): change all padding variables to start/end
add support for old variable names
* feat(rtl): replace all padding-side with start/end
* revert(functions): remove mixins
* feat(scss): add padding-horizontal and rtl functions (thanks brandy)
* feat(padding): use padding horizontal mixin everywhere
* feat(padding): use padding horizontal mixin everywhere
* fix(lint): change properties order. tests passing
* fix(sass-functions): reorder functions to avoid warning
* fix(scss): fix variable name
* perf(rtl): add check if need rtl selector
* feat(scss): add full padding function
* feat(scss): add border-radius mixin
* fix(rtl): change border-radius to use mixin
* perf(scss): only override if has something to override
* feat(scss): add margin scss variables for sides
* feat(scss): add margin mixin
* fix(scss): fix wrong support for 2/3 args
* feat(rtl): spread margins/paddings
* feat(rtl): spread margins/paddings
* feat(position): add rtl support for absolute
* fix(rtl): add missing calls
* fix(item): old attributes deprecated support
* revert(changelog): not intended to be changed
* fix(sass-functions): and not &&
* fix(padding): merge + missing padding
* style(): remove newline
* refactor(mixins): move mixins to mixins file
* style(): fix alignment
* fix(item): right padding should not be set
* fix(): incorrect defaults
* feat(scss-lint): disable some side variables
* fix(scss): lint passes
* feat(lint): disabled text-align
* fix(): correct variable name
* fix(fab): missed a comma
* fix(rtl): rtl method incorrect for multiple selectors
* fix(rtl): toolbar bad merge
* fix(rtl): icon-only is in px not em
* fix(rtl): toggle padding
* feat(rtl): correct notation for rtl custom
* Merge branch 'breaking-item' into start-end
# Conflicts:
# src/components/checkbox/checkbox.ios.scss
# src/components/checkbox/checkbox.md.scss
# src/components/checkbox/checkbox.wp.scss
# src/components/item/item.ios.scss
# src/components/item/item.md.scss
# src/components/item/item.wp.scss
# src/components/radio/radio.ios.scss
# src/components/radio/radio.md.scss
# src/components/radio/radio.wp.scss
# src/components/toggle/toggle.ios.scss
# src/components/toggle/toggle.md.scss
# src/components/toggle/toggle.wp.scss
* fix(scss): fix for deprecated usages
2017-05-12 13:05:45 -04:00
Brandy Carney
2c66c56d69
fix(label): set the ios variables to null to avoid styling
...
fixes #11631
2017-05-12 12:21:50 -04:00
Kulshekhar Kabra
4347627f26
fix(searchbar): update signature mismatch in template & class ( #11599 )
...
fixes #11598
2017-05-11 12:19:37 -04:00
Brandy Carney
3139c97571
test(content): update content no-bounce e2e test
2017-05-10 13:35:21 -04:00
Kendall González León
120c85d74e
docs(alert): imported AlertController in usage example ( #11567 )
...
Added an importation for use the alert controller on line 52.
2017-05-09 18:49:01 -04:00
Brandy Carney
cbe0b42e74
fix(button): display box shadow correctly for Chrome
...
See the following bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=713674
References #11585
2017-05-09 15:50:30 -04:00
Manu Mtz.-Almeida
f893aa6774
fix(virtual-scroll): remove duplicate items
2017-05-09 18:33:50 +02:00
imgx64
5a895bb099
fix(datetime): Fix floating label with empty ion-datetime ( #11552 )
...
Fixes #11547
2017-05-08 14:59:10 +02:00
Ibby Hadeed
5fbca0ef7c
docs(loading): mark params as optional
...
Closes #11452
2017-05-05 12:53:12 -04:00
JamesM
51ced8bec2
docs(virtual-scroll) fix typo in virtual scroll ( #11533 )
2017-05-05 12:16:07 -04:00
Amit Moryossef
26c653e43e
feat(item): deprecate item-left / item-right attributes for item-start / item-end ( #11125 )
...
item-start and item-end make more sense for RTL
* refactor(item): replaced item-left with item-start
replaced item-right with item-end
* style(item): fix spacing
* fix(item): add backwards support for left/right in ng-content
* fix(item): deprecated old variables, not breaking change
* fix(scss): fix variable name
* fix(item): old attributes deprecated support
2017-05-05 11:53:32 -04:00
Manuel Mtz-Almeida
6d11499417
fix(view-controller): _dismissRole is a string
2017-05-05 01:55:50 +02:00
Manuel Mtz-Almeida
df8d1cc389
fix(tap-click): updates setupTapClick signature
2017-05-05 01:50:17 +02:00
Manu Mtz.-Almeida
8baa6474a4
perf(virtual-scroll): fast path for removing
2017-05-05 01:42:30 +02:00
Manuel Mtz-Almeida
88e5642f60
perf(virtual-list): relaxed restrictions for fast path
2017-05-05 01:40:58 +02:00
Manu MA
325cc5eea7
feat(wk): built-in support for WK ( #11048 )
2017-05-05 01:31:42 +02:00
Amit Moryossef
5d562166fc
refactor(): global refactoring to avoid IDE warnings and cleaner code ( #11296 )
...
* refactor(style): redundant measure units
* refactor(): change pointless boolean operation to cast
* refactor(): change redundant 'if' statement
* refactor(style): remove overwritten property value
* fix(spellcheck): wrong attribute value
* refactor(datetime-test): There should be a space between attribute and previous attribute
* refactor(import): import can be shortened
* refactor(semicolon): add missing semicolon
* docs(): fix incorrect parameter name
* refactor(): remove trailing unused parameters
* fix(menu): create mock change signature
* refactor(): remove redundant imports
all tests are passing
* refactor(style): 'var' used instead of 'let' or 'const'
* Revert "refactor(style): 'var' used instead of 'let' or 'const'"
This reverts commit 0369dbcaa8
2017-05-05 01:11:00 +02:00
Manuel Mtz-Almeida
3b4b29e832
refactor(action-sheet): adds proper TS types
2017-05-05 01:01:49 +02:00
Manuel Mtz-Almeida
7f7c3cd514
Merge branch 'master' of github.com:driftyco/ionic; branch 'onDidDismiss-doc' of https://github.com/icedt89/ionic
2017-05-05 00:32:10 +02:00
Manuel Mtz-Almeida
de19dbe81b
fix(virtual-list): virtualTrackBy reference
2017-05-05 00:24:33 +02:00
Michael Asimakopoulos
299a68bcdc
fix(VirtualScroll): initialise differ with trackByFn ( #11492 )
...
* fix(VirtualScroll): initialise differ with trackByFn
* fix(VirtualScroll): DRY up differ initialization
2017-05-05 00:20:58 +02:00
AndreasGassmann
646d736d07
fix(navcontrollerbase): popToRoot should not remove root view
2017-05-05 00:17:30 +02:00
Jan Hafner
abf6bd1f68
- typified onDidDismiss and onWillDismiss signature to clearify supplied parameters
2017-05-04 21:23:19 +02:00
Szymon Stasik
59dd853f54
fix(select): firing events properly in popover interface
2017-05-03 12:27:13 +02:00
Amit Moryossef
424b15aefd
fix(rtl): add correct text-align ( #11353 )
...
* fix(rtl): add correct text-align
* feat(text-align): add mixin for backwards compatibility of variables
* fix(text-align): default null not empty string
* fix(text-align): remove default
2017-05-02 11:10:18 -04:00
Markus Wagner
6b42677460
docs(alert): add default value for enableBackdropDismiss
...
Closes #11370
2017-05-01 14:51:44 -04:00
Martijn Luyckx
e66c54958b
docs(events): update demo in usage
...
Closes #11428
Make it clear that event.subscribe must be called in another method
2017-05-01 14:21:50 -04:00
Amit Moryossef
6add05e31a
doc(haptic): fix typo ( #11461 )
2017-05-01 18:12:55 +02:00
Brandy Carney
b96e31bf30
test(app): update typography e2e test to work
2017-05-01 11:11:05 -04:00
Ibby Hadeed
d701799d8b
refactor(nav-interfaces): remove unecessary semicolons ( #11450 )
2017-05-01 02:35:46 +02:00
Hayden Braxton
a04b577f1d
feat(select): close select programatically
...
* implement ability to close select programmatically
* refactor(select): made changes based on PR feedback, namely assigning overlay to the overlay property at then end of the open function, applying DeMorgan's Law to a condition, and returning the overlay dismiss promise from the close function
* refactor(select): made additional changes to closing select component programmatically to resolve issue 11318
2017-05-01 02:34:38 +02:00
Manu Mtz.-Almeida
2afc5cfeda
fix(module-loader): null references
2017-05-01 02:27:34 +02:00
Manu Mtz.-Almeida
45e71a67b5
Merge branch 'fix-preloading' of https://github.com/soumak77/ionic
2017-05-01 02:21:02 +02:00
Manu Mtz.-Almeida
ed66591db6
test(view-controller): adds isOverlay asserts
2017-05-01 02:19:35 +02:00
Brian Soumakian
19a3b6616e
add unit tests
2017-04-30 15:24:09 -07:00
Brian Soumakian
bc4a1cab66
Merge branch 'driftyco/master' into fix-preloading
2017-04-30 14:30:13 -07:00
Amit Moryossef
665e44f633
fix(rtl): change item reorder offset for RTL ( #11395 )
2017-04-30 18:09:55 +02:00
Brandy Carney
588fad879f
fix(label): add the $label-ios-text-color sass variables back
...
adds better descriptions for the sass variables in the other modes
resolves #11373
2017-04-28 18:18:57 -04:00
Manuel Mtz-Almeida
ec2a34db6e
fix(select): incorrect assert condition
2017-04-28 20:47:27 +02:00
Justin Willis
aff2f08f9a
test(datetime): add unit tests to make sure we return a string when we should ( #11431 )
...
* test(datetime): add e2e test with no format provided
* test(datetime): add test to check output is a string
* test(datetime): add e2e test with no format provided
* test(datetime): add test to check output is a string
* test(datetime): add unit tests to make sure we return a string when we should
2017-04-28 11:11:05 -05:00
Manuel Mtz-Almeida
539901da83
fix(toggle): initialize at ngAfterContentInit
2017-04-28 17:23:36 +02:00
Manuel Mtz-Almeida
7eb2f0b343
fix(menu): missing output events in interface
...
fixes #11383
2017-04-27 23:45:20 +02:00
Manuel Mtz-Almeida
239b559e6e
fix(base-input): initialize on ngAfterContentInit
2017-04-27 23:44:12 +02:00
Manuel Mtz-Almeida
6677d80343
fix(datetime): ngModel always returns a string
2017-04-27 22:16:37 +02:00
Manuel Mtz-Almeida
4c8efc22e1
fix(select): object as value
...
fixes : #11413
2017-04-27 21:27:52 +02:00
Dan Bucholtz
b11442716b
test(input): basic e2e test of a sample form to validate the next button/arrow goes to next input ( #11362 )
...
basic e2e test of a sample form to validate the next button/arrow goes to next input field
2017-04-27 13:31:59 -05:00
Manuel Mtz-Almeida
991cadbe85
test(select): disable unit test
2017-04-27 19:07:20 +02:00
Manuel Mtz-Almeida
af394b5ef6
fix(datetime): ionChange/ngModel returns the correct value
2017-04-27 19:06:59 +02:00
Manuel Mtz-Almeida
505d27ad34
fix(base-input): first ngModel update is not dispatched
2017-04-27 18:35:08 +02:00
