Commit Graph

3545 Commits

Author SHA1 Message Date
Maria Hutt
a35886e71c fix(menu): update location when dynamically changing side or doc dir (#27079)
## Pull request checklist

Please check if your PR fulfills the following requirements:
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug
fixes / features)
- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See the [contributing
guide](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation)
for details.
- [x] Build (`npm run build`) was run locally and any changes were
pushed
- [x] Lint (`npm run lint`) has passed locally and any fixes were made
for failures


## Pull request type

Please check the type of change your PR introduces:
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe): 


## What is the current behavior?

- When the document direction is dynamically changed, the menu does not
switch to the correct position. For example, `<ion-menu side='start'>`
will always be on the left side regardless of direction.
- When the side property is dynamically changed, the animation starts in
the middle of the screen instead of off screen.

Issue URL: resolves #25601 #19489 


## What is the new behavior?

- Animation is smooth regardless of side property or document direction
being dynamically change.
- Menu appears on the correct side based on document direction when
dynamically updated.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

N/A

---------

Co-authored-by: ionitron <hi@ionicframework.com>
2023-04-04 19:03:13 +00:00
Brandy Carney
4e7424de03 fix(picker-column-internal): hide empty picker items from screenreaders (#27038)
* fix(picker-column): hide empty picker items from screenreaders

fixes #26809

* style(picker-column-internal): run lint

---------

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-04 17:49:53 +00:00
Shawn Taylor
adbb50ca5b fix(refresher): set overflow styles when using custom scroll target (#27058)
* bug(refresher): set overflow styles when using custom scroll target

* bug(refresher): set overflow styles when using custom scroll target

* Apply suggestions from code review

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

* Add comment

---------

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-04 16:04:50 +00:00
dependabot[bot]
5e35bfc955 chore(deps-dev): bump @playwright/test from 1.32.1 to 1.32.2 in /core (#27110)
* chore(deps-dev): bump @playwright/test from 1.32.1 to 1.32.2 in /core

Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.32.1 to 1.32.2.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](https://github.com/Microsoft/playwright/compare/v1.32.1...v1.32.2)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(): update playwright-core dep

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-04 15:48:48 +00:00
dependabot[bot]
ab5e1ce2d9 chore(deps): bump @stencil/core from 3.1.0 to 3.2.0 in /core (#27074)
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/ionic-team/stencil/releases)
- [Changelog](https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ionic-team/stencil/compare/v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: "@stencil/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-03 19:16:22 +00:00
dependabot[bot]
a3b7e1e37f chore(deps-dev): bump @axe-core/playwright from 4.6.0 to 4.6.1 in /core (#27044)
Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/dequelabs/axe-core-npm/releases)
- [Changelog](https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/dequelabs/axe-core-npm/compare/v4.6.0...v4.6.1)

---
updated-dependencies:
- dependency-name: "@axe-core/playwright"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-03 19:12:50 +00:00
Maria Hutt
f8667830dc test(breadcrumbs): check color attribute renders in the DOM (#27080)
Co-authored-by: liamdebeasi <liamdebeasi@users.noreply.github.com>
2023-04-03 11:35:14 -07:00
Maria Hutt
d939ad36e3 test(textarea): skip autogrow test due to flakiness (#27100) 2023-04-03 09:38:56 -07:00
Shawn Taylor
426913d0de fix(item-divider): set padding-end for md (#27019)
closes #23785
2023-03-31 17:00:12 -04:00
Amanda Johnston
75186d3f83 docs(content): fix typo in forceOverscroll description (#27077) 2023-03-31 10:17:36 -05:00
Sean Perkins
141ced5010 fix(breadcrumbs): color attribute shows on DOM for Vue (#27068)
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
2023-03-30 17:11:22 -04:00
Liam DeBeasi
14145dcaeb fix(vue): v-model props have correct type (#27067)
resolves #27057
2023-03-30 14:32:19 -04:00
Sean Perkins
abadeedc9e Revert "bug(breadcrumbs): color attribute shows on DOM for Vue (#27040)" (#27069)
This reverts commit dd419c0066.

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
2023-03-30 13:50:34 -04:00
Maria Hutt
dd419c0066 bug(breadcrumbs): color attribute shows on DOM for Vue (#27040)
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-03-30 09:57:02 -07:00
ionitron
b6e3d587b9 v7.0.0 2023-03-29 17:00:15 +00:00
Liam DeBeasi
a4fa2d5b97 chore(): clean up changelogs 2023-03-29 10:16:16 -04:00
ionitron
5f53a0a63a v7.0.0-rc.5 2023-03-29 14:12:26 +00:00
ionitron
8ff83b8098 chore(): add updated snapshots 2023-03-29 13:40:26 +00:00
Liam DeBeasi
f750c8756f chore(): sync with main 2023-03-29 09:17:21 -04:00
ionitron
661b5de825 v6.7.1 2023-03-29 12:47:04 +00:00
Sean Perkins
ee19891542 fix(select): update iOS icon (#27001) 2023-03-28 16:49:14 -04:00
Liam DeBeasi
521063bf24 fix(item-sliding): open method works with items added async (#27035)
resolves #26991
2023-03-28 12:53:36 -04:00
Liam DeBeasi
c9e4cd002d chore(): update playwright (#27037) 2023-03-28 12:30:34 -04:00
Liam DeBeasi
408457aa95 fix(select): alert header defaults to label (#27034)
resolves #27028
2023-03-28 11:09:42 -04:00
Amanda Johnston
0a04310f11 test(popover): re-enable size test (#27033) 2023-03-28 09:20:28 -05:00
dependabot[bot]
9ba8f0a53f chore(deps-dev): bump @playwright/test from 1.32.0 to 1.32.1 in /core (#27036)
Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.32.0 to 1.32.1.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](https://github.com/Microsoft/playwright/compare/v1.32.0...v1.32.1)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-28 09:18:39 -04:00
Liam DeBeasi
5c0ead37bf docs(config): update innerHTML comments (#27032) 2023-03-27 15:14:02 -04:00
Ryan Waskiewicz
ae482823e5 chore(dev-deps): update stencil framework wrappers (#27031)
this commit updates the stencil framework wrappers to the latest
published versions of the library. each of the wrappers have been
updated such that their peer dependencies no longer require
'3.0.0-beta.0', and now require '3.0.0'
2023-03-27 13:49:04 -04:00
Liam DeBeasi
6a06354798 chore(): clean up changelog 2023-03-27 12:20:41 -04:00
ionitron
ae173317ec v7.0.0-rc.4 2023-03-27 16:15:39 +00:00
Liam DeBeasi
b7e46038e0 fix(many): innerHTML is disabled by default (#27029)
BREAKING CHANGE:

The `innerHTMLTemplatesEnabled` Ionic Config now defaults to `false`. Developers can set this option to `true` if they would like to continue to use custom HTML features in `ion-alert`, `ion-infinite-scroll-content`, `ion-loading`, `ion-refresher-content`, and `ion-toast`.
2023-03-27 12:07:00 -04:00
Liam DeBeasi
f68644065c test(datetime): display tests wait for class (#27017) 2023-03-27 09:47:28 -04:00
Maria Hutt
a396e8857b refactor(alert): switch ev.code to ev.key (#27023) 2023-03-24 13:31:30 -07:00
Liam DeBeasi
e9208eae53 chore(): update textarea test 2023-03-24 16:22:30 -04:00
ionitron
8b1a41646e chore(): add updated snapshots 2023-03-24 19:59:09 +00:00
Maria Hutt
1ea0893643 refactor(radio-group): switch ev.code to ev.key (#27021)
Co-authored-by: Sean Perkins <sean@ionic.io>
2023-03-24 12:43:04 -07:00
Liam DeBeasi
317f4eefec test(select): update wrapping tests for v7 2023-03-24 19:37:27 +00:00
Liam DeBeasi
4349f1c2c8 test(datetime): update timezone test for v7 2023-03-24 19:13:12 +00:00
ionitron
83537bc5cf chore(): add updated snapshots 2023-03-24 18:59:37 +00:00
Liam DeBeasi
eb10a2e5f6 chore(): sync with main 2023-03-24 14:37:39 -04:00
Maria Hutt
6cecdf4145 fix(item): use thumbnail's size when present (#27014)
resolves #22935

---------

Co-authored-by: ionitron <hi@ionicframework.com>
Co-authored-by: liamdebeasi <liamdebeasi@users.noreply.github.com>
2023-03-24 11:32:14 -07:00
Liam DeBeasi
3b99c31bab fix(radio-group): radios participate in form submission (#27018)
resolves #27016
2023-03-24 12:43:30 -04:00
Shawn Taylor
739f5706db test(datetime): add tests for parseDate (#27015) 2023-03-24 11:57:55 -04:00
Brandy Carney
19c1e25399 fix(select): inherit white-space in select-text to allow text wrapping (#26973)
fixes #19949

Co-authored-by: Shreyas <telishreyas10@gmail.com>
2023-03-24 10:53:25 -04:00
Liam DeBeasi
e23fd9ecee fix(fab, tab-button): rtl alignment in safari and firefox (#26986)
resolves #22739
2023-03-23 17:17:09 -04:00
Liam DeBeasi
3e0a905e81 fix(segment): change event fires when clicking (#27010)
resolves #27002
2023-03-23 16:18:43 -04:00
dependabot[bot]
53af005122 chore(deps-dev): bump @playwright/test from 1.31.2 to 1.32.0 in /core (#27003) 2023-03-23 12:44:59 -04:00
ionitron
f2ea05d9a2 v6.7.0 2023-03-23 14:42:57 +00:00
Liam DeBeasi
cac3ad4c84 Merge remote-tracking branch 'origin/main' into sync-67-23 2023-03-23 09:17:19 -04:00
Sean Perkins
26a7e86338 test(ripple-effect): reduce flakiness (#26985) 2023-03-22 15:37:00 -04:00