Commit Graph

12666 Commits

Author SHA1 Message Date
Maria Hutt
a35886e71c fix(menu): update location when dynamically changing side or doc dir (#27079)
## Pull request checklist

Please check if your PR fulfills the following requirements:
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug
fixes / features)
- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See the [contributing
guide](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation)
for details.
- [x] Build (`npm run build`) was run locally and any changes were
pushed
- [x] Lint (`npm run lint`) has passed locally and any fixes were made
for failures


## Pull request type

Please check the type of change your PR introduces:
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe): 


## What is the current behavior?

- When the document direction is dynamically changed, the menu does not
switch to the correct position. For example, `<ion-menu side='start'>`
will always be on the left side regardless of direction.
- When the side property is dynamically changed, the animation starts in
the middle of the screen instead of off screen.

Issue URL: resolves #25601 #19489 


## What is the new behavior?

- Animation is smooth regardless of side property or document direction
being dynamically change.
- Menu appears on the correct side based on document direction when
dynamically updated.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

N/A

---------

Co-authored-by: ionitron <hi@ionicframework.com>
2023-04-04 19:03:13 +00:00
Brandy Carney
4e7424de03 fix(picker-column-internal): hide empty picker items from screenreaders (#27038)
* fix(picker-column): hide empty picker items from screenreaders

fixes #26809

* style(picker-column-internal): run lint

---------

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-04 17:49:53 +00:00
Shawn Taylor
adbb50ca5b fix(refresher): set overflow styles when using custom scroll target (#27058)
* bug(refresher): set overflow styles when using custom scroll target

* bug(refresher): set overflow styles when using custom scroll target

* Apply suggestions from code review

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

* Add comment

---------

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-04 16:04:50 +00:00
dependabot[bot]
5e35bfc955 chore(deps-dev): bump @playwright/test from 1.32.1 to 1.32.2 in /core (#27110)
* chore(deps-dev): bump @playwright/test from 1.32.1 to 1.32.2 in /core

Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.32.1 to 1.32.2.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](https://github.com/Microsoft/playwright/compare/v1.32.1...v1.32.2)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(): update playwright-core dep

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-04 15:48:48 +00:00
Liam DeBeasi
b1f5853cf0 chore(): update PR template (#27109)
* Update PULL_REQUEST_TEMPLATE.md

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>

---------

Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
2023-04-03 19:26:04 +00:00
dependabot[bot]
ab5e1ce2d9 chore(deps): bump @stencil/core from 3.1.0 to 3.2.0 in /core (#27074)
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/ionic-team/stencil/releases)
- [Changelog](https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ionic-team/stencil/compare/v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: "@stencil/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-03 19:16:22 +00:00
dependabot[bot]
a3b7e1e37f chore(deps-dev): bump @axe-core/playwright from 4.6.0 to 4.6.1 in /core (#27044)
Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/dequelabs/axe-core-npm/releases)
- [Changelog](https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/dequelabs/axe-core-npm/compare/v4.6.0...v4.6.1)

---
updated-dependencies:
- dependency-name: "@axe-core/playwright"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-03 19:12:50 +00:00
Maria Hutt
f8667830dc test(breadcrumbs): check color attribute renders in the DOM (#27080)
Co-authored-by: liamdebeasi <liamdebeasi@users.noreply.github.com>
2023-04-03 11:35:14 -07:00
Maria Hutt
d939ad36e3 test(textarea): skip autogrow test due to flakiness (#27100) 2023-04-03 09:38:56 -07:00
Ryan Waskiewicz
1638749be3 chore(ci): use stencil nightly tags (#26927)
this commit removes the retrieval of stencil source code and building
the library from source. with
24887c0da0
(https://github.com/ionic-team/stencil/pull/4100), stencil now creates
nightly builds from `main@HEAD` of the repository. these pre-built
packages are tagged as "nightly", allowing us to bypass the previously
mentioned build steps and install the package directly

rename stencil-eval to stencil-nightly to better reflect what the
workflow is running. since ionic framework v7.0 has been released,
its feature branch has been removed/merged into `main`. remove
usages of `feature-7.0` in favor of `main`
2023-04-03 09:18:36 -04:00
Shawn Taylor
426913d0de fix(item-divider): set padding-end for md (#27019)
closes #23785
2023-03-31 17:00:12 -04:00
Amanda Johnston
75186d3f83 docs(content): fix typo in forceOverscroll description (#27077) 2023-03-31 10:17:36 -05:00
Brandy Carney
cbf7f7286e chore(readme): update migration guides to correct links (#27072) 2023-03-31 10:34:26 -04:00
Sean Perkins
141ced5010 fix(breadcrumbs): color attribute shows on DOM for Vue (#27068)
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
2023-03-30 17:11:22 -04:00
Brandy Carney
6d851f19f8 chore(breaking): update utilities title in v7 breaking changes (#27043) 2023-03-30 15:34:54 -04:00
Liam DeBeasi
14145dcaeb fix(vue): v-model props have correct type (#27067)
resolves #27057
2023-03-30 14:32:19 -04:00
Sean Perkins
abadeedc9e Revert "bug(breadcrumbs): color attribute shows on DOM for Vue (#27040)" (#27069)
This reverts commit dd419c0066.

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
2023-03-30 13:50:34 -04:00
Maria Hutt
dd419c0066 bug(breadcrumbs): color attribute shows on DOM for Vue (#27040)
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-03-30 09:57:02 -07:00
Liam DeBeasi
7864a21ca3 chore(): merge feature-7.0 into main
chore(): merge feature-7.0 into main
2023-03-30 12:16:46 -04:00
Liam DeBeasi
df186bb743 merge release-7.0.0
Release 7.0.0
2023-03-29 13:35:24 -04:00
ionitron
8d4247d7d0 chore(): update package lock files 2023-03-29 17:00:27 +00:00
ionitron
b6e3d587b9 v7.0.0 v7.0.0 2023-03-29 17:00:15 +00:00
Liam DeBeasi
1749f5d7cb chore(ci): update workflow options 2023-03-29 16:00:36 +00:00
Liam DeBeasi
9d34501f0f merge release-7.0.0-rc.5
Release 7.0.0 rc.5
2023-03-29 11:56:33 -04:00
Liam DeBeasi
a4fa2d5b97 chore(): clean up changelogs 2023-03-29 10:16:16 -04:00
ionitron
09aa2e2c11 chore(): update package lock files 2023-03-29 14:12:40 +00:00
ionitron
5f53a0a63a v7.0.0-rc.5 v7.0.0-rc.5 2023-03-29 14:12:26 +00:00
Liam DeBeasi
4781ecc004 chore(): sync with main
chore(): sync with main
2023-03-29 10:05:01 -04:00
ionitron
8ff83b8098 chore(): add updated snapshots 2023-03-29 13:40:26 +00:00
Liam DeBeasi
f750c8756f chore(): sync with main 2023-03-29 09:17:21 -04:00
Liam DeBeasi
4b822eac5d merge release-6.7.1
Release 6.7.1
2023-03-29 09:08:49 -04:00
ionitron
f5de56dd07 chore(): update package lock files 2023-03-29 12:47:17 +00:00
ionitron
661b5de825 v6.7.1 v6.7.1 2023-03-29 12:47:04 +00:00
Sean Perkins
ee19891542 fix(select): update iOS icon (#27001) 2023-03-28 16:49:14 -04:00
Liam DeBeasi
521063bf24 fix(item-sliding): open method works with items added async (#27035)
resolves #26991
2023-03-28 12:53:36 -04:00
Liam DeBeasi
c9e4cd002d chore(): update playwright (#27037) 2023-03-28 12:30:34 -04:00
Liam DeBeasi
408457aa95 fix(select): alert header defaults to label (#27034)
resolves #27028
2023-03-28 11:09:42 -04:00
Amanda Johnston
0a04310f11 test(popover): re-enable size test (#27033) 2023-03-28 09:20:28 -05:00
dependabot[bot]
9ba8f0a53f chore(deps-dev): bump @playwright/test from 1.32.0 to 1.32.1 in /core (#27036)
Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.32.0 to 1.32.1.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](https://github.com/Microsoft/playwright/compare/v1.32.0...v1.32.1)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-28 09:18:39 -04:00
Liam DeBeasi
5c0ead37bf docs(config): update innerHTML comments (#27032) 2023-03-27 15:14:02 -04:00
Ryan Waskiewicz
ae482823e5 chore(dev-deps): update stencil framework wrappers (#27031)
this commit updates the stencil framework wrappers to the latest
published versions of the library. each of the wrappers have been
updated such that their peer dependencies no longer require
'3.0.0-beta.0', and now require '3.0.0'
2023-03-27 13:49:04 -04:00
Liam DeBeasi
2400ed5a66 merge release-7.0.0-rc.4
Release 7.0.0 rc.4
2023-03-27 12:44:12 -04:00
Liam DeBeasi
6a06354798 chore(): clean up changelog 2023-03-27 12:20:41 -04:00
ionitron
a6b3888453 chore(): update package lock files 2023-03-27 16:15:53 +00:00
ionitron
ae173317ec v7.0.0-rc.4 v7.0.0-rc.4 2023-03-27 16:15:39 +00:00
Liam DeBeasi
b7e46038e0 fix(many): innerHTML is disabled by default (#27029)
BREAKING CHANGE:

The `innerHTMLTemplatesEnabled` Ionic Config now defaults to `false`. Developers can set this option to `true` if they would like to continue to use custom HTML features in `ion-alert`, `ion-infinite-scroll-content`, `ion-loading`, `ion-refresher-content`, and `ion-toast`.
2023-03-27 12:07:00 -04:00
Liam DeBeasi
f68644065c test(datetime): display tests wait for class (#27017) 2023-03-27 09:47:28 -04:00
Liam DeBeasi
b148384a13 chore(): sync with main
chore(): sync with main
2023-03-24 17:38:59 -04:00
Maria Hutt
a396e8857b refactor(alert): switch ev.code to ev.key (#27023) 2023-03-24 13:31:30 -07:00
Liam DeBeasi
e9208eae53 chore(): update textarea test 2023-03-24 16:22:30 -04:00