Commit Graph

133 Commits

Author SHA1 Message Date
Brandy Carney
8564d79a7d fix(menu): fix enabled check
references #5535
2016-02-19 20:36:27 -05:00
Brandy Carney
5f31df05de test(menu): add karma tests 2016-02-19 20:36:05 -05:00
Brandy Carney
f0b5838880 test(menu): update test to use 3 menus and menu toggle by side
references #5535
2016-02-19 16:18:55 -05:00
Brandy Carney
a2b7a21a95 feat(menu): grab the menu by side only if it is enabled
this removes the need to pass an id when you enable one menu

references #5535
2016-02-19 16:18:31 -05:00
Brandy Carney
5e1eeff40d test(menu): add test that reproduces issue with multiple menus and navbar toggles 2016-02-19 14:47:42 -05:00
Adam Bradley
93b456145c chore(gestures): add isListening to gestures 2016-02-16 22:20:14 -06:00
Adam Bradley
80fa94bd41 chore(types): add types to slide gestures 2016-02-16 22:08:22 -06:00
Adam Bradley
d33db81ed6 chore(menu): rename swipe progress steps 2016-02-16 20:21:33 -06:00
Adam Bradley
0d47a1b79f feat(menu): allow persistent menus
Closes #5204
2016-02-15 21:40:16 -06:00
Adam Bradley
c02fb51d04 feat(menu): close any opened menu 2016-02-15 19:42:30 -06:00
Adam Bradley
ff24152524 fix(menu): add/remove gesture listeners per enabled menu 2016-02-15 13:23:01 -06:00
Adam Bradley
3bb09cee07 feat(MenuController): create isOpen() and isEnabled()
Closes #5390
2016-02-13 00:54:01 -06:00
mhartington
019009a3e2 chore(): fix bad types for docs 2016-02-12 16:36:27 -05:00
mhartington
5941042a98 chore() normalize types in docs 2016-02-12 15:51:28 -05:00
Tim Lancina
5f254f285f chore(e2e): make typescript and e2e friends 2016-02-12 11:37:39 -06:00
Brandy Carney
17c1846f05 test(menu): fix menu swipe enabling on right side menu 2016-02-10 11:01:41 -06:00
Adam Bradley
7c10c4dd42 chore(): update modal tests 2016-02-10 01:56:51 -06:00
Adam Bradley
da18868636 refactor(animations): inline css animations 2016-02-09 16:23:01 -06:00
Brandy Carney
86f793dcee test(menu): fix snapshot test 2016-02-05 16:20:27 -05:00
mhartington
c7a58f0dfc docs(menu): update docs 2016-02-05 15:06:54 -05:00
Adam Bradley
fc49d1aa29 docs(menu): update menuToggle menuClose docs 2016-02-04 20:32:24 -06:00
Adam Bradley
9f906ae8ae docs(MenuController): update MenuController docs 2016-02-04 20:15:40 -06:00
Adam Bradley
acf12cdd15 refactor(menu): inject MenuController to control app menus
Menu has been improved to make it easier to open, close, toggle and
enable menus.
Instead of injecting `IonicApp` to find the menu component, you now
inject
`MenuController`.

Was:

```
constructor(app: IonicApp) {
  this.app = app;
}
openMenu() {
  this.app.getComponent('leftMenu').close();
}
```

Now:

To programmatically interact with any menu, you can inject the
`MenuController`
provider into any component or directive. This makes it easy get ahold
of and
control the correct menu instance. By default Ionic will find the app's
menu
without requiring a menu ID. An id attribute on an `<ion-menu>` is only
required
if there are multiple menus on the same side. If there are multiple
menus, but
on different sides, you can use the name of the side to get the correct
menu

If there's only one menu:

```
constructor(menu: MenuController) {
  this.menu = menu;
}
openMenu() {
  this.menu.close();
}
```

If there is a menu on the left and right side:

```
toggleMenu() {
  this.menu.toggle('left');
}
```

If there are multiple menus on the same side:

```
<ion-menu id="myMenuId" side="left">...</ion-menu>
<ion-menu id="otherMenuId" side="left">...</ion-menu>

closeMenu() {
  this.menu.close('myMenuId');
}
```
2016-02-04 16:47:05 -06:00
Adam Bradley
a42836340a fix(menu): only close when open on enable change 2016-02-04 12:22:09 -06:00
Adam Bradley
72699dbbb4 fix(menu): fix scrolling page w/ side menus
Improved which angles should allow the side menu to open, depending if
it’s a left or right menu. Also check if the distance of the drag is
longer than a side menu would get. For example, scrolling vertically
for a long ways would have a long distance, but triggering a side menu
to open would be a short distance.

Also ensure that a side menu can always be closed incase something goes
wrong.

Closes #5272
2016-02-02 16:41:35 -06:00
mhartington
d8a4ec3893 docs(menu, menuClose, menuToggle): update docs 2016-02-01 16:27:26 -05:00
Adam Bradley
dbc681fb7c docs(): hide methods not requiring docs 2016-01-27 14:27:36 -06:00
Adam Bradley
42f6b1056f fix(input): update input css/tests 2016-01-27 08:09:37 -06:00
Brandy Carney
0b0500d242 fix(menu): fix right side menu - platform becomes _platform
Closes #5147
2016-01-25 17:09:57 -05:00
David Kronmueller
504540f51c feat(menu): restrain menu slide start to a specific angle
The menu curently opens and closes at any angle of slide action. In case the menu has enough items
to create a vertical scrollbar it makes it impossible for the user the scroll vertically without
affecting the slide behavior of the menu. This fix restrains the menu open/close to a specific
angle.

#5180
2016-01-25 14:22:38 +01:00
Adam Bradley
f5f4169db0 fix(NavController): default setRoot/setPages to not animate transitions
setRoot() will be commonly used by side menus, which should not animate between pages.
2016-01-21 16:38:57 -06:00
Adam Bradley
ee106377fc chore(angular): upgrade to angular 2.0.0-beta.1
Biggest change was that renderer takes  and not just .
2016-01-20 11:15:01 -06:00
Eddie Lau 3dd13
0ef8c78737 add swipeEnabled input to menu to set default swipeable of side menu. add swipeEnable() api to enable disable particular side menu swipeable 2016-01-18 12:29:57 +08:00
Adam Bradley
02626b9489 chore(): add types to Refresher 2016-01-14 21:04:20 -06:00
Adam Bradley
e3507bc175 chore(): add types to List 2016-01-14 20:25:33 -06:00
Adam Bradley
146cb06df2 chore(): add types to menu-toggle 2016-01-14 20:09:08 -06:00
Tim Lancina
2a2d568162 chore(): fix Menu types 2016-01-13 23:06:13 -06:00
Tim Lancina
c4d59002c0 chore(): fix menu types 2016-01-13 21:03:37 -06:00
Adam Bradley
88aad3f880 refactor(decorators): remove ConfigComponent 2016-01-11 22:51:54 -06:00
Adam Bradley
7dd65f3571 refactor(icon): logo ionicons use logo- prefix rather than suffix 2016-01-11 14:42:39 -06:00
Adam Bradley
b79d6cc8ea refactor(util): use Object.assign polyfill 2016-01-11 11:17:58 -06:00
Gautier Fauchart
f13eab910c Fix HammerJS Pan config bug 2016-01-10 20:07:34 +00:00
Gautier Fauchart
639dd23a49 make the menu threshold configurable 2016-01-10 00:08:54 +00:00
Adam Bradley
883e1b68b1 refactor(icon): rename icon to ion-icon
Closes #855
2016-01-05 22:27:07 -06:00
Adam Bradley
1e427443ad chore(): fix overlay demos/tests 2015-12-30 20:38:27 -06:00
Adam Bradley
c136d2143a alert wip 2015-12-23 23:11:40 -06:00
mhartington
0f64bccc43 chore(): prefix private methods 2015-12-18 15:39:22 -05:00
Adam Bradley
8b35fae3bd fix(typo): change deTEction 2015-12-18 11:04:30 -06:00
Adam Bradley
c118009a7c fix(menu): run gestures outside of zone
Closes #755
2015-12-18 10:58:08 -06:00
mhartington
7138e61e2d docs()menus 2015-12-16 17:05:21 -05:00