javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(menu): restrain menu slide start to a specific angle

Browse Source 
The menu curently opens and closes at any angle of slide action. In case the menu has enough items
to create a vertical scrollbar it makes it impossible for the user the scroll vertically without
affecting the slide behavior of the menu. This fix restrains the menu open/close to a specific
angle.

#5180
This commit is contained in:
David Kronmueller
2016-01-25 14:22:38 +01:00
parent 8fc159e2e8
commit 504540f51c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ionic/components/menu/menu-gestures.ts
View File

@@ -5,7 +5,7 @@ import {assign} from '../../util/util';
export class MenuContentGesture extends SlideEdgeGesture {
constructor(public menu: Menu, targetEl: Element, options = {}) {
super(targetEl, assign({
@@ -19,7 +19,8 @@ export class MenuContentGesture extends SlideEdgeGesture {
}
canStart(ev) {
return this.menu.isOpen && this.menu.isEnabled ? true : super.canStart(ev);
let validAngle = ((-35 <= ev.angle && ev.angle <= 35) || (180 >= ev.angle && ev.angle >= 145) || (-180 <= ev.angle && ev.angle <= -145));
return this.menu.isOpen && this.menu.isEnabled && validAngle ? true : super.canStart(ev);
}
// Set CSS, then wait one frame for it to apply before sliding starts