javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 19:57:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(gulp): update core task to run done on compile

Browse Source
This commit is contained in:
Brandy Carney
2017-06-14 12:56:21 -04:00
parent 005035bb46
commit e4df27a511
3 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/gulp/tasks/core.ts
View File

@ -37,10 +37,10 @@ function buildAngularBinding(isDevAndWatch: boolean, done: Function) {
ls.stdout.on('data', (data) => {
console.log(data.toString().trim());
// if (!hasRunDone && data.toString().trim().indexOf('compile, done') > -1) {
// hasRunDone = true;
// done();
// }
if (!hasRunDone && data.toString().trim().indexOf('compile, done') > -1) {
hasRunDone = true;
done();
}
});
ls.stderr.on('data', (data) => {
@ -48,6 +48,9 @@ function buildAngularBinding(isDevAndWatch: boolean, done: Function) {
});
ls.on('close', (code) => {
if (!hasRunDone) {
hasRunDone = true;
done();
}
});
}

6
src/components/icon/icon.scss
View File

@ -7,13 +7,15 @@
ion-icon {
visibility: inherit !important;
display: inline-block;
font-size: 1.2em;
}
ion-icon.hydrated {
visibility: inherit;
}
ion-icon[small] {
min-height: 1.1em;

1
src/util/interfaces.ts
View File

@ -709,7 +709,6 @@ export interface VNodeData {
on?: any;
vkey?: Key;
vns?: string; // for SVGs
[key: string]: any; // for any other 3rd party module
}