From e4df27a511cda3f12bb7c80bbc844fcb3c093f55 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Wed, 14 Jun 2017 12:56:21 -0400 Subject: [PATCH] chore(gulp): update core task to run done on compile --- scripts/gulp/tasks/core.ts | 13 ++++++++----- src/components/icon/icon.scss | 6 ++++-- src/util/interfaces.ts | 1 - 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/scripts/gulp/tasks/core.ts b/scripts/gulp/tasks/core.ts index 23545c7b30..f1486faa41 100644 --- a/scripts/gulp/tasks/core.ts +++ b/scripts/gulp/tasks/core.ts @@ -37,10 +37,10 @@ function buildAngularBinding(isDevAndWatch: boolean, done: Function) { ls.stdout.on('data', (data) => { console.log(data.toString().trim()); - // if (!hasRunDone && data.toString().trim().indexOf('compile, done') > -1) { - // hasRunDone = true; - // done(); - // } + if (!hasRunDone && data.toString().trim().indexOf('compile, done') > -1) { + hasRunDone = true; + done(); + } }); ls.stderr.on('data', (data) => { @@ -48,6 +48,9 @@ function buildAngularBinding(isDevAndWatch: boolean, done: Function) { }); ls.on('close', (code) => { - done(); + if (!hasRunDone) { + hasRunDone = true; + done(); + } }); } diff --git a/src/components/icon/icon.scss b/src/components/icon/icon.scss index 1304ebdce4..52cb1b6127 100644 --- a/src/components/icon/icon.scss +++ b/src/components/icon/icon.scss @@ -7,13 +7,15 @@ ion-icon { - visibility: inherit !important; - display: inline-block; font-size: 1.2em; } +ion-icon.hydrated { + visibility: inherit; +} + ion-icon[small] { min-height: 1.1em; diff --git a/src/util/interfaces.ts b/src/util/interfaces.ts index 77637d2531..e4a87746c0 100644 --- a/src/util/interfaces.ts +++ b/src/util/interfaces.ts @@ -709,7 +709,6 @@ export interface VNodeData { on?: any; vkey?: Key; vns?: string; // for SVGs - [key: string]: any; // for any other 3rd party module }