javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(scroll): cleanup native scroll listeners only if activated

Browse Source
This commit is contained in:
perry
2015-02-13 11:51:06 -06:00
parent be09433608
commit df6dcb96f6
2 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
js/angular/controller/refresherController.js vendored
View File

@@ -246,14 +246,14 @@ IonicModule
ionic.on('touchmove', handleTouchmove, scrollChild);
ionic.on('touchend', handleTouchend, scrollChild);
ionic.on('scroll', handleScroll, scrollParent);
// cleanup when done
$scope.$on('$destroy', destroy);
};
$scope.$on('$destroy', destroy);
function destroy() {
ionic.off('dragdown', handleTouchmove, scrollChild);
ionic.off('dragend', handleTouchend, scrollChild);
ionic.off('touchmove', handleTouchmove, scrollChild);
ionic.off('touchend', handleTouchend, scrollChild);
ionic.off('scroll', handleScroll, scrollParent);
scrollParent = null;
scrollChild = null;

12
test/unit/angular/controller/refreshController.unit.js
View File

@@ -126,4 +126,16 @@ describe('$ionicRefresh Controller', function() {
ctrl.getRefresherDomMethods().hide();
expect(refresher.classList.contains('invisible')).toBe(true);
});
it('should cleanup when done', function() {
setup();
expect(ctrl.__getScrollChild()).not.toBe(null);
expect(ctrl.__getScrollParent()).not.toBe(null);
scope.$broadcast('$destroy');
expect(ctrl.__getScrollChild()).toBe(null);
expect(ctrl.__getScrollParent()).toBe(null);
});
});